Pup - the AI's own browser

@@ -1997,21 +1997,28 @@ async function parkSessionWindowDirect(page, sessionId) {   try {     cdp = await page.target().createCDPSession();     const { windowId } = await cdp.send('Browser.getWindowForTarget');-    // Full-size via the OS's own maximize (CDP windowState) — no pixel math, no screen-size-    // probe that can fail mid-navigation (a failed probe shipped 1600×900 windows once).-    // v1.8.64: stage the window JUST past the LEFT EDGE of the primary monitor before-    // maximizing — fully invisible but ADJACENT, so the OS targets the primary monitor.-    // Two rejected alternatives (both tested):-    //   - maximize from deep off-screen (-32000): garbage bounds (landed at -21333, 159×27);-    //   - stage ON-screen small then maximize: the window is only z-bottom, not hidden, so-    //     the user sees a small window appear and then GROW (John: "why isn't it just the-    //     size of my screen from the get-go?").-    // Neither call activates the window, so z-order is preserved — it first becomes visible-    // already maximized.-    const placeOnScreen = async () => {-      await cdp.send('Browser.setWindowBounds', { windowId, bounds: { windowState: 'normal' } });-      await cdp.send('Browser.setWindowBounds', { windowId, bounds: { left: -1310, top: 100, width: 1280, height: 800 } });-      await cdp.send('Browser.setWindowBounds', { windowId, bounds: { windowState: 'maximized' } });+    // v1.8.65: full-size placement via AD `desktop_set_window_bounds` (background drive,+    // physical px, restore:false → MoveWindow only: no activation, NO Z-ORDER CHANGE), sized+    // to the primary monitor from AD `desktop_list_monitors` (native, cached 10 min).+    // DO NOT use CDP `windowState:'maximized'` — Chromium implements it as ShowWindow(+    // SW_MAXIMIZE), which RAISES the window to the top of the z-order (no focus steal, but it+    // COVERS the user's work — John caught five windows stacked right under his editor, and+    // the "small-then-grow" he saw earlier was the same raise making the staging visible).+    // The window ends up in normal state sized to the monitor = visually full-screen, still+    // at the z-bottom where the force-bottom put it.+    const placeOnScreen = async (targetHwnd) => {+      let wa = _primaryMonitorCache && (Date.now() - _primaryMonitorCache.ts < 600000) ? _primaryMonitorCache : null;+      if (!wa) {+        try {+          const r = await chrome.adCommand('desktop_list_monitors', {}, { timeoutMs: 4000 });+          const raw = r && (typeof r.output === 'string' && r.output ? JSON.parse(r.output) : r.output || r);+          const mons = (raw && (raw.monitors || (raw.data && raw.data.monitors))) || [];+          const prim = mons.find(m => m.primary) || mons[0];+          if (prim && prim.width) { wa = { ts: Date.now(), x: prim.x || 0, y: prim.y || 0, w: prim.width, h: prim.height }; _primaryMonitorCache = wa; }+        } catch (e) {}+      }+      const b = wa || { x: 0, y: 0, w: 1600, h: 900 };+      await chrome.adCommand('desktop_set_window_bounds', { hwnd: targetHwnd, x: b.x, y: b.y, w: b.w, h: b.h, restore: false }, { timeoutMs: 5000 });     };     // hwnd via AD (native) — the title suffix "(session: <id>" is set by the welcome page.     // v1.8.59 HARD RULES, learned the expensive way:@@ -2044,13 +2051,13 @@ async function parkSessionWindowDirect(page, sessionId) {         const raw = r && (typeof r.output === 'string' ? r.output : JSON.stringify(r.output || ''));         const o = raw ? JSON.parse(raw) : {};         const data = o.data || o;-        return { ok: !!data.sentToBack, wasForeground: !!data.wasForeground, err: data.sentToBack ? null : 'not sent to back' };+        return { ok: !!data.sentToBack, wasForeground: !!data.wasForeground, hwnd: data.hwnd || null, err: data.sentToBack ? null : 'not sent to back' };       } catch (e) { return { ok: false, err: e.message }; }     };-    let bottomed = false, lastErr = 'error';+    let bottomed = false, lastErr = 'error', parkHwnd = null;     for (let attempt = 0; attempt < 8; attempt++) {       const z = await adBottom();-      if (z.ok) { bottomed = true; break; }+      if (z.ok) { bottomed = true; parkHwnd = z.hwnd; break; }       lastErr = z.err || 'error';       // Two cases need the legacy PS path (BOTH auto-obsolete as desktops update to AD ≥1.9.115,       // whose force:true is honored above — delete this block once the fleet is there):@@ -2065,7 +2072,7 @@ async function parkSessionWindowDirect(page, sessionId) {           const o = r && (typeof r.output === 'string' ? JSON.parse(r.output) : r.output || r);           hwnd = (o && ((o.best && o.best.hwnd) || o.hwnd)) || null;         } catch (e) {}-        if (hwnd && osBottomUnlessForeground(hwnd, true) === 'bottomed') { bottomed = true; break; }+        if (hwnd && osBottomUnlessForeground(hwnd, true) === 'bottomed') { bottomed = true; parkHwnd = hwnd; break; }       }       await new Promise(r2 => setTimeout(r2, 300));     }@@ -2073,15 +2080,23 @@ async function parkSessionWindowDirect(page, sessionId) {       console.log(`[park] "${sessionId}": z-bottom NOT confirmed (${lastErr}) — leaving off-screen (no pop), self-heal will retry`);       return 'park-failed';     }-    // On-screen full-size WITHOUT activation — CDP move preserves z-order (we're at bottom).-    await placeOnScreen();+    // On-screen full-size WITHOUT activation — AD MoveWindow preserves z-order (we're at bottom).+    if (!parkHwnd) {+      try {+        const r = await chrome.adCommand('desktop_find_window', { titleContains: `(session: ${sessionId}` }, { timeoutMs: 4000 });+        const o = r && (typeof r.output === 'string' ? JSON.parse(r.output) : r.output || r);+        parkHwnd = (o && ((o.best && o.best.hwnd) || o.hwnd)) || null;+      } catch (e) {}+    }+    if (!parkHwnd) { console.log(`[park] "${sessionId}": no hwnd for placement — leaving off-screen, self-heal will retry`); return 'park-failed'; }+    await placeOnScreen(parkHwnd);     // Verify POSITION, not just focus.     let verified = false;     try {       const gb = await cdp.send('Browser.getWindowBounds', { windowId });       const b = gb && gb.bounds;-      // v1.8.64: threshold -1000 (was -5000) so a window stuck at the -1310 edge-adjacent-      // staging spot (failed maximize) reads as NOT verified instead of passing.+      // v1.8.64: threshold -1000 (was -5000) so a stuck-off-screen window reads as NOT+      // verified instead of passing.       verified = !!(b && b.left > -1000 && b.top > -1000);     } catch (e) {}     return verified ? 'backgrounded' : 'park-failed';@@ -2251,6 +2266,7 @@ const MUTATING_VERBS = new Set(['browser_open_window', 'browser_open_tab', 'brow // Debounced auto-flash: one flash per window per ~5s burst of verbs, re-armed after // quiet. {silent:true} on the verb OR session._flashSilent (session default) suppresses. const _flashState = new Map(); // sessionId -> last flash ts+let _primaryMonitorCache = null; // v1.8.65: {ts,x,y,w,h} from desktop_list_monitors (10-min TTL) function scheduleAutoFlash(session, opts) {   opts = opts || {};   if (process.platform !== 'win32' || !session || !session._sessionId) return;