← Commit history

Close issue 53: switching to plain now schedules a deferred second strip pass that re-resolves and wipes any window whose handle was not resolvable at switch time, so no straggler keeps a branded button.

John Lauer ·a54601a02d ·2mo ago ·parent bde4a49
4 files changed +26−6
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.199",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.199/adom-bridge-puppeteer-v2.0.199.zip",-  "sha256": "0d2eba90a4df64fd9b9d2fac78e6e0e5f13f132263a80675dae58559c1939d16",-  "size": 926883,+  "version": "2.0.200",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.200/adom-bridge-puppeteer-v2.0.200.zip",+  "sha256": "9395f823bda1296cfeac6326127bd60048874270b34eecc35fb3bd6c1de38dc8",+  "size": 927269,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.199+2.0.200
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.199",+  "version": "2.0.200",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+20
@@ -4619,6 +4619,26 @@ public static class Wipe {     } catch (e) { console.log(`[identity] plain wipe spawn failed: ${e.message}`); }   }   console.log(`[identity] stripped ${ids.size} registered identit(ies), wiping window props on ${hwnds.length} window(s) (${reason})`);+  // v2.0.200 (#53, reproduced twice in six-state proofs): sessions whose hwnd was unresolved at+  // strip time kept their branded button. Schedule ONE deferred pass: re-resolve and wipe the+  // stragglers ~12s later, when bounds/title resolution has usually caught up.+  const _missed = targets.filter(([, s9]) => !s9._hwnd).map(([sid9]) => sid9);+  if (_missed.length && !reason.endsWith('(deferred)')) {+    setTimeout(() => {+      (async () => {+        try {+          if (pupSettings().aumidIcons === 'on') return;   // mode changed again — stale pass, skip+          let n = 0;+          for (const sid9 of _missed) {+            const s9 = sessions.get(sid9); if (!s9) continue;+            try { if (!s9._hwnd) await resolveSessionHwndByBounds(s9, sid9); } catch (e) {}+            if (s9._hwnd) n++;+          }+          if (n) { console.log(`[identity] deferred plain strip: ${n} straggler(s) now resolvable — re-stripping`); await stripAllPupIdentities(reason + ' (deferred)'); }+        } catch (e) {}+      })();+    }, 12000);+  } } let _nudgeUntil = 0;   // v2.0.172: while set, ignore window-opened events caused by our own nudge function nudgeTaskbarButton(hwnd, sessionId) {