Pup - the AI's own browser

@@ -3818,6 +3818,21 @@ async function fetchPageFavicon(page) {         }         continue;       }+      // v1.9.204: a file:// page's favicon href is itself file:// — Node's fetch CANNOT fetch that,+      // so every local-file window silently lost its icon and rendered no overlay at all (John's first+      // taskbar button). The bridge runs on the SAME machine as Chrome, so just read it off disk.+      if (/^file:/i.test(href)) {+        try {+          const fp = decodeURIComponent(new URL(href).pathname).replace(/^\/([A-Za-z]:)/, '$1');+          const buf = fs.readFileSync(fp);+          if (buf && buf.length) {+            const ext = (fp.split('.').pop() || '').toLowerCase();+            const mime = ext === 'ico' ? 'image/x-icon' : ext === 'svg' ? 'image/svg+xml' : ext === 'jpg' || ext === 'jpeg' ? 'image/jpeg' : 'image/png';+            return { b64: buf.toString('base64'), mime, href };+          }+        } catch (e) {}+        continue;+      }       const r = await fetch(href, { redirect: 'follow', signal: AbortSignal.timeout(4000) });       if (!r || !r.ok) continue;       const buf = Buffer.from(await r.arrayBuffer());@@ -3828,6 +3843,58 @@ async function fetchPageFavicon(page) {   return null; } const _appOverlayCache = new Map(); // sessionId -> composited b64+// v1.9.204 (John: "the active tab in that first taskbar icon is this you fucktard" — a tab that+// plainly HAS a favicon, while pup reported "no favicon on the active tab"). ROOT CAUSE: pup picked+// the tab from its OWN bookkeeping (session.activeTabId), which drifts out of sync the moment the user+// switches tabs themselves — the same drift that made the unstick misfire. He asked for "the favicon+// from the chrome tab that's in the foreground", so ASK CHROME: in a given window exactly one tab+// reports document.visibilityState === 'visible', and that IS the active tab.+async function resolveVisibleTab(session) {+  const tabs = (session.tabs || []).filter(t => t && t.page && !t._crashed);+  if (!tabs.length) return null;+  if (tabs.length === 1) return tabs[0];+  for (const t of tabs) {+    try {+      const v = await withTimeout(t.page.evaluate('document.visibilityState'), 1200, 'vis');+      if (v === 'visible') return t;+    } catch (e) {}+  }+  return (session.tabs || []).find(t => t.tabId === session.activeTabId) || tabs[0];+}++// v1.9.203 (John: "in the 3rd taskbar icon you only have the little teal adom favicon and not the+// main favicon from the active tab"). ROOT CAUSE: sharp CANNOT decode .ico, and the compositor only+// built the favicon layer when the source was NOT an .ico — so every site serving favicon.ico silently+// lost its favicon and the badge rendered as the Adom mark alone. Most modern .ico files embed a PNG+// per size, so parse the container, take the LARGEST entry, and hand its PNG bytes to sharp.+// ICO layout: 6-byte header (count at offset 4), then 16-byte directory entries+// (w,h,colors,rsv,planes,bpp,bytesLE@8,offsetLE@12).+function icoLargestPng(buf) {+  try {+    if (!buf || buf.length < 22) return null;+    if (buf.readUInt16LE(0) !== 0 || buf.readUInt16LE(2) !== 1) return null;   // not an ICO+    const n = buf.readUInt16LE(4);+    if (!n) return null;+    let best = null;+    for (let i = 0; i < n; i++) {+      const e = 6 + i * 16;+      if (e + 16 > buf.length) break;+      const w = buf[e] === 0 ? 256 : buf[e];+      const h = buf[e + 1] === 0 ? 256 : buf[e + 1];+      const size = buf.readUInt32LE(e + 8);+      const off = buf.readUInt32LE(e + 12);+      if (off + size > buf.length || size <= 0) continue;+      const area = w * h;+      if (!best || area > best.area) best = { area, off, size };+    }+    if (!best) return null;+    const data = buf.subarray(best.off, best.off + best.size);+    // PNG-in-ICO (the common modern case) — usable directly.+    if (data.length > 8 && data[0] === 0x89 && data[1] === 0x50 && data[2] === 0x4e && data[3] === 0x47) return data;+    return null;   // BMP/DIB-encoded entry — sharp can't read it either; caller falls back+  } catch (e) { return null; }+}+ async function applyAppOverlay(session, sessionId) {   // v1.9.191 (John): overlays are the GENTLE branding path and are ALLOWED in minimal-touch.   // ITaskbarList3::SetOverlayIcon paints a badge onto the EXISTING taskbar button; it never@@ -3838,8 +3905,12 @@ async function applyAppOverlay(session, sessionId) {   try {     // v1.9.0: reflect the ACTIVE tab (John: favicons are more useful than counts — show what     // the user is looking at). Falls back to session.page.-    const activeTab = (session.tabs || []).find(t => t.tabId === session.activeTabId) || (session.tabs || [])[0];+    // v1.9.204: the ACTUALLY-visible tab, per Chrome — not pup's possibly-stale activeTabId.+    const activeTab = (await resolveVisibleTab(session)) || (session.tabs || [])[0];     const activePage = (activeTab && activeTab.page) || session.page;+    if (activeTab && activeTab.tabId && session.activeTabId !== activeTab.tabId) {+      session.activeTabId = activeTab.tabId;   // keep bookkeeping honest for everything downstream+    }     let src = session._appIconB64 ? { b64: session._appIconB64, mime: session._appIconMime || 'image/png' } : null;     if (!src) src = await fetchPageFavicon(activePage);     if (!src || !src.b64) {@@ -3883,7 +3954,14 @@ async function applyAppOverlay(session, sessionId) {           // .ico can't be decoded by sharp — when we NEED the green plate, fall back to drawing           // the plate alone rather than losing the signal entirely.           let iconPng = null;-          if (!isIco) {+          // v1.9.203: an .ico source now yields a real favicon layer via the extractor above.+          if (isIco) {+            try {+              const inner = icoLargestPng(Buffer.from(src.b64, 'base64'));+              if (inner) iconPng = await sharpMod(inner).resize(48, 48, { fit: 'cover' }).png().toBuffer();+            } catch (e) { iconPng = null; }+          }+          if (!iconPng && !isIco) {             try { iconPng = await sharpMod(Buffer.from(src.b64, 'base64')).resize(22, 22, { fit: 'inside' }).png().toBuffer(); } catch (e) { iconPng = null; }           }           // v1.9.191 (John's design): a TRULY BRANDED badge = the page's own favicon as the main@@ -3900,9 +3978,18 @@ async function applyAppOverlay(session, sessionId) {           // exact look it was designed with (no tinted card behind it), and the corner mark carries           // the branding. The mark sits on a small dark disc purely so it stays readable over busy           // or light favicon artwork at ~16px.-          let img = sharpMod({ create: { width: 32, height: 32, channels: 4, background: { r: 0, g: 0, b: 0, alpha: 0 } } });+          // v1.9.203 (John: "these overlay icons are a disaster"): composite at 48px, not 32px — the+          // same size the WORKING adom-browser-extension badge builder uses. The badge renders in a+          // ~16px taskbar slot, so compositing small and letting Windows shrink it turned both images+          // to mush. Build big, downscale once, and size the Adom mark as a fixed PROPORTION (3/8 of+          // the badge) so it is identical on every window instead of varying with each favicon's+          // internal padding.+          const BSZ = 48, MSZ = 18;   // 18/48 = 3/8+          let img = sharpMod({ create: { width: BSZ, height: BSZ, channels: 4, background: { r: 0, g: 0, b: 0, alpha: 0 } } });           const layers = [];-          if (iconPng) layers.push({ input: await sharpMod(Buffer.from(src.b64, 'base64')).resize(32, 32, { fit: 'inside' }).png().toBuffer(), gravity: 'northwest' });+          // Use the ALREADY-DECODED bytes — re-decoding src.b64 here is what broke .ico (sharp throws+          // on the raw container), silently dropping the favicon and leaving the Adom mark alone.+          if (iconPng) layers.push({ input: await sharpMod(iconPng).resize(BSZ, BSZ, { fit: 'cover' }).png().toBuffer(), gravity: 'northwest' });           try {             const markB64 = pupBadgeB64();             if (markB64) {@@ -3910,7 +3997,7 @@ async function applyAppOverlay(session, sessionId) {               // don't inset our favicon like i just saw you do"). NO disc, NO container. The Adom               // favicon itself occupies the lower-right QUADRANT, whole and flush to both edges               // (16x16 at 16,16 on the 32x32 badge), sitting directly on the page's own favicon.-              layers.push({ input: await sharpMod(Buffer.from(markB64, 'base64')).resize(16, 16, { fit: 'fill' }).png().toBuffer(), top: 16, left: 16 });+              layers.push({ input: await sharpMod(Buffer.from(markB64, 'base64')).resize(MSZ, MSZ, { fit: 'fill' }).png().toBuffer(), top: BSZ - MSZ, left: BSZ - MSZ });             }           } catch (e) { /* no mark available — favicon-only badge still valid */ }           if (layers.length) img = img.composite(layers);