← Commit history

Settings dialog round 3 (John's live review, four fixes). (1) The AUMID example now shows ONLY pup windows ('can you NOT show me other taskbar icons in this view? it confuses me') - a clean synthetic comparison built from his machine's real Chrome icon and the real pup tile: OFF = the same 5 windows stacked under ONE Chrome button; ON = the same 5 windows as 5 separate buttons. (2) Split vs grouped got its own comparative images ('that setting is REALLY confusing'), switching with the pulldown like icon-style: split = 5 separate buttons; grouped = one Adom Pup button wearing a 5-count. (3) TEST FLASH diagnosis ('the test flash button didn't work'): Windows never flashes the button of the FOCUSED window, and he clicked test while the dashboard was his active window - the caveat is now printed right under the test button, and the flash-all response reports how many buttons the flash was actually delivered to, shown in the toast ('N of M delivered'). (4) Jump-list real-screenshot capture is next (his mockup verdict: 'horrible. only screenshots will tell the real story') - this build carries the groundwork; the capture lands as an asset swap.

John Lauer ·a2819b74b8 ·2mo ago ·parent 4816423
4 files changed +12−11
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.264",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.264/adom-bridge-puppeteer-v1.9.264.zip",-  "sha256": "56265752153dc41c2634c813f0e794b193b7b81dbc9a7cb406771b394361d779",-  "size": 569667,+  "version": "1.9.265",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.265/adom-bridge-puppeteer-v1.9.265.zip",+  "sha256": "07d1ed12d6b58624056395ce298c37b83980650a7110fc97b9ce75ade6b046f9",+  "size": 521944,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.264+1.9.265
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.264",+  "version": "1.9.265",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+6−5
@@ -8502,7 +8502,7 @@ async function act(p){     const r=await fetch('/dashboard/action',{method:'POST',headers:{'Content-Type':'application/json'},body:JSON.stringify(p)});     const j=await r.json().catch(()=>({}));     const what=(ACTMSG[p.action]||p.action)+(p.sessionId?' '+p.sessionId:'');-    if(j.ok) toast(what+(p.action==='unflash-all'&&j.swept!=null?' ('+j.swept+' windows swept)':''), p.action.indexOf('close')===0?'success':'info');+    if(j.ok) toast(what+(p.action==='unflash-all'&&j.swept!=null?' ('+j.swept+' windows swept)':'')+(p.action==='flash-all'&&j.delivered!=null?' ('+j.delivered+' of '+j.n+' delivered)':''), p.action.indexOf('close')===0?'success':'info');     else toast(what+' failed'+(j.error?': '+j.error:''),'error');     return j;   }catch(e){toast(p.action+' failed: '+e.message,'error');}@@ -8512,7 +8512,7 @@ let SEENTOAST=0; // change POSTs set-setting and answers back with a toast. const SETTINGS_DEF=[  {k:'aumidIcons',l:'AUMID taskbar icons',d:'EXPERIMENT: give every pup window its OWN taskbar icon by stamping a per-window identity. Toggle on/off to test whether AUMID stamping is what crashes Chrome. Off = all windows share one Chrome button (current mode). Already-stamped windows keep their icon until closed.',img:'aumid'},- {k:'taskbarGrouping',l:'AUMID grouping',d:'Only applies when AUMID icons are on: split = one icon per window; grouped = all pup windows under one Adom Pup icon.',sel:['split','grouped'],dep:'aumidIcons'},+ {k:'taskbarGrouping',l:'AUMID grouping',d:'Only applies when AUMID icons are on: split = one icon per window; grouped = all pup windows under one Adom Pup icon.',sel:['split','grouped'],dep:'aumidIcons',imgBy:{split:'groupsplit',grouped:'groupgrouped'}},  {k:'aumidIconStyle',l:'AUMID icon style',d:'Only applies when AUMID icons are on: standard = one pup tile for every window; category = the custom set (wiki signed-out, wiki signed-in padlock, world icon for the open web, adom app icon, mixed).',sel:['standard','category'],dep:'aumidIcons',imgBy:{standard:'iconstylestd',category:'iconstylecat'}},  {k:'jumpLists',l:'Jump lists',d:'Build right-click jump-list menus on pup taskbar icons (illustrated below). Known to blip on Windows 11; off by default.',img:'jumplist'},  {k:'fgWatch',l:'20s foreground watch',d:'For 20s after a window opens or navigates in the background, watch whether something (JavaScript, Chrome, a focus change) brings it to the foreground, and caption that it was not Adom. Never moves the window.'},@@ -8546,7 +8546,7 @@ function renderDlg(){         +'<select data-sel="'+def.k+'" aria-label="'+esc(def.l)+'">'+def.sel.map(x=>'<option'+(st[def.k]===x?' selected':'')+'>'+x+'</option>').join('')+'</select></div>';     }     const on=st[def.k]==='on';-    const testRow=def.testflash?'<div class="sub"><span class="sdesc">'+((SNAP&&SNAP.counts&&SNAP.counts.windows)||0)+' pup window(s) open right now; their taskbar buttons will flash</span>'+    const testRow=def.testflash?'<div class="sub"><span class="sdesc">'+((SNAP&&SNAP.counts&&SNAP.counts.windows)||0)+' pup window(s) open right now; their taskbar buttons will flash. Note: Windows never flashes the button of the window you are LOOKING AT, so if this dashboard is your active window its own button stays unlit.</span>'       +'<button class="btn sm" data-act="flash-all" title="flash every open pup taskbar button so you can see what this looks like">test flash</button>'       +'<button class="btn sm" data-act="unflash-all" title="clear every taskbar flash">clear flash</button></div>':'';     return '<div class="srow"><div class="stxt"><div class="slbl">'+esc(def.l)+'</div><div class="sdesc">'+esc(def.d)+'</div>'+exImg+testRow+'</div>'@@ -8754,7 +8754,8 @@ const server = http.createServer(async (req, res) => {         if (act === 'unflash' && sid)  { try { await flashViaAD(sid, { stop: true, force: true }); } catch (e) {} return done({ ok: true }); }         if (act === 'flash-all' || act === 'unflash-all') {           const stop = act === 'unflash-all';-          for (const id of [...sessions.keys()]) { try { await flashViaAD(id, stop ? { stop: true, force: true } : { force: true }); } catch (e) {} }+          let delivered = 0;+          for (const id of [...sessions.keys()]) { try { const r = await flashViaAD(id, stop ? { stop: true, force: true } : { force: true }); if (r) delivered++; } catch (e) {} }           if (stop) {             // v1.9.243: sweep by ENUMERATION, not bookkeeping. The tracked set is per-boot, so any             // flash started before the last bridge restart was invisible to it (exactly what John@@ -8773,7 +8774,7 @@ const server = http.createServer(async (req, res) => {             console.log(`[flash] clear-all swept ${swept.size} enumerated pup Chrome windows + tracked set`);             return done({ ok: true, n: sessions.size, swept: swept.size });           }-          return done({ ok: true, n: sessions.size });+          return done({ ok: true, n: sessions.size, delivered });         }         return done({ ok: false, error: 'unknown action' });       } catch (e) { return done({ ok: false, error: e.message }); }