← Commit history

Fix jump-list items doing nothing (John: Close ALL and other menu items don't work): the bundled CLI renamed from adom-desktop-cli.exe in the Adom Desktop folder to adom-bridge-cli.exe in the Adom Bridge folder, but pupRelaunchCommand hardcoded the OLD path, so every jump-list task, taskbar header click, and pinned launch invoked a missing exe and silently no-opped (verified live: old path gone, new path exists). The bridge runs on the desktop so it now resolves the real exe from disk, Bridge name first with a legacy fallback, cached

John Lauer ·a26d2019bf ·2mo ago ·parent 02d064f
4 files changed +24−7
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.39",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.39/adom-bridge-puppeteer-v2.0.39.zip",-  "sha256": "62e8a931e2edbb60f9bdd00886927bc5df475e685bf6afa9618bd8ea52acc3f1",-  "size": 643374,+  "version": "2.0.40",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.40/adom-bridge-puppeteer-v2.0.40.zip",+  "sha256": "556491fb6ed63030b148c2fb7563c1dae3ea47e2bda09d97a60a0fffc0c6003f",+  "size": 643707,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.39+2.0.40
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.39",+  "version": "2.0.40",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+18−1
@@ -3297,8 +3297,25 @@ function ensureNotchedIcons() {   })();   return _notchReady; }+// v2.0.40 (John: jump-list items do nothing): the CLI RENAMED from adom-desktop-cli.exe (in+// "Adom Desktop\\") to adom-bridge-cli.exe (in "Adom Bridge\\"). pup hardcoded the OLD path, so+// every jump-list task + header click + pinned launch invoked a MISSING exe and silently no-opped+// (verified live: the old path is gone, the new one exists). The bridge runs ON the desktop, so it+// resolves the real exe from disk (Bridge name first, legacy fallback) and caches it.+let _cliExeCache = null;+function pupCliExe() {+  if (_cliExeCache) { try { if (fs.existsSync(_cliExeCache)) return _cliExeCache; } catch (e) {} _cliExeCache = null; }+  const la = process.env.LOCALAPPDATA || path.join(os.homedir(), 'AppData', 'Local');+  const candidates = [+    path.join(la, 'Adom Bridge', 'adom-bridge-cli.exe'),+    path.join(la, 'Adom Bridge', 'adom-desktop-cli.exe'),+    path.join(la, 'Adom Desktop', 'adom-desktop-cli.exe'),+  ];+  for (const c of candidates) { try { if (fs.existsSync(c)) { _cliExeCache = c; return c; } } catch (e) {} }+  return candidates[0];   // current product name is the best guess if none found on disk+} function pupRelaunchCommand(sessionId) {-  const cli = path.join(process.env.LOCALAPPDATA || path.join(os.homedir(), 'AppData', 'Local'), 'Adom Desktop', 'adom-desktop-cli.exe');+  const cli = pupCliExe();   const payload = JSON.stringify({ sessionId, foregroundReason: 'user clicked the Adom Pup taskbar header or pinned launcher', caller: { aiThread: 'user-taskbar-launcher' } }).replace(/"/g, '\\"');   // v1.9.115: same as the task commands — this runs when the user clicks the jump-list HEADER row or a   // pinned pup launcher, so it needs identity or AD refuses it and the click does nothing.