← Commit history

Fix: SVG favicons with only a viewBox (no width/height) were wrongly judged unreadable. The new analyzeIconBytes called sharp(bytes).stats() on the raw SVG, but such an SVG has no intrinsic size so sharp throws 'unsupported image' - the old paint path always .resize()d first, which masked it. Effect: the dashboard's OWN icon.svg (and any viewBox-only SVG favicon) resolved to 'none', its badge+favicon 404'd every SSE tick (52 console errors), and the overlay LED read red/MISMATCH. Fix: rasterize at a fixed 48px with high density FIRST, then measure transparency/luminance on the guaranteed-decodable PNG.

John Lauer ·a1cb047cce ·2mo ago ·parent 6e52aa5
4 files changed +13−9
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.239",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.239/adom-bridge-puppeteer-v1.9.239.zip",-  "sha256": "cac932515538f3626f49a0ad57a862ab91fbcd0ae92b4a42e4fc2fd82ab07d3d",-  "size": 463955,+  "version": "1.9.240",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.240/adom-bridge-puppeteer-v1.9.240.zip",+  "sha256": "4f129dae937d7f51171b80133097a7614ba5655e9f25c2034393f1ef12c23d38",+  "size": 464164,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.239+1.9.240
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.239",+  "version": "1.9.240",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+7−3
@@ -4052,11 +4052,15 @@ async function analyzeIconBytes(b64, mime, href) {   else if (mime.includes('jpeg') || ext === 'jpg' || ext === 'jpeg') format = 'jpeg';   else if (mime.includes('icon') || mime.includes('ico') || ext === 'ico') { format = 'ico'; const inner = icoLargestPng(buf); if (inner) input = inner; }   try {-    const img = sharpMod(input);-    const stats = await img.stats();+    // v1.9.240: RASTERIZE at a fixed size FIRST, then measure. An SVG with only a viewBox (no+    // width/height — like our own icon.svg) has no intrinsic size, so sharp.stats() on the raw bytes+    // throws "unsupported image" and the icon was wrongly judged unreadable. A high render density+    // keeps the raster crisp; measuring the PNG (always decodable) makes transparency/luminance robust.+    const opts = format === 'svg' ? { density: 384 } : {};+    const pngBuf = await sharpMod(input, opts).resize(48, 48, { fit: 'inside', background: { r: 0, g: 0, b: 0, alpha: 0 } }).png().toBuffer();+    const stats = await sharpMod(pngBuf).stats();     const ch = stats.channels || [];     const lum = ch.length >= 3 ? (0.299 * ch[0].mean + 0.587 * ch[1].mean + 0.114 * ch[2].mean) : (ch[0] ? ch[0].mean : 128);-    const pngBuf = await img.png().toBuffer();     return { pngBuf, b64: pngBuf.toString('base64'), format, transparent: !stats.isOpaque, darkDominant: lum < 80, lum: Math.round(lum) };   } catch (e) { return { pngBuf: null, b64: null, format, transparent: false, darkDominant: false, lum: null, unreadable: true }; } }