← Commit history

Fix the view-toggle verification caught during 2.0.132's live check: the public direction probed checkWikiAuth, a same-origin API fetch that carries the real session cookie which ?view=public deliberately leaves intact, so it always reported authed and the toggle wrongly fell back to the legacy jar relaunch. The public direction now probes the RENDER (the logged-out header's Login button) instead; the authed direction keeps the session check. An inconclusive probe trusts the param rather than relaunching.

John Lauer ·9c2b28bfe9 ·2mo ago ·parent 35f0355
4 files changed +23−9
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.132",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.132/adom-bridge-puppeteer-v2.0.132.zip",-  "sha256": "8dc87b24a8aef2dd1f07aec964f5d0d80ed60a733f0774624f72d98378846426",-  "size": 886958,+  "version": "2.0.133",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.133/adom-bridge-puppeteer-v2.0.133.zip",+  "sha256": "7bfd2814068dd1e952a1590e09c803e5ed1397defb85adbbdf9882650477294b",+  "size": 887245,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.132+2.0.133
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.132",+  "version": "2.0.133",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+17−3
@@ -13121,9 +13121,23 @@ const server = http.createServer(async (req, res) => {                   try { await t.page.goto(target, { waitUntil: 'domcontentloaded', timeout: 25000 }); } catch (e) {}                 }                 const _at = _wTabs.find(t => t.tabId === session.activeTabId) || _wTabs[0];-                let _a = null; try { _a = await checkWikiAuth(_at.page); } catch (e) {}-                const _renderedAuthed = !!(_a && _a.authed);-                if (view === 'public' && _renderedAuthed) {+                // v2.0.133 (caught live in verification): checkWikiAuth is a same-origin API fetch+                // that carries the REAL session cookie — which ?view=public deliberately leaves+                // untouched — so it always reports "authed" and made this path conclude the server+                // ignored the param, falling back to the jar relaunch it was built to replace.+                // The param changes the RENDER, so probe the RENDER: a logged-out page shows the+                // Login button; a signed-in one shows the profile menu instead.+                let _renderLoggedOut = null;+                try {+                  _renderLoggedOut = await Promise.race([+                    _at.page.evaluate(() => { try { return [...document.querySelectorAll('a,button')].some(e => /^\s*Login\s*$/i.test(e.textContent || '')); } catch (e) { return null; } }),+                    new Promise(r => setTimeout(() => r(null), 4000)),+                  ]);+                } catch (e) {}+                let _a = null;+                if (view === 'authed') { try { _a = await checkWikiAuth(_at.page); } catch (e) {} }+                const _renderedAuthed = view === 'authed' ? !!(_a && _a.authed) : _renderLoggedOut === false;+                if (view === 'public' && _renderLoggedOut === false) {                   // Old server: the param was ignored. Strip it back off and fall through to the                   // legacy isolated-jar relaunch below.                   console.log(`[wikiview] "${sessionId}" server ignored ?view=public (old wiki build?) — restoring URLs and falling back to the jar relaunch`);