app
Pup - the AI's own browser
Public Made by Adomby adom
pup gives your AI a real browser on your desktop that it drives completely, in the background, signed in as you: windows that never jump in front of your work, one shared profile that learns your logins, and every window labeled with its AI thread's name in your taskbar or dock.
← Commit history
v1.8.18: fix browser_open_tab CDP-pipe deadlock on Edge (opener() check before target.page() in popup-tracker) + newPage timeout guard
4 files changed
+29−15
adom-bridge-puppeteer-manifest.json+4−4@@ -1,10 +1,10 @@ { "manifest_version": 1, "name": "puppeteer",- "version": "1.8.17",- "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.8.17/adom-bridge-puppeteer-v1.8.17.zip",- "sha256": "3fc3755efa53248ad4f2cb77463aafa9bde5e6b8976a84cdab03ab0249c32936",- "size": 143204,+ "version": "1.8.18",+ "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.8.18/adom-bridge-puppeteer-v1.8.18.zip",+ "sha256": "9037d5fb3bb0d14871cd9bdcf7d99578b08e8782f2589668709d2fb1425a9d0c",+ "size": 143656, "verbPrefixes": [ "browser_", "desktop_recorder_",
src/BRIDGE_VERSION+1−1@@ -1 +1 @@-1.8.17+1.8.18
src/bridge.json+1−1@@ -2,7 +2,7 @@ "manifest_version": 1, "name": "puppeteer", "displayName": "Puppeteer (Chrome for Testing + Native)",- "version": "1.8.17",+ "version": "1.8.18", "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job.", "homepage": "https://wiki.adom.inc/adom/adom-desktop", "author": "Adom Inc.",
src/server.js+23−9@@ -289,6 +289,22 @@ function wirePopupTracking(browser, profileName) { browser.on('targetcreated', async (target) => { try { if (target.type() !== 'page') return;++ // Check opener() FIRST — it's a synchronous target-info property, no page init.+ // A popup we care about (window.open / target=_blank) HAS an opener; a target+ // with NO opener is either the tab WE just made via browser.newPage() in+ // addTabToSession, or a truly external window — both of which we drop.+ // CRITICAL (v1.8.18): we must NOT `await target.page()` on an openerless target.+ // On Edge, awaiting the page of a target that our own newPage() is still+ // initializing re-enters the single-threaded CDP pipe and HANGS newPage() —+ // which then poisons the whole connection (every later screenshot / list / nav+ // times out). Bailing on opener()===null before target.page() avoids it entirely.+ const openerTarget = target.opener();+ if (!openerTarget) {+ console.log(`[popup-track] new tab on profile "${profileName}" with no opener — not tracking (our own newPage or external)`);+ return;+ }+ const popupPage = await target.page(); if (!popupPage) return; @@ -299,14 +315,6 @@ function wirePopupTracking(browser, profileName) { if (t.page === popupPage) return; } }-- // Find the session that owns the opener target. If there's no opener,- // we can't attribute the popup — drop silently.- const openerTarget = target.opener();- if (!openerTarget) {- console.log(`[popup-track] new tab on profile "${profileName}" with no opener — not tracking (likely external)`);- return;- } const ownerInfo = await findTabForTarget(openerTarget); if (!ownerInfo) { console.log(`[popup-track] new tab on profile "${profileName}", opener target unknown to any session — not tracking`);@@ -2034,7 +2042,13 @@ async function addTabToSession(sessionId, url) { if (!be || !be.browser.isConnected()) { throw new Error(`Session "${sessionId}" browser is not connected.`); }- const page = await be.browser.newPage();+ // Defensive timeout: newPage() should be near-instant, but if the browser ever+ // stalls creating the target we fail THIS verb fast with a clear error instead of+ // hanging past AD's HTTP budget (which used to leave the bridge unresponsive).+ const page = await Promise.race([+ be.browser.newPage(),+ new Promise((_, rej) => setTimeout(() => rej(new Error('newPage timed out — the browser did not create the tab in 20s. Retry browser_open_tab; if it persists, browser_close_window + browser_open_window.')), 20000)),+ ]); const tabId = attachTab(session, sessionId, page, { makeActive: true }); // Append per-tab suffix so the user can distinguish tabs by title