← Commit history

1.8.58: badge checks AD result and logs failures; debounce arms only on success

John Lauer ·96066cee7a · ·parent c876cbf
4 files changed +22−15
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.8.57",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.8.57/adom-bridge-puppeteer-v1.8.57.zip",-  "sha256": "98faae019cb48d8d1eee51551e300e92aed5874b75922e8b6059637a91390953",-  "size": 170117,+  "version": "1.8.58",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.8.58/adom-bridge-puppeteer-v1.8.58.zip",+  "sha256": "11edd92b64e7e8f7569f0717550dee6f646a0e60c2d6acbb0a32ebeed07b8599",+  "size": 170451,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.8.57\ No newline at end of file+1.8.58\ No newline at end of file
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.8.57",+  "version": "1.8.58",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+16−9
@@ -1573,15 +1573,23 @@ function pupBadgeB64() {   return _pupBadgeB64; } async function badgePupTaskbar(sessionId) {-  if (process.platform !== 'win32') return;+  if (process.platform !== 'win32') return false;   const icon = pupBadgeB64();-  if (!icon) return;+  if (!icon) { console.log('[badge] no icon asset — skipping'); return false; }+  // v1.8.58: CHECK the result and LOG failures. The old fire-and-forget swallowed everything —+  // when AD rejected/failed the call (e.g. window title not yet resolvable), the badge just+  // silently never appeared and every later attempt was debounced away.   try {-    await chrome.adCommand('desktop_taskbar', {+    const r = await chrome.adCommand('desktop_taskbar', {       titleContains: `(session: ${sessionId}`,       overlay: { icon, tooltip: 'Adom pup — driven from the cloud' },     }, { timeoutMs: 6000 });-  } catch (e) {}+    const raw = r && (typeof r.output === 'string' ? r.output : JSON.stringify(r.output || r));+    const failed = (r && r.error) || (raw && /"error"\s*:\s*"[^"]/.test(raw) && !/Taskbar updated/i.test(raw));+    if (failed) { console.log(`[badge] "${sessionId}" FAILED: ${(r && r.error) || raw.slice(0, 160)}`); return false; }+    console.log(`[badge] "${sessionId}" applied`);+    return true;+  } catch (e) { console.log(`[badge] "${sessionId}" threw: ${e.message}`); return false; } }  // NOTE: taskbar badge/overlay is an AD-CORE capability (desktop_taskbar, AD ≥1.8.152) — the@@ -3869,13 +3877,12 @@ const server = http.createServer(async (req, res) => {             recordAgentUpdate(session, 'browser_open_tab', args, tabId); // v1.8.23             scheduleAutoFlash(session, { silent: !!args.silent });             // v1.8.57: long-lived-app touchpoint (see switch_tab) — heal a stranded window,-            // re-badge debounced.+            // re-badge debounced (v1.8.58: only debounce on SUCCESS so failures retry).             if (process.platform === 'win32') {               healOffscreenWindow(session, sessionId).catch(() => {});               const now = Date.now();               if (!session._badgedAt || now - session._badgedAt > 600000) {-                session._badgedAt = now;-                badgePupTaskbar(sessionId).catch(() => {});+                badgePupTaskbar(sessionId).then(ok => { if (ok) session._badgedAt = Date.now(); }).catch(() => {});               }             }             const info = await describeTab(tab, session.activeTabId);@@ -3934,8 +3941,8 @@ const server = http.createServer(async (req, res) => {             healOffscreenWindow(session, sessionId).catch(() => {});             const now = Date.now();             if (!session._badgedAt || now - session._badgedAt > 600000) {-              session._badgedAt = now;-              badgePupTaskbar(sessionId).catch(() => {});+              // v1.8.58: only debounce on SUCCESS — a failed badge retries on the next call.+              badgePupTaskbar(sessionId).then(ok => { if (ok) session._badgedAt = Date.now(); }).catch(() => {});             }           }           const info = await describeTab(tab, session.activeTabId);