← Commit history

Smart overlay contrast: a dark-dominant favicon on transparency (the GitHub class) now gets a light card behind it instead of vanishing on the dark one; every other favicon keeps the dark card it was designed against.

John Lauer ·9497955ddb ·2mo ago ·parent 2cb4339
4 files changed +15−7
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.190",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.190/adom-bridge-puppeteer-v2.0.190.zip",-  "sha256": "7c3cb2f43d6b9f4bb6eb8b824fafb8c8213cec135235a126b51d288962ac631d",-  "size": 923549,+  "version": "2.0.191",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.191/adom-bridge-puppeteer-v2.0.191.zip",+  "sha256": "11dfed51beec0671e53bb457e70f9558c763b6c82481c897b8ae3e1040eaeabf",+  "size": 923806,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.190+2.0.191
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.190",+  "version": "2.0.191",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+9−1
@@ -6116,7 +6116,15 @@ async function applyAppOverlay(session, sessionId) {           // Just a full-bleed dark card the tone of the Windows taskbar behind the favicon. The favicon           // is inset only 2px so it stays as LARGE as possible (44/48) while leaving a thin dark margin           // the eye can see, so the badge still reads as a distinct unit on the tile.-          const _bg = `<svg xmlns="http://www.w3.org/2000/svg" width="${BSZ}" height="${BSZ}"><rect x="0" y="0" width="${BSZ}" height="${BSZ}" rx="6" ry="6" fill="#202124"/></svg>`;+          // v2.0.191 (John: "be smart about dark favicons — the GitHub badge comes out invisible").+          // analyzeIconBytes already measured the chosen favicon: a DARK-dominant glyph on+          // TRANSPARENCY vanishes on the dark card, so give exactly that class a LIGHT card+          // (Chrome's own generic-plate grey). Opaque favicons bring their own background and+          // light/colorful glyphs read fine on dark, so everything else keeps the dark card.+          const _lightCard = !!(src.darkDominant && src.transparent);+          const _cardFill = _lightCard ? '#f1f3f4' : '#202124';+          if (_lightCard) console.log(`[overlay] "${sessionId}" dark transparent favicon (${(src.href || '').slice(0, 60)}) — using LIGHT card for contrast`);+          const _bg = `<svg xmlns="http://www.w3.org/2000/svg" width="${BSZ}" height="${BSZ}"><rect x="0" y="0" width="${BSZ}" height="${BSZ}" rx="6" ry="6" fill="${_cardFill}"/></svg>`;           layers.push({ input: await sharpMod(Buffer.from(_bg)).png().toBuffer(), gravity: 'northwest' });           const FIN = 2;   // 2px dark margin around the favicon           // Use the ALREADY-DECODED bytes — re-decoding src.b64 here is what broke .ico (sharp throws