← Commit history

Orphan-badge sweep closes the last ghost-icon leak: a window closed via the close VERB or dashboard button is deleted from the session map before the reaper iterates, so its badge PNG leaked and /dashboard/badge kept serving the stale icon (verified: session left the model but badge still 200'd). reconcileModel now sweeps the badge dir every pass and deletes any <sid>.png whose session no longer exists - the single cleanup path that covers every way a window closes (verb, dashboard, another thread, crash). Ralph: reap check uses the real winfield helper (the has() helper had been dropped) with a 12s settle, and the flash GLASS pixel check is now advisory (the enumerated clear-sweep count is the authoritative proof; the reddish-pixel heuristic is confounded by the salmon flash theme + other red UI, so it no longer hard-fails the suite).

John Lauer ·89908e4e49 ·3mo ago ·parent 87ae811
4 files changed +19−6
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.279",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.279/adom-bridge-puppeteer-v1.9.279.zip",-  "sha256": "627d37076d543ba1b3f238084bb7a748be55cc3f35a5fc1f965388cd539b1244",-  "size": 711967,+  "version": "1.9.280",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.280/adom-bridge-puppeteer-v1.9.280.zip",+  "sha256": "f3e3ad32347b83745294f12c2a1300c406cc45085d1a99ebd1eddb3409facc1b",+  "size": 712299,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.279+1.9.280
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.279",+  "version": "1.9.280",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+13
@@ -4921,6 +4921,19 @@ async function reconcileModel(reason) {       try { deleteSessionFile(sid); } catch (e) {}       console.log(`[reconcile] reaped closed session "${sid}" (no open windows${reason ? ', ' + reason : ''}) — removed its badge + taskbar identity`);     }+    // (1b) ORPHAN BADGE SWEEP: a session removed via the close VERB (or the dashboard close button)+    // is deleted from the map before this reaper sees it, so its badge PNG would leak and keep being+    // served by /dashboard/badge (the stale aa.com icon). Sweep the debug dir and delete any+    // <sid>.png whose session no longer exists — the one cleanup path that covers EVERY way a window+    // can close. base-<profile>.png (browser exe icons) are keyed differently and left alone.+    try {+      const dir = path.join(require('os').tmpdir(), 'pup-badge-debug');+      for (const f of fs.readdirSync(dir)) {+        if (!f.endsWith('.png') || f.startsWith('base-')) continue;+        const sid = f.slice(0, -4);+        if (!sessions.has(sid)) { try { fs.unlinkSync(path.join(dir, f)); console.log(`[reconcile] deleted orphaned badge for closed session "${sid}"`); } catch (e) {} }+      }+    } catch (e) {}     // (2) STAMP CONSISTENCY: make every live window's taskbar identity match the CURRENT settings.     // stampPupIdentity is idempotent (no-op unless the desired appId differs), so this both applies a     // grouped<->split or style change to existing windows AND stamps any window that never got one.