Pup - the AI's own browser - Commit

by adom

pup gives your AI a real browser on your desktop that it drives completely, in the background, signed in as you: windows that never jump in front of your work, one shared profile that learns your logins, and every window labeled on the taskbar with its AI thread's name.

Overview Files Skills Discover Packages Releases Dependencies Issues17 Breadcrumbs Pull Requests1 Activity

← Commit history

Duplicate-hwnd root cause fully fixed: with clean titles (titleTag off), the injector had installed a MutationObserver that STRIPPED the tag on every title change, so pup's TRANSIENT resolution tag was removed before AD could find the window, collapsing two same-profile windows onto one hwnd via ambiguous geometry (John saw wildlife-compare and haircut-review, both adom-you, share a handle). Fixes: (1) when titleTag is off the injector no longer runs the stripping observer (it strips once, passively), so a transient tag survives the find; (2) the tag observer is now stored globally and the reconciler DISCONNECTS it on existing pages too, so already-open windows stop fighting without needing a navigation; (3) a _resolvingHwnd guard keeps the reconciler's title-strip from removing a transient tag mid-find. Combined with 1.9.287's per-profile hwnd validation, every window resolves to its own unique handle whether the title tag is on or off.

John Lauer ·8848cb69c1 ·3mo ago ·parent 18cede3

4 files changed +20−8

adom-bridge-puppeteer-manifest.json+4−4 src/BRIDGE_VERSION+1−1 src/bridge.json+1−1 src/server.js+14−2

adom-bridge-puppeteer-manifest.json+4−4

@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.287",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.287/adom-bridge-puppeteer-v1.9.287.zip",-  "sha256": "68099c2e61d0be95ddfb76e21ad85251a657b42a18938d17ff44c6c34edf0397",-  "size": 717595,+  "version": "1.9.288",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.288/adom-bridge-puppeteer-v1.9.288.zip",+  "sha256": "b523431ac2c07eaef71f7647de14bd609e1bb468896d60a9c14d39ebba306e19",+  "size": 717936,   "verbPrefixes": [     "browser_",     "desktop_recorder_",

src/BRIDGE_VERSION+1−1

@@ -1 +1 @@-1.9.287+1.9.288

src/bridge.json+1−1

@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.287",+  "version": "1.9.288",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",

src/server.js+14−2

@@ -556,6 +556,10 @@ function attachTab(session, sessionId, page, { makeActive = true, opener = 'user         } catch (e) {}       };       const observe = () => {+        // v1.9.288: when the tag is OFF we strip once (above) but must NOT run a stripping observer -+        // it would instantly remove the TRANSIENT tag pup adds to resolve the window's hwnd, forcing+        // ambiguous geometry (two same-profile windows share a rect => same hwnd, John's dup-hwnd bug).+        if (!tagOn) return true;         const t = document.querySelector('title') || document.head || document.documentElement;         if (!t) return false;         // v1.9.185 minimal-touch: in MINIMAL mode we stamp the title ONCE and do NOT install a@@ -565,7 +569,7 @@ function attachTab(session, sessionId, page, { makeActive = true, opener = 'user         // window still carries the tag from the initial stamp; only the continuous re-enforcement         // is dropped. (window.name, set below, is the durable identity anyway.)         if (window.__pupMinimalTouch) return true;-        try { new MutationObserver(ensure).observe(t, { childList: true, subtree: true, characterData: true }); } catch (e) {}+        try { window.__pupTagObs = new MutationObserver(ensure); window.__pupTagObs.observe(t, { childList: true, subtree: true, characterData: true }); } catch (e) {}         return true;       };       ensure();@@ -4813,6 +4817,7 @@ async function resolveSessionHwndByBounds(session, sessionId) {       // durable identity. When titleTag is ON, the tag is already persistent — no transient dance.       const _transient = pupSettings().titleTag !== 'on';       const _atab = (session.tabs || []).find(t => t.tabId === session.activeTabId) || (session.tabs || [])[0];+      if (_transient) session._resolvingHwnd = true;   // v1.9.288: keep the reconciler from stripping the transient tag mid-find       if (_transient && _atab && _atab.page) {         try { await _atab.page.evaluate((sfx) => { try { if (String(document.title).indexOf(sfx) === -1) document.title = String(document.title || '') + sfx + ')'; } catch (e) {} }, ` (${TITLE_LABEL}: ${sessionId}`); } catch (e) {}       }@@ -4821,6 +4826,7 @@ async function resolveSessionHwndByBounds(session, sessionId) {       if (_transient && _atab && _atab.page) {         try { const esc = sessionId.replace(/[.*+?^${}()|[\]\\]/g, '\\$&'); await _atab.page.evaluate((re) => { try { document.title = String(document.title || '').replace(new RegExp(re, 'g'), ''); } catch (e) {} }, `\\s*\\((?:session|ai-thread): ${esc}(?:[^)]*)\\)`); } catch (e) {}       }+      session._resolvingHwnd = false;       if (b && b.hwnd) { session._hwnd = Number(b.hwnd); console.log(`[hwnd] "${sessionId}" resolved by ${_transient ? 'TRANSIENT tag' : 'TITLE tag'} -> ${b.hwnd}`); return Number(b.hwnd); }     } catch (e) {}     const page = (session.tabs || [])[0] && (session.tabs || [])[0].page;@@ -5063,13 +5069,19 @@ async function reconcileModel(reason) {       // real " · " title), disconnecting the decor observer so it cannot re-add it.       if (!_tagOn || !_prefixOn) {         for (const [sid, s2] of [...sessions]) {+          if (s2._resolvingHwnd) continue;   // v1.9.288: don't strip a transient resolve tag           for (const t of (s2.tabs || [])) {             if (!t || !t.page) continue;             try {               const esc = sid.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');               await t.page.evaluate((tagOn, prefixOn, escSid) => {                 try {-                  if (!tagOn) { const re = new RegExp('\\s*\\((?:session|ai-thread): ' + escSid + '(?:[^)]*)\\)', 'g'); const c = String(document.title || '').replace(re, ''); if (c !== document.title) document.title = c; }+                  if (!tagOn) {+                    // disconnect the stripping observer on existing pages so it stops fighting the+                    // transient resolution tag (the dup-hwnd cause); strip any baked tag once.+                    try { if (window.__pupTagObs) { window.__pupTagObs.disconnect(); window.__pupTagObs = null; } } catch (e) {}+                    const re = new RegExp('\\s*\\((?:session|ai-thread): ' + escSid + '(?:[^)]*)\\)', 'g'); const c = String(document.title || '').replace(re, ''); if (c !== document.title) document.title = c;+                  }                   if (!prefixOn) {                     try { if (window.__pupDecorObs) { window.__pupDecorObs.disconnect(); window.__pupDecorObs = null; } } catch (e) {}                     const tag = window.__pupThreadTag;