Pup - the AI's own browser

@@ -1694,6 +1694,17 @@ let _jumplistSupported = null;   // null = unprobed (desktop_set_window_jumplist // Windows' shell + AD's HICON cache key by path (stale-tile risk otherwise). Future home for // the master art: the Adom brand-icons wiki repo; for now the pup repo owns it. function pupIconPath() { return path.join(__dirname, 'icons', 'adom-pup-browser3.ico'); }+// v1.9.11: the RelaunchCommand half of the Relaunch* trio (see stampPupIdentity) — Windows will+// not honor RelaunchIconResource for the jump-list header row unless RelaunchCommand is set too.+// It is also literally what a header click / taskbar PIN launches, so it must genuinely refocus+// THIS session. browser_focus_window is gated (foreground_reason_required), so we supply an+// honest reason: a header/pin click IS the user asking to see the window. Inner quotes are+// BACKSLASH-escaped because this is a Windows command line (same argv trap as jump-list args).+function pupRelaunchCommand(sessionId) {+  const cli = path.join(process.env.LOCALAPPDATA || path.join(os.homedir(), 'AppData', 'Local'), 'Adom Desktop', 'adom-desktop-cli.exe');+  const payload = JSON.stringify({ sessionId, foregroundReason: 'user clicked the Adom Pup taskbar header or pinned launcher' }).replace(/"/g, '\\"');+  return `"${cli}" browser_focus_window "${payload}"`;+} function _isUnknownVerb(r, raw) { return /unknown (desktop )?command|unknown verb/i.test(((r && r.error) || '') + ' ' + (raw || '')); } async function ensurePupIdentityRegistered() {   if (process.platform !== 'win32' || _identitySupported === false) return false;@@ -1728,6 +1739,16 @@ async function stampPupIdentity(sessionId) {     const r = await chrome.adCommand('desktop_set_window_identity', {       titleContains: `(session: ${sessionId}`, cacheKey: `pup-${sessionId}`,       appId: pupSettings().taskbarGrouping === 'grouped' ? PUP_APP_ID : `${PUP_APP_ID}.${sessionId}`, displayName: PUP_DISPLAY_NAME, iconPath: pupIconPath(),+      // v1.9.11 (AD ≥1.9.141): brand the taskbar RIGHT-CLICK MENU HEADER row (it showed the+      // chrome.exe icon for months). There is NO "ApplicationIcon" registry value on AUMID keys+      // and the registry cannot brand the header at all — the header obeys the window's+      // Relaunch* property TRIO, and Windows IGNORES RelaunchIconResource unless RelaunchCommand+      // is ALSO set. So we must pass a real relaunch command. It doubles as what a header click+      // or a taskbar PIN launches, so it has to genuinely refocus THIS session: browser_focus_window+      // carries a foregroundReason (the raise gate refuses without one, and a header click IS a+      // real user request to see the window). Quotes are backslash-escaped for Windows argv —+      // same trap that made jump-list clicks no-op in 1.9.9.+      relaunchCommand: pupRelaunchCommand(sessionId),     }, { timeoutMs: 6000 });     const raw = r && (typeof r.output === 'string' ? r.output : JSON.stringify(r.output || ''));     if ((r && r.success === false) || _isUnknownVerb(r, raw)) {@@ -2068,47 +2089,24 @@ function appIconReprimand(url, hadFavicon) { // relaunches the browser under the other cookie jar and takes several seconds, so WITHOUT this a // click felt like nothing happened at all. Same `id` on every call so the start caption is // REPLACED by the result caption instead of stacking. Best-effort; never throws.-async function wikiCaption(text, duration) {+async function wikiCaption(text, expiresInMs) {   try {-    // v1.9.10: LOG the result — this call failed silently for a whole session because AD's-    // loopback direct API does NOT expose desktop_caption (relay-only verb; confirmed live:-    // "'desktop_caption' is not a built-in desktop verb"). Filed with AD; the moment it ships-    // on the direct API this starts working with no pup change. Until then the in-PAGE toast-    // (wikiToast) is the user-visible feedback.+    // v1.9.11: AD ≥1.9.144 exposes desktop_caption on the LOOPBACK direct API (the path bridges+    // use). Before that it was relay-only — ~90 inline verbs matched only their BARE names, and+    // the CLI strips the `desktop_` prefix client-side, which is exactly why a CLI test "worked"+    // while pup's identical call silently no-op'd. Both spellings are accepted now.+    // NOTE the arg is `expiresInMs` (NOT `duration`) — default 30000, max 600000.+    // This replaced the in-page DOM toast: with a real OS surface available, pup should not be+    // injecting elements into the user's page.     const r = await chrome.adCommand('desktop_caption', {-      text, duration, id: 'pup-wiki-view', position: 'bottom', size: 'medium',+      text, expiresInMs, id: 'pup-wiki-view', position: 'bottom', size: 'medium',     }, { timeoutMs: 4000 });     const raw = r && (typeof r.output === 'string' ? r.output : JSON.stringify(r.output || r || ''));     if (!r || (r.success === false) || /not a built-in desktop verb|unknown/i.test(raw || '')) {-      console.log('[wiki] desktop_caption unavailable on this AD direct API (expected pre-fix) — in-page toast is the visible feedback');-    } else {-      console.log('[wiki] desktop_caption shown');+      console.log(`[wiki] desktop_caption FAILED (AD <1.9.144?) — ${(raw || 'no response').slice(0, 120)}`);     }   } catch (e) {} }-// v1.9.10: in-PAGE toast — pup-owned visual feedback that needs NO AD verb. A fixed-position-// pill injected into the page (top-center, Adom dark teal, auto-fade). Used by the wiki view-// toggle to confirm the switch IN the very window the user is now looking at. Idempotent per-// call (replaces any prior toast). Best-effort; never throws.-async function wikiToast(page, text, ms = 6000) {-  try {-    await page.evaluate((t, dur) => {-      try {-        const old = document.getElementById('__pup_wiki_toast'); if (old) old.remove();-        const d = document.createElement('div');-        d.id = '__pup_wiki_toast';-        d.textContent = t;-        d.style.cssText = 'position:fixed;top:18px;left:50%;transform:translateX(-50%);z-index:2147483647;' +-          'background:#0b2325;color:#e8fbfa;border:1px solid #14b8a6;border-radius:999px;' +-          'padding:10px 22px;font:600 15px/1.4 system-ui,sans-serif;box-shadow:0 6px 24px rgba(0,0,0,.45);' +-          'opacity:0;transition:opacity .25s ease;pointer-events:none;max-width:80vw;text-align:center';-        (document.body || document.documentElement).appendChild(d);-        requestAnimationFrame(() => { d.style.opacity = '1'; });-        setTimeout(() => { try { d.style.opacity = '0'; setTimeout(() => { try { d.remove(); } catch (e) {} }, 400); } catch (e) {} }, dur);-      } catch (e) {}-    }, text, ms);-  } catch (e) {}-} // v1.9.7: reusable OS FOREGROUND raise, extracted verbatim from the proven browser_raise_os_window // path, so the wiki view-toggle callback can actually POP the relaunched window to the user's // screen. A jump-list click is a genuine USER action, so a real SetForegroundWindow raise is@@ -4803,10 +4801,9 @@ const server = http.createServer(async (req, res) => {           const _switchMsg = view === 'authed'             ? '\u{1F513} Switching to the LOGGED-IN view of the Adom wiki…'             : '\u{1F4D6} Switching to the PUBLIC (logged-out) view of the Adom wiki…';+          // v1.9.11: OS caption (AD >=1.9.144). Fire-and-forget: the old window is torn down+          // moments later, so an OS-level surface is the ONLY thing that survives the switch.           wikiCaption(_switchMsg, 30000).catch(() => {});-          // v1.9.10: ALSO toast in the page itself (desktop_caption is relay-only pre-AD-fix) so-          // a user watching the window sees the click registered before the teardown.-          try { await wikiToast(session.page, _switchMsg, 8000); } catch (e) {}           // Close the current window (mirror browser_close_window) so we can relaunch under the           // other cookie jar.           const oldProfile = session.profileName;@@ -4870,12 +4867,10 @@ const server = http.createServer(async (req, res) => {               const _doneMsg = a && a.authed                 ? `\u{1F513} Adom wiki: now the LOGGED-IN view${a.user ? ` (${a.user})` : ''}`                 : '\u{1F513} Adom wiki: logged-in view needs the one-time sign-in — sign in in this window';-              wikiCaption(_doneMsg, 4000).catch(() => {});-              try { await wikiToast(s2.page, _doneMsg, 7000); } catch (e) {}+              wikiCaption(_doneMsg, 6000).catch(() => {});             } else {               const _doneMsg = '\u{1F4D6} Adom wiki: now the PUBLIC (logged-out) view — what the world sees';-              wikiCaption(_doneMsg, 4000).catch(() => {});-              try { await wikiToast(s2.page, _doneMsg, 7000); } catch (e) {}+              wikiCaption(_doneMsg, 6000).catch(() => {});             }           })().catch(() => {});           return;