← Commit history

Stops pup from creating an Adom Pup entry in the users Start Menu, which Adom users dislike. The main app-identity registration ran on every bridge start and registered the anchor AUMID WITH a Start Menu shortcut (the pinnable launcher). It now registers registry-only with shortcut false and brands the AUMID by writing IconResource straight into HKCU, the same shortcut-free technique the per-window AUMIDs already used, so grouped taskbar mode keeps its grouping anchor but no Start Menu shortcut is ever created. Existing machines self-heal: the stale Adom Pup.lnk is deleted on the next bridge start. The pinnable launcher is dropped deliberately since users did not want it

John Lauer ·8621a2263c ·2mo ago ·parent 3dc3915
4 files changed +26−8
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.117",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.117/adom-bridge-puppeteer-v2.0.117.zip",-  "sha256": "4a378f591ef1fa7102e2d03168d50cdb5c63da3ca3894093d099bc1dc7d12c0d",-  "size": 863802,+  "version": "2.0.118",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.118/adom-bridge-puppeteer-v2.0.118.zip",+  "sha256": "9f70c8b28dc548150b00747a4b1997859ccd8d04c8a92ad49949207f4cb2f3eb",+  "size": 864221,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.117+2.0.118
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.117",+  "version": "2.0.118",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+20−2
@@ -3590,13 +3590,31 @@ function pupTask(verb, obj, meta) {   }; } function _isUnknownVerb(r, raw) { return /unknown (desktop )?command|unknown verb/i.test(((r && r.error) || '') + ' ' + (raw || '')); }+// v2.0.118: delete any "Adom Pup" Start Menu shortcut a prior pup version left (per-user and,+// best-effort, all-users). Pup's own shortcut, safe to remove; HKCU/per-user needs no admin.+function removePupStartMenuShortcut() {+  if (process.platform !== 'win32') return;+  const dirs = [];+  if (process.env.APPDATA) dirs.push(process.env.APPDATA);+  if (process.env.ProgramData) dirs.push(process.env.ProgramData);+  for (const base of dirs) {+    const lnk = path.join(base, 'Microsoft', 'Windows', 'Start Menu', 'Programs', 'Adom Pup.lnk');+    try { if (fs.existsSync(lnk)) { fs.unlinkSync(lnk); console.log(`[identity] removed stale "Adom Pup" Start Menu shortcut: ${lnk}`); } } catch (e) { /* all-users needs admin; ignore */ }+  }+} async function ensurePupIdentityRegistered() {   if (process.platform !== 'win32' || _identitySupported === false) return false;   if (_identityRegistered) return true;   try {+    // v2.0.118 (John: Adom users don't want an "Adom Pup" entry in their Start Menu). Register the+    // anchor AUMID registry-ONLY (shortcut:false) and brand it by writing IconResource straight into+    // HKCU — the SAME shortcut-free technique the per-window AUMIDs already use — so grouped taskbar+    // mode still has its grouping anchor but NO Start Menu shortcut is ever created. The old+    // pinnable-launcher shortcut is dropped deliberately: nobody asked for it and users dislike it.+    removePupStartMenuShortcut();   // self-heal any shortcut a prior pup version created on this machine+    writeAumidIcon(PUP_APP_ID, pupIconPath());     const r = await chrome.abCommand('desktop_register_app_identity', {-      appId: PUP_APP_ID, displayName: PUP_DISPLAY_NAME, iconPath: pupIconPath(),-      args: 'pup_open_window {"sessionId":"pinned","owner":"pinned-launch","url":"https://wiki.adom.inc"}',+      appId: PUP_APP_ID, displayName: PUP_DISPLAY_NAME, iconPath: pupIconPath(), shortcut: false,     }, { timeoutMs: 8000 });     const raw = r && (typeof r.output === 'string' ? r.output : JSON.stringify(r.output || ''));     if ((r && r.success === false) || _isUnknownVerb(r, raw)) {