← Commit history

Serialize tab creation per profile — the real fix for the concurrent split (on-desk, John watching). Measured on 1.9.156: newPage() lands a tab in the session's OWN window every time single-threaded (2 tabs, 1 window, no split); the split ONLY occurs under concurrency, where interleaved newPage() calls on the shared durable profile race on Chrome's ambiguous active-window and a tab is born in the wrong window, which the drag-out handler then splits off. addTabToSession now funnels its newPage through the SAME _profileOpenChain that serializes browser_open_window (1.9.143), so tab creations on one profile run in arrival order and each tab is created against its session's settled window context. No window.open, no activateTarget, no OS foregrounding — just removing the interleave that caused it. Reverted 1.9.155's churny approach stays reverted.

John Lauer ·7e35b15e1b ·3mo ago ·parent 2f2a08d
4 files changed +17−13
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.156",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.156/adom-bridge-puppeteer-v1.9.156.zip",-  "sha256": "b4fc8106ea4067dc1e3bcd61c3c3323486775b5b98f103e1083c6048278925d6",-  "size": 401355,+  "version": "1.9.157",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.157/adom-bridge-puppeteer-v1.9.157.zip",+  "sha256": "56cbced7ebae579a2bcef6f654ceb8d650cbd3c88046b4b4caefb877528a5465",+  "size": 401445,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.156+1.9.157
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.156",+  "version": "1.9.157",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+11−7
@@ -5651,15 +5651,19 @@ async function addTabToSession(sessionId, url) {   if (!be || !be.browser.isConnected()) {     throw new Error(`Session "${sessionId}" browser is not connected.`);   }-  // v1.9.156: REVERTED 1.9.155 — window.open-from-opener did NOT reliably stay in-window and-  // created reclaim churn (a sibling window adopted then killed, breaking win-a's identity, a-  // stuck progress bar). Back to the plain newPage path; the split-under-concurrency is a RECLAIM-  // problem to fix in the sweep (don't split a window whose page is _pupCreated + attached), not-  // at tab-creation time. That fix needs on-desk verification, not a driving-time ship.-  const page = await Promise.race([+  // v1.9.157 (on-desk, John watching) — SERIALIZE tab creation per profile. Measured: newPage()+  // lands the tab in the session's OWN window every time SINGLE-THREADED (2 tabs, 1 window). The+  // split ONLY happens under concurrency: interleaved newPage() calls on the shared profile race+  // on Chrome's ambiguous 'active window', so a tab is born in the wrong window and the drag-out+  // handler splits it. Funnelling newPage through the same _profileOpenChain that serializes opens+  // removes the interleave — each tab is created when its session's window is the settled context.+  const _tabPrev = _profileOpenChain.get(session.profileName) || Promise.resolve();+  const _tabCur = _tabPrev.then(() => Promise.race([     be.browser.newPage(),     new Promise((_, rej) => setTimeout(() => rej(new Error('newPage timed out — the browser did not create the tab in 20s. Retry browser_open_tab; if it persists, browser_close_window + browser_open_window.')), 20000)),-  ]);+  ]));+  _profileOpenChain.set(session.profileName, _tabCur.catch(() => {}));+  const page = await _tabCur;   try { page._pupCreated = true; } catch (e) {}   const tabId = attachTab(session, sessionId, page, { makeActive: true });