← Commit history

The 300-error mystery (John: 'why 300 errors in pup-dashboard?'): ONE tab with an unresolvable favicon (another thread's wildlife-notebook tab-4) 404'd on /dashboard/favicon, and because the tree re-renders on every 2s SSE tick with fresh img elements (and Chrome does not cache 404s), every tick re-requested it and logged a console error in the dashboard's own window - a single bad favicon filled the entire 300-entry error buffer. Fix, same doctrine as taskbar badges (never bare, never 404): the favicon endpoint now serves a neutral generic page glyph with HTTP 200 (monochrome per the icon rules) and negative-caches the result so the expensive multi-candidate favicon resolution also stops re-running every tick. The err tooltip retains real page errors instead of drowning in resource-load noise.

John Lauer ·7c29b8729a ·2mo ago ·parent 78dd70d
4 files changed +17−8
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.275",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.275/adom-bridge-puppeteer-v1.9.275.zip",-  "sha256": "cc357aa3defa603d7441f5fdf7f16da3a88b373f0d30d1d3e5b06827df94ebeb",-  "size": 616164,+  "version": "1.9.276",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.276/adom-bridge-puppeteer-v1.9.276.zip",+  "sha256": "47819c46054ffeaf3979164b4a0a84a8e3ff791a057fd2716d1673ac3f56dacf",+  "size": 616568,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.275+1.9.276
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.275",+  "version": "1.9.276",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+11−2
@@ -4053,6 +4053,8 @@ function icoLargestPng(buf) { // icon can be detected and skipped for a lighter sibling. Returns the full acquisition STATE so the // dashboard can show, per tab, exactly how the icon was obtained. const _tabFavMeta = new Map();   // page-url -> { meta, at }+// the generic tab glyph: a neutral page outline, monochrome per the icon rules+const GENERIC_TAB_SVG = '<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16"><rect x="3" y="1.5" width="10" height="13" rx="1.5" fill="none" stroke="#8b949e" stroke-width="1.3"/><path d="M5.5 5h5M5.5 7.5h5M5.5 10h3.5" stroke="#8b949e" stroke-width="1.1" stroke-linecap="round"/></svg>'; const _dashToasts = []; let _dashToastId = 0;   // /ui/toast narration queue, delivered over the SSE async function enumerateFaviconCandidates(page) {   try {@@ -8911,8 +8913,15 @@ const server = http.createServer(async (req, res) => {           new Promise(r => setTimeout(() => r(null), 3500)),         ]).catch(() => null);         if (!rich || !rich.b64) {-          if (key) _tabFavMeta.set(key, { meta: { kind: 'none', note: 'no favicon resolved' }, at: Date.now() });-          res.writeHead(404); res.end(); return;+          // v1.9.276 (John: "why 300 errors in pup-dashboard?"): a 404 here re-fired on EVERY 2s+          // SSE re-render (fresh img elements each render, Chrome does not cache 404s) and each one+          // logged a console error in the dashboard window - one unresolvable tab favicon filled the+          // whole 300-entry error buffer. Same doctrine as taskbar badges: never bare, never 404 -+          // serve the generic page glyph with a 200, and negative-cache so the expensive resolution+          // is not re-run every tick either.+          if (key) { _tabFavCache.set(key, { buf: Buffer.from(GENERIC_TAB_SVG), mime: 'image/svg+xml' }); _tabFavMeta.set(key, { meta: { kind: 'none', note: 'no favicon resolved; generic glyph shown' }, at: Date.now() }); }+          res.writeHead(200, { 'Content-Type': 'image/svg+xml', 'Cache-Control': 'max-age=60' });+          res.end(GENERIC_TAB_SVG); return;         }         const buf = Buffer.from(rich.b64, 'base64');         if (key) {