← Commit history

REVERT 1.9.155 (window.open tab creation) — it churned windows, the reclaim killed a sibling (the vanished window), broke win-a identity and stranded its progress bar. Back to plain newPage; the real fix belongs in the reclaim sweep (dont split a _pupCreated attached page), to verify on-desk not while John drives. FORCE_PUSH: verified diff is only my own 1.9.155 code.

John Lauer ·78d6d2792a ·3mo ago ·parent e00fe0b
4 files changed +15−34
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.155",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.155/adom-bridge-puppeteer-v1.9.155.zip",-  "sha256": "ae3e283e26ff26ca4e9b4937c604d266bc1476bcdd5d05456b211f90fd3e4db6",-  "size": 401690,+  "version": "1.9.156",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.156/adom-bridge-puppeteer-v1.9.156.zip",+  "sha256": "b4fc8106ea4067dc1e3bcd61c3c3323486775b5b98f103e1083c6048278925d6",+  "size": 401355,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.155+1.9.156
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.155",+  "version": "1.9.156",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+9−28
@@ -5651,35 +5651,16 @@ async function addTabToSession(sessionId, url) {   if (!be || !be.browser.isConnected()) {     throw new Error(`Session "${sessionId}" browser is not connected.`);   }-  // v1.9.155 (John's window-open test found the split): a tab MUST be born in the session's-  // OWN OS window. browser.newPage()/Target.createTarget lets Chrome pick the window, and under-  // the shared durable profile with concurrent opens it picks WRONG — the 'tab' lands in a fresh-  // window, the session then spans two OS windows, and the drag-out reclaim splits it into-  // ai-<thread>-split1. The deterministic fix: open the tab FROM the session's current page, so-  // it is a same-window sibling (window.open in the opener's window), and grab that new target.-  const opener = ((session.tabs || []).find(t => t.tabId === session.activeTabId) || (session.tabs || [])[0] || {}).page || session.page;-  let page = null;-  if (opener && !opener.isClosed?.()) {-    try {-      const before = new Set(await be.browser.pages());-      await opener.evaluate((u) => { const w = window.open(u || 'about:blank', '_blank'); return !!w; }, url);-      for (let i = 0; i < 60 && !page; i++) {-        const fresh = (await be.browser.pages()).find(pg => !before.has(pg));-        if (fresh) { page = fresh; break; }-        await new Promise(r => setTimeout(r, 100));-      }-    } catch (e) { console.log(`[tab] same-window open failed for "${sessionId}" (${e.message}) — falling back to newPage`); }-  }-  // Fallback: the classic path (a page appears, even if in a new window — better than no tab).-  if (!page) {-    page = await Promise.race([-      be.browser.newPage(),-      new Promise((_, rej) => setTimeout(() => rej(new Error('newPage timed out — the browser did not create the tab in 20s. Retry browser_open_tab; if it persists, browser_close_window + browser_open_window.')), 20000)),-    ]);-  }+  // v1.9.156: REVERTED 1.9.155 — window.open-from-opener did NOT reliably stay in-window and+  // created reclaim churn (a sibling window adopted then killed, breaking win-a's identity, a+  // stuck progress bar). Back to the plain newPage path; the split-under-concurrency is a RECLAIM+  // problem to fix in the sweep (don't split a window whose page is _pupCreated + attached), not+  // at tab-creation time. That fix needs on-desk verification, not a driving-time ship.+  const page = await Promise.race([+    be.browser.newPage(),+    new Promise((_, rej) => setTimeout(() => rej(new Error('newPage timed out — the browser did not create the tab in 20s. Retry browser_open_tab; if it persists, browser_close_window + browser_open_window.')), 20000)),+  ]);   try { page._pupCreated = true; } catch (e) {}-  // If window.open didn't navigate (about:blank), send it now.-  try { if (url && page.url() === 'about:blank') await page.goto(url, { waitUntil: 'domcontentloaded', timeout: 25000 }).catch(() => {}); } catch (e) {}   const tabId = attachTab(session, sessionId, page, { makeActive: true });    // v1.8.19: the " (session: <sid>)" title marker is now owned SOLELY by the