app
Pup - the AI's own browser
Public Made by Adomby adom
pup gives your AI a real browser on your desktop that it drives completely, in the background, signed in as you: windows that never jump in front of your work, one shared profile that learns your logins, and every window labeled on the taskbar with its AI thread's name.
← Commit history
Crash fix, part 1 — stop a single spammy page from hanging the shared Chrome and taking down every session. Root cause found in the code: (1) attachTab mirrored EVERY page console message via a synchronous console.log to the bridge's stdout — a heavy SPA (Autodesk's Kepler account portal, which repeatedly logs 'Auth is not yet ready to mount providers') floods the Node event loop with blocking writes and stalls CDP handling for ALL sessions (the measured HUNG-alive/CDP-DEAD signature); now rate-limited to ~8 console lines/sec per tab with a suppressed-count summary. (2) setupErrorCollection wired a requestfailed listener that enables the CDP Network domain, whose per-request event stream is a firehose on request-heavy SPAs and saturated pup's single shared CDP WebSocket; removed (network failures are rarely the actionable error; console.error + pageerror stay). (3) the per-tab errors array was uncapped and grew unbounded on a spammy page; now capped at 300. All three are per-page event floods over the one shared connection — exactly why one bad page jammed everything, which matters most now that ALL windows share one profile/process (1.9.162).
4 files changed
+28−22
adom-bridge-puppeteer-manifest.json+4−4@@ -1,10 +1,10 @@ { "manifest_version": 1, "name": "puppeteer",- "version": "1.9.162",- "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.162/adom-bridge-puppeteer-v1.9.162.zip",- "sha256": "934cb0c38e427002b7f3c94b9ec7a2ed9f45b01e4a10bd37d9d31588bcd34de9",- "size": 402341,+ "version": "1.9.163",+ "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.163/adom-bridge-puppeteer-v1.9.163.zip",+ "sha256": "8c0026b2ae6231539e043a58fac0cbd2cfcaaa240656556841036ccc574de9aa",+ "size": 402788, "verbPrefixes": [ "browser_", "desktop_recorder_",
src/BRIDGE_VERSION+1−1@@ -1 +1 @@-1.9.162+1.9.163
src/bridge.json+1−1@@ -2,7 +2,7 @@ "manifest_version": 1, "name": "puppeteer", "displayName": "Puppeteer (Chrome for Testing + Native)",- "version": "1.9.162",+ "version": "1.9.163", "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.", "homepage": "https://wiki.adom.inc/adom/adom-desktop", "author": "Adom Inc.",
src/server.js+22−16@@ -537,11 +537,21 @@ function attachTab(session, sessionId, page, { makeActive = true, opener = 'user page.evaluate(PUP_FOCUS_HOOK).catch(() => {}); } catch (e) {} // Tag console logs with tabId so the caller can tell which tab emitted them+ // v1.9.163 (crash fix): RATE-LIMIT the console mirror. This synchronously wrote EVERY page+ // console message to the bridge's stdout; a spammy SPA (measured: Autodesk's Kepler portal)+ // floods the Node event loop with blocking writes and stalls CDP for EVERY session (HUNG-alive,+ // CDP-DEAD). Cap to ~8/sec per tab; drop the rest with a one-line "(suppressed N)" summary.+ let _cmWin = 0, _cmCount = 0, _cmDropped = 0; page.on('console', msg => { try {- const kind = msg.type();- const text = msg.text();- console.log(`[pup console ${sessionId}/${tabId} ${kind}] ${text}`);+ const now = Date.now();+ if (now - _cmWin > 1000) {+ if (_cmDropped > 0) console.log(`[pup console ${sessionId}/${tabId}] (suppressed ${_cmDropped} flood messages in the last second)`);+ _cmWin = now; _cmCount = 0; _cmDropped = 0;+ }+ if (_cmCount >= 8) { _cmDropped++; return; }+ _cmCount++;+ console.log(`[pup console ${sessionId}/${tabId} ${msg.type()}] ${msg.text()}`); } catch {} }); // When the user closes a tab via Chrome UI, keep our state in sync@@ -1534,19 +1544,15 @@ process.on('SIGINT', () => { process.exit(0); }); process.on('SIGTERM', () => { process.exit(0); }); function setupErrorCollection(pg, errorsArr) {- pg.on('console', msg => {- if (msg.type() === 'error') {- errorsArr.push({ type: 'console.error', text: msg.text(), ts: Date.now() });- }- });- pg.on('pageerror', err => {- errorsArr.push({ type: 'exception', text: err.message, ts: Date.now() });- });- pg.on('requestfailed', req => {- if (req.failure()) {- errorsArr.push({ type: 'network', text: `${req.failure().errorText}: ${req.url()}`, ts: Date.now() });- }- });+ // v1.9.163 (crash fix): bounded buffer + NO requestfailed listener. The requestfailed listener+ // enabled the CDP Network domain, whose per-request event stream is a firehose on request-heavy+ // SPAs and saturated pup's single shared CDP WebSocket, jamming every session at once. Network+ // failures are rarely the actionable error anyway; console.error + pageerror are. And the buffer+ // is now capped — a spammy page used to grow it unbounded.+ const CAP = 300;+ const push = (e) => { errorsArr.push(e); if (errorsArr.length > CAP) errorsArr.splice(0, errorsArr.length - CAP); };+ pg.on('console', msg => { if (msg.type() === 'error') push({ type: 'console.error', text: msg.text(), ts: Date.now() }); });+ pg.on('pageerror', err => push({ type: 'exception', text: err.message, ts: Date.now() })); } // Kill a Chrome browser process forcefully by PID