← Commit history

Overlay/HWND fix: resolve a window's OS handle by its unique (ai-thread: sid) title tag whenever it returns exactly one match, regardless of the titleTag setting. Fixes shared-profile windows (e.g. a 13-tab bridge-pages) that the geometry wiggle left ambiguous, so their taskbar overlay finally paints.

John Lauer ·73f7c2d088 ·2mo ago ·parent bd1e3af
4 files changed +16−8
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.9",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.9/adom-bridge-puppeteer-v2.0.9.zip",-  "sha256": "9452e1f6912ef3f18b892fbcd671b4e4276aeb55a0eeb2b8f4e12af38cc89b83",-  "size": 639286,+  "version": "2.0.10",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.10/adom-bridge-puppeteer-v2.0.10.zip",+  "sha256": "bca4b71f2959dbfdba38e81821bf426a66087f024155678232a1179e7d5ad573",+  "size": 639593,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.9+2.0.10
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.9",+  "version": "2.0.10",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+10−2
@@ -5490,10 +5490,18 @@ async function resolveSessionHwndByBounds(session, sessionId) {     // we skip straight to the unique-width geometry wiggle below (observer-proof; the transient TITLE     // approach was fought by the page's own title observer, collapsing same-profile windows onto one     // hwnd — John's dup-handle bug).-    if (pupSettings().titleTag === 'on') try {+    // v2.0.10 (John: a bridge-pages window with 4 same-profile windows + 14 ambiguous wiggle-matches+    // got NO overlay). Try the unique title tag REGARDLESS of the titleTag setting, but only trust an+    // UNAMBIGUOUS (count===1) match. The "(ai-thread: <sid>)" suffix is unique to THIS session and+    // impossible on Edge/non-pup, so a single match is safe even when the geometry wiggle can't tell+    // same-profile windows apart. A page title-observer that strips the tag just yields count 0 (or a+    // recycle yields >1), and we fall through to the wiggle — never guessing. This is what the earlier+    // titleTag gate blocked: the resolver could see the tag but was told not to use it.+    try {       const fw = adPayload(await chrome.adCommand('desktop_find_window', { titleContains: `(${TITLE_LABEL}: ${sessionId}` }, { timeoutMs: 5000, caller: sessionCaller(session) }));+      const cnt = fw && (fw.count != null ? fw.count : (fw.data && fw.data.count));       const b = fw && (fw.best || (fw.data && fw.data.best));-      if (b && b.hwnd) { session._hwnd = Number(b.hwnd); persistSessionHwnd(sessionId, Number(b.hwnd)); console.log(`[hwnd] "${sessionId}" resolved by TITLE tag -> ${b.hwnd}`); return Number(b.hwnd); }+      if (cnt === 1 && b && b.hwnd) { session._hwnd = Number(b.hwnd); persistSessionHwnd(sessionId, Number(b.hwnd)); console.log(`[hwnd] "${sessionId}" resolved by unique TITLE tag -> ${b.hwnd}`); return Number(b.hwnd); }     } catch (e) {}     const page = (session.tabs || [])[0] && (session.tabs || [])[0].page;     if (!page) return null;