← Commit history

Make a bridge upgrade REPAIR the jump-list task commands on windows that already exist. This is why John's 'Switch to public view' still failed after 1.9.115 fixed the command format: a jump-list task embeds a full CLI command line, and stampPupIdentity only re-commits the list when the appId CHANGES, so any window whose category was unchanged across the upgrade kept its OLD identity-less command and the click was refused silently — while the very same verb worked perfectly when I called it from the CLI, which is exactly why my verification passed and his click did not. On every bridge start pup now clears the jump-list dedupe key for all recovered sessions before the startup brand sweep, so the re-attach is real instead of a no-op and every surviving window gets task commands matching the running version. One AD call per live window, once per boot.

John Lauer ·730995cde8 ·3mo ago ·parent dc5955f
4 files changed +23−7
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.115",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.115/adom-bridge-puppeteer-v1.9.115.zip",-  "sha256": "3788a12548781338bbdfb733725d3a1b22b69a6953de9c811043ba239cfec61d",-  "size": 383013,+  "version": "1.9.116",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.116/adom-bridge-puppeteer-v1.9.116.zip",+  "sha256": "193d05dce1477d58bcd60713e379b8d2f4e24a22f56ff156162b403b7e24f8ea",+  "size": 383561,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.115+1.9.116
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.115",+  "version": "1.9.116",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+17−1
@@ -9195,7 +9195,23 @@ server.listen(PORT, BIND_HOST, async () => {   // trusted transport, no relay gating. Self-gates on AD <1.9.134 (unknown verb).   setTimeout(() => { ensurePupIdentityRegistered().catch(() => {}); }, 2500);   setTimeout(() => { probeAdVersion().catch(() => {}); }, 1500);-  setTimeout(() => { brandSweep('startup').catch(() => {}); }, 8000);+  // v1.9.116 — ON EVERY BRIDGE START, FORCE A JUMP-LIST RE-COMMIT FOR EVERY RECOVERED SESSION.+  // This is the structural gap that let a fixed bug reach John anyway. A jump-list task embeds a full+  // CLI command line, so when the command FORMAT changes (v1.9.115 had to add --ai-thread or AD refuses+  // the click), every window that already exists keeps its OLD, now-broken command. stampPupIdentity+  // only re-commits when the appId CHANGES, so a window whose category is unchanged across an upgrade+  // never picks up the new format: John clicked "Switch to public view" on a pre-upgrade window and it+  // silently did nothing, while the same verb worked perfectly from the CLI. Clearing the dedupe key+  // before the startup sweep makes the re-attach real rather than a no-op, so a bridge upgrade now+  // repairs task commands on every surviving window. Cheap: one AD call per live window, once per boot.+  setTimeout(() => {+    try {+      let n = 0;+      for (const [, s] of sessions) { if (s) { s._wikiJumplistKey = undefined; n++; } }+      if (n) console.log(`[jumplist] bridge start: forcing a re-commit on ${n} recovered session(s) so task commands match this version`);+    } catch (e) {}+    brandSweep('startup').catch(() => {});+  }, 8000);   setTimeout(() => { ensureWindowOpenedWatch().catch(() => {}); }, 9000);    // Recover sessions from disk (reconnect to Chrome windows that survived bridge restart)