← Commit history

Overlays survive the reveal, and every window can PROVE what overlay it wears (John: 'prove what overlay icon you're showing and why, cuz i just now see all 3 of the pup windows you brought to fg lose their overlay icon'). Two parts. (1) The bug: browser_raise_os_window redraws the taskbar button (geometry + foreground) and nothing re-wore the favicon overlay afterward — every reveal silently stripped the icon. The raise now re-asserts the overlay (updateTabCountBadge at +1.2s, the same re-wear used after parks). (2) The proof surface: applyAppOverlay/count-badge now record WHAT is worn and WHY into session state (favicon:<host> | count:N with the no-favicon explanation | none with the reason), exposed as 'overlay' on every browser_list_windows entry — so test tables report the overlay per window instead of anyone guessing from a screenshot.

John Lauer ·65d81c9590 ·3mo ago ·parent 574807e
4 files changed +16−6
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.149",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.149/adom-bridge-puppeteer-v1.9.149.zip",-  "sha256": "55692b0f14587cc434fa043a40ee0321634223022e78c9127462ada38da24c99",-  "size": 399626,+  "version": "1.9.150",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.150/adom-bridge-puppeteer-v1.9.150.zip",+  "sha256": "bca6e47f3b9d6fddc280c5252294958c11989e31d86ab979dfe341827eda9043",+  "size": 399992,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.149+1.9.150
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.149",+  "version": "1.9.150",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+10
@@ -2867,6 +2867,7 @@ async function updateTabCountBadge(session, sessionId) {     if (count >= 2) {       const icon = tabBadgeIcon(count);       if (!icon) return;+      session._overlayDesc = `count:${count} (no favicon on the active tab, so the tab-count badge)`;       await chrome.adCommand('desktop_taskbar', {         titleContains: `(session: ${sessionId}`,         overlay: { icon, tooltip: `Adom Pup — ${count} tabs` },@@ -3168,6 +3169,7 @@ async function applyAppOverlay(session, sessionId) {       // collapser could not catch it. The fact is static per page; repeating it says nothing new.       if (!session._noFavLogged) { session._noFavLogged = true; console.log(`[overlay] "${sessionId}" no favicon on the active tab (retry ${session._faviconRetried ? 'queued' : 'done'})`); }       session._appOverlay = false;+      session._overlayDesc = 'none (active tab serves no favicon)';       return false;     }     session._faviconRetried = false;@@ -3213,6 +3215,9 @@ async function applyAppOverlay(session, sessionId) {       overlay: { icon: overlay, tooltip: `Adom Pup — ${nm}${plateAuthed ? 'Adom wiki: SIGNED IN · ' : ''}${tabs} tab${tabs === 1 ? '' : 's'}${tabs > 1 ? ' (icon = active tab)' : ''}` },     }, { timeoutMs: 5000 });     session._appOverlay = true;+    // v1.9.150 (John: 'prove what overlay icon you're showing and why'): record the WHAT and WHY+    // so list_windows can report it and test tables can prove it.+    try { session._overlayDesc = 'favicon:' + (src && src.href && src.href !== 'data:inline' ? new URL(src.href).hostname : 'inline-icon'); } catch (e) { session._overlayDesc = 'favicon'; }     return true;   } catch (e) { return false; } }@@ -6370,6 +6375,8 @@ async function getSessionInfo(sessionId, session) {     profile: session.profileName,     tabCount: session.tabs.length,     activeTabId: session.activeTabId,+    // v1.9.150: which taskbar overlay this window wears and why (favicon:<host> | count:N | none).+    overlay: session._overlayDesc || (session._appOverlay ? 'favicon' : 'none (not yet applied)'),     // v1.8.16: advisory ownership — which AI thread/task opened this window.     owner: session.owner || null,     ageMinutes: session.createdAt ? Math.round((Date.now() - session.createdAt) / 60000) : null,@@ -7867,6 +7874,9 @@ const server = http.createServer(async (req, res) => {           }           console.log(`[foreground] "${sessionId}" raise GRANTED — reason: ${fgReason}`);           session._lastForeground = { ts: Date.now(), verb: command, reason: fgReason };+          // v1.9.150: the reveal redraws the taskbar button; nothing re-wore the favicon, so all+          // three of John's foregrounded windows lost their overlay. Re-assert it after the raise.+          setTimeout(() => { updateTabCountBadge(session, args.sessionId || session._sessionId).catch(() => {}); }, 1200);           try { recordAgentUpdate(session, command, { updateNote: `FOREGROUND: ${fgReason}` }, session.activeTabId); } catch (e) {}           try {             // v1.9.149 (John's audit: two of three raised windows came up 0,0 full-screen, not the