← Commit history

Cut the enum_windows ab-log noise further: raised the desktop_enum_windows result cache from 120ms to 1500ms. The steady-state callers (the 8s reconcile, the overlay enforcer, the placement and user-activity sweeps) only need to find existing windows whose geometry does not change within 1.5s, so they share one snapshot per 1.5s, cutting the ab enumeration rate roughly 12x. Only the birth-time set-diff and off-screen re-capture loops need to see a brand-new window instantly; both pass fresh:true and bypass the cache.

John Lauer ·6546edd037 ·2mo ago ·parent 5c3d21b
4 files changed +15−10
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.150",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.150/adom-bridge-puppeteer-v2.0.150.zip",-  "sha256": "d5a91cc751474776e71398622c2c437105a442d4025896f88b6433ab2738a802",-  "size": 901662,+  "version": "2.0.151",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.151/adom-bridge-puppeteer-v2.0.151.zip",+  "sha256": "5d49788e9610db85a6b27bad0b88374264214727db4e76f1f60fd1a50e20818f",+  "size": 901842,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.150+2.0.151
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.150",+  "version": "2.0.151",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+9−4
@@ -6810,15 +6810,20 @@ async function hwndBelongsToPup(hwnd, session) { // TTL cache. The enforcer/park/flash/reconcile sweeps each independently enumerate every Chrome // window, so a single tick fired many identical desktop_enum_windows calls at ab within the same // few ms — the flood John saw. (1) In-flight coalescing: concurrent callers share ONE ab call.-// (2) A 120ms result cache: a burst of back-to-back calls reuses one snapshot. 120ms is under the-// birth/re-capture loops' 120ms inter-try sleeps, so those still see fresh windows appear on their-// next iteration — pass {fresh:true} to bypass the cache entirely for the rare caller that must.+// (2) A result cache. v2.0.151 (John: "does enum_windows have to be called as often as you do — it+// makes a lot of noise in ab's logs"): raised 120ms → 1500ms. The steady-state callers (the 8s+// reconcile, the overlay enforcer, the placement/user-activity sweeps) only need to FIND existing+// windows, and a window's geometry does not meaningfully change within 1.5s — so a shared snapshot+// per 1.5s is correct for them and cuts the ab call rate by ~12x. The ONLY callers that must observe+// a brand-new window the instant it appears are the birth-time set-diff and the off-screen+// re-capture move-detect loops; both pass {fresh:true} and bypass the cache entirely.+const ENUM_CACHE_MS = 1500; let _enumInflight = null; let _enumCache = { at: 0, rows: null }; async function enumChromeWidgetWindows(opts) {   if (process.platform !== 'win32') return [];   const fresh = !!(opts && opts.fresh);-  if (!fresh && _enumCache.rows && Date.now() - _enumCache.at < 120) return _enumCache.rows;+  if (!fresh && _enumCache.rows && Date.now() - _enumCache.at < ENUM_CACHE_MS) return _enumCache.rows;   if (!fresh && _enumInflight) return _enumInflight;   const run = (async () => {     try {