← Commit history

Captions are hard-capped at 2 seconds (John's standing rule, caught live). pupCaption defaulted to 8s and callers were passing 5s, 6s and even 15s — text parked over the user's screen long after it had been read. The cap is enforced at the single choke point (PUP_CAPTION_MAX_MS = 2000), so no caller can exceed it regardless of what it requests. Recorded as a standing rule in the pup skill and the maintainer skill: a caption is a glance, not a dialog; if something genuinely needs longer attention it belongs in a toast (notify_user, which the user dismisses) or in the verb response, not parked on their screen.

John Lauer ·62db5f416e ·3mo ago ·parent 9a581c5
4 files changed +14−7
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.220",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.220/adom-bridge-puppeteer-v1.9.220.zip",-  "sha256": "3b1284f9af9a9322db059ecede2117f284b3bac427f5af4d16ef1b10cc229909",-  "size": 446007,+  "version": "1.9.221",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.221/adom-bridge-puppeteer-v1.9.221.zip",+  "sha256": "3f5d4902e656f8237bdc4fe6ca4882cf3928ea6a5778e59c4d00a9954ead1980",+  "size": 446286,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.220+1.9.221
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.220",+  "version": "1.9.221",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+8−1
@@ -1927,7 +1927,14 @@ async function ensureSafeForNativeInput(sessionId, { reason = 'drive the window   return true; } -async function pupCaption(text, expiresInMs = 8000, id = 'pup-assist') {+// v1.9.221 (John, standing rule): A CAPTION IS NEVER SHOWN LONGER THAN 2 SECONDS. Callers had been+// passing 5s, 6s, 8s and even 15s, which parks text over the user's screen long after it has been+// read — he caught a 15s one live. The cap is enforced HERE, at the single choke point, so no caller+// can violate it regardless of what it requests. A caption is a glance, not a dialog: if something+// genuinely needs the user's attention for longer, use a toast (notify_user), which they dismiss.+const PUP_CAPTION_MAX_MS = 2000;+async function pupCaption(text, expiresInMs = PUP_CAPTION_MAX_MS, id = 'pup-assist') {+  expiresInMs = Math.min(Number(expiresInMs) || PUP_CAPTION_MAX_MS, PUP_CAPTION_MAX_MS);   try { await chrome.adCommand('desktop_caption', { text, expiresInMs, id, position: 'bottom', size: 'medium' }, { timeoutMs: 4000 }); } catch (e) {} } async function sessionHwnd(sessionId) {