Pup - the AI's own browser

@@ -9737,10 +9737,47 @@ async function getOrLaunchBrowser(profileName, { freshProfile = false, strictPer       const lockFile = path.join(userDataDir, 'SingletonLock');       const lockExists = fs.existsSync(lockFile) || fs.existsSync(path.join(userDataDir, 'lockfile'));       if (lockExists) {-        console.log(`Profile "${profileName}" has a lock file — checking for orphaned Chrome...`);-        await killBrowserProcess(null, profileName);-        // Give OS time to release the lock-        await new Promise(r => setTimeout(r, 1000));+        // v2.0.257 — THE BUG THAT COST JOHN THREE WINDOWS (2026-08-20). This kill is authorized by an+        // INFERENCE: "a lock file exists and I could not reconnect just now, therefore the holder is a+        // dead orphan from an unclean shutdown." That inference is wrong in the one case where it is+        // catastrophic. The reconnect above gives up after a 3s probe + a 5s puppeteer.connect, and on+        // a loaded machine a perfectly healthy Chrome misses those deadlines — so pup declared the LIVE+        // shared adom-you Chrome an orphan and killed it, taking three windows with it (two other+        // threads' dashboards and the ab web-demo window John was actively using). pup then relaunched+        // them and reconciled them away as "closed", so from John's side they simply vanished.+        // GROUND TRUTH beats inference: if any live session is bound to this profile, that process is+        // not an orphan — it is the process serving the user's windows. Never kill it. Try one patient+        // reconnect instead, and if that fails, fail THIS launch honestly rather than destroying work+        // that is not ours to destroy. A failed launch costs a retry; a wrong kill costs the user's+        // windows, and they have no way to get them back.+        let _liveOnProfile = 0;+        for (const _s of sessions.values()) { if (_s.profileName === profileName) _liveOnProfile++; }+        if (_liveOnProfile > 0) {+          console.log(`Profile "${profileName}" lock is held while ${_liveOnProfile} live pup session(s) are bound to it — that Chrome is NOT an orphan, it is serving the user's windows. Refusing to kill it; retrying the reconnect patiently.`);+          let _reconnected = null;+          try {+            const _pf = path.join(userDataDir, 'DevToolsActivePort');+            const _p = parseInt(String(fs.readFileSync(_pf, 'utf8')).trim().split('\n')[0], 10);+            if (_p && !isNaN(_p)) {+              _reconnected = await Promise.race([+                puppeteer.connect({ browserURL: `http://127.0.0.1:${_p}`, defaultViewport: null }),+                new Promise((_, rej) => setTimeout(() => rej(new Error('patient reconnect timeout')), 20000)),+              ]);+              _reconnected._cdpPort = _p;+            }+          } catch (e) { console.log(`Patient reconnect to profile "${profileName}" failed too (${e.message})`); }+          if (_reconnected) {+            console.log(`Patient reconnect to profile "${profileName}" SUCCEEDED — the browser was healthy, just slow. Nothing was killed.`);+            browser = _reconnected;+          } else {+            throw new Error(`profile "${profileName}" is in use by ${_liveOnProfile} live pup session(s) and its Chrome could not be reconnected. Refusing to kill the browser hosting those windows just to free the profile lock — that would destroy windows other threads (or the user) are using. Retry in a moment, or close those sessions first with pup_close_window.`);+          }+        } else {+          console.log(`Profile "${profileName}" has a lock file and NO live sessions are bound to it — checking for orphaned Chrome...`);+          await killBrowserProcess(null, profileName);+          // Give OS time to release the lock+          await new Promise(r => setTimeout(r, 1000));+        }       }        // Pup is AI-driven, never human-driven, so Chrome's "restore last@@ -9749,12 +9786,15 @@ async function getOrLaunchBrowser(profileName, { freshProfile = false, strictPer       // running heavy content (3D viewers, animations) under the       // anti-throttle flags we set, eating CPU. Wipe the session-restore       // state before launch — the AI knows what it wants open.-      prepareCleanProfile(userDataDir);+      // v2.0.257: skip when the patient reconnect above adopted the live browser — that profile is+      // IN USE and wiping its session-restore state (or relaunching over it) is exactly the damage+      // this fix exists to prevent.+      if (!browser) prepareCleanProfile(userDataDir);       // Give the profile a visible Adom identity in Chrome's profile chip. The       // shared durable jar is branded "Adom"; a named isolated jar carries its       // own name so the user can still tell windows apart. Both wear the       // Adom-logo avatar so ANY pup window is visually distinct from real Chrome.-      brandPupProfile(userDataDir, profileName,+      if (!browser) brandPupProfile(userDataDir, profileName,         profileName === DEFAULT_PROFILE ? 'Adom'           : (/^iso-.*-pub$/.test(profileName) ? 'Adom · anonymous' : ('Adom · ' + profileName)));     }@@ -9986,6 +10026,10 @@ async function getOrLaunchBrowser(profileName, { freshProfile = false, strictPer     const launchList = candidates.length ? candidates : [{ kind: 'default', source: 'puppeteer', executablePath: null }];      for (const cand of launchList) {+      // v2.0.257: the patient reconnect above may have adopted the profile's LIVE browser rather than+      // letting pup kill it. In that case there is nothing to launch — relaunching over a profile that+      // is in use is the very damage being prevented.+      if (browser) break;       if (cand.executablePath) launchOpts.executablePath = cand.executablePath;       else delete launchOpts.executablePath;       // v2.0.53: the toolbar rides ONLY on CfT (branded Chrome ignores/removed the flag).