← Commit history

Untracked-window false positives killed: every Chrome process carries a hidden helper window (class Chrome_WidgetWin_1) that reports IsWindowVisible yet has no real size, and the untracked detector counted exactly one phantom per pup process - John's dashboard read '3 UNTRACKED' red against 3 processes while every real window was tracked and green. The enumerator now requires a real window rect (>= 80x60). The honesty LED only goes red for windows that actually exist on the taskbar.

John Lauer ·5eadb2db74 ·2mo ago ·parent 659f073
4 files changed +13−6
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.272",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.272/adom-bridge-puppeteer-v1.9.272.zip",-  "sha256": "12669e7133f786e9375bd02626025752b69693808b9b0d6a1e96952932d46e4d",-  "size": 615562,+  "version": "1.9.273",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.273/adom-bridge-puppeteer-v1.9.273.zip",+  "sha256": "9af581706065f8266d1c898c72473591d81e7ee2acac1ca238b555f8e2fba7ef",+  "size": 615738,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.272+1.9.273
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.272",+  "version": "1.9.273",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+7
@@ -6065,6 +6065,8 @@ async function enumAllPupChromeHwnds() {       '  [DllImport("user32.dll")] public static extern bool IsWindowVisible(IntPtr h);',       '  [DllImport("user32.dll")] public static extern uint GetWindowThreadProcessId(IntPtr h, out uint pid);',       '  [DllImport("user32.dll")] public static extern int GetClassName(IntPtr h, StringBuilder s, int n);',+      '  public struct RECT { public int L, T, R, B; }',+      '  [DllImport("user32.dll")] public static extern bool GetWindowRect(IntPtr h, out RECT r);',       '  public static List<string> Find() {',       '    var outp = new List<string>();',       '    EnumWindows((h, l) => {',@@ -6072,6 +6074,11 @@ async function enumAllPupChromeHwnds() {       '      uint pid; GetWindowThreadProcessId(h, out pid);',       '      var cn = new StringBuilder(128); GetClassName(h, cn, 128);',       '      if (cn.ToString() != "Chrome_WidgetWin_1") return true;',+      // v1.9.273: every Chrome process carries a hidden helper window that still reports visible;+      // it has no real size. Only REAL windows (>= 80x60) count, else the untracked detector cries+      // wolf with exactly one phantom per pup process (John saw "3 UNTRACKED" against 3 processes).+      '      RECT r; GetWindowRect(h, out r);',+      '      if ((r.R - r.L) < 80 || (r.B - r.T) < 60) return true;',       '      outp.Add(((long)h).ToString() + "," + pid);',       '      return true;',       '    }, IntPtr.Zero);',