← Commit history

Badge design per John: no plate. The badge IS the page's own favicon at full bleed with the Adom mark inset into its lower-right corner — the favicon keeps the exact look it was designed with instead of sitting on a tinted card (the light plate from 1.9.192 read as ugly, and the dark plate before it hid dark favicons like GitHub's). The corner mark keeps a small dark disc purely for legibility over busy or light favicon artwork at taskbar size.

John Lauer ·5afef89793 ·3mo ago ·parent 9ac029d
4 files changed +16−17
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.192",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.192/adom-bridge-puppeteer-v1.9.192.zip",-  "sha256": "d4307fa0fc68c451851fc538d532476f6f857e63a8c2c1ea531ceb4a445b17c7",-  "size": 424302,+  "version": "1.9.193",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.193/adom-bridge-puppeteer-v1.9.193.zip",+  "sha256": "352ef6fc82cb32c3cf7b379c8b9c36f07ba17c753361985c918699b53f70d75b",+  "size": 424245,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.192+1.9.193
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.192",+  "version": "1.9.193",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+10−11
@@ -3749,22 +3749,21 @@ async function applyAppOverlay(session, sessionId) {           //   favicon 23x23 at (1,1)      — dominant, upper-left biased           //   disc    15x15 at (16,16)    — dark backing so the mark separates from busy favicons           //   mark    12x12 at (17,17)    — the Adom leaves-          // v1.9.192: the plate must be LIGHT. Favicons are authored to sit in a browser TAB STRIP,-          // which is light, so a large share of them are dark marks on transparency — GitHub's is-          // near-black. On the old dark plate those composited dark-on-dark and vanished (proven on-          // glass: the wiki badge showed, the GitHub badge was invisible even though it applied).-          // A light plate renders both dark and light favicons; the Adom mark keeps its own dark-          // disc in the corner, so brand contrast is preserved either way.-          const plate = Buffer.from(`<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 32 32"><rect x="0" y="0" width="32" height="32" rx="8" fill="#eef4f5"/></svg>`);-          let img = sharpMod(plate).resize(32, 32);+          // v1.9.193 (John: "don't do a white background, that's ugly — you are just insetting the+          // adom favicon into the other favicon"). NO PLATE. The badge IS the page's own favicon at+          // full bleed, with the Adom mark inset into its lower-right corner. The favicon keeps the+          // exact look it was designed with (no tinted card behind it), and the corner mark carries+          // the branding. The mark sits on a small dark disc purely so it stays readable over busy+          // or light favicon artwork at ~16px.+          let img = sharpMod({ create: { width: 32, height: 32, channels: 4, background: { r: 0, g: 0, b: 0, alpha: 0 } } });           const layers = [];-          if (iconPng) layers.push({ input: await sharpMod(Buffer.from(src.b64, 'base64')).resize(23, 23, { fit: 'inside' }).png().toBuffer(), top: 1, left: 1 });+          if (iconPng) layers.push({ input: await sharpMod(Buffer.from(src.b64, 'base64')).resize(32, 32, { fit: 'inside' }).png().toBuffer(), gravity: 'northwest' });           try {             const markB64 = pupBadgeB64();             if (markB64) {               const disc = Buffer.from('<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 15 15"><circle cx="7.5" cy="7.5" r="7.5" fill="#0b2325"/></svg>');-              layers.push({ input: await sharpMod(disc).resize(15, 15).png().toBuffer(), top: 16, left: 16 });-              layers.push({ input: await sharpMod(Buffer.from(markB64, 'base64')).resize(12, 12, { fit: 'inside' }).png().toBuffer(), top: 17, left: 17 });+              layers.push({ input: await sharpMod(disc).resize(16, 16).png().toBuffer(), top: 16, left: 16 });+              layers.push({ input: await sharpMod(Buffer.from(markB64, 'base64')).resize(13, 13, { fit: 'inside' }).png().toBuffer(), top: 17, left: 17 });             }           } catch (e) { /* no mark available — favicon-only badge still valid */ }           if (layers.length) img = img.composite(layers);