← Commit history

Fix the once-per-process bug-report invitation never reaching an AI: AD probes /health (and /status for the bridge chip) every ~15s and those replies flow through the same sendJSON chokepoint, so the first health probe after a spawn consumed the invitation and the first real verb carried nothing (measured after a restart). The invite is now VERB-SCOPED — it only counts responses that belong to an actual AI-facing command (res._adomCommand), so a machine-facing probe can neither consume the orientation invite nor advance the periodic counter.

John Lauer ·5912ae651a ·3mo ago ·parent c2f92d2
4 files changed +14−8
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.95",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.95/adom-bridge-puppeteer-v1.9.95.zip",-  "sha256": "6200ef6d84bc765d8e3434e78d2d62f31598bc46672f903916773e823708e687",-  "size": 369557,+  "version": "1.9.96",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.96/adom-bridge-puppeteer-v1.9.96.zip",+  "sha256": "3bdf07e825d90b478e2d8d1b82bfdd8cc27e2185e7631e7f4ef5f28b92e34c56",+  "size": 369765,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.95+1.9.96
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.95",+  "version": "1.9.96",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+8−2
@@ -5670,10 +5670,16 @@ function bugReportInvite(isError) {     : 'pup is actively developed and bug reports are genuinely wanted.';   return `${lead} If a pup verb misbehaves (wrong result, a hang, a window that never appears, a hint that turned out to be false, a process left running), file it on pup's own wiki repo so the maintainers see it: \`adom-wiki issue list ${PUP_ISSUES_REF}\` to check for a duplicate first, then \`adom-wiki issue create ${PUP_ISSUES_REF} --title "<one-line symptom>" --category bug-report --body "<what you ran, what you expected, what happened, the VERBATIM response JSON, and the bridge version from bridge_list>"\`. Include the machine's OS and whether it is Windows or macOS. Reports from real machines are the only way this bridge gets correct — the maintainers cannot reproduce every environment, browser install, or concurrency pattern locally. (An AD-core problem — the relay, bridge lifecycle, caller identity — belongs on adom/adom-desktop instead.)`; }-function maybeAttachBugInvite(obj) {+function maybeAttachBugInvite(obj, verb) {   try {     if (!obj || typeof obj !== 'object' || Array.isArray(obj)) return;     if (obj._reportIssues) return;                                   // handler already set one+    // v1.9.95a — ONLY count AI-facing VERB responses. AD probes /health (and /status for the chip)+    // every ~15s and those replies flow through sendJSON too, so without this gate the very first+    // health probe after a spawn consumed the once-per-process invitation and no AI ever saw it+    // (measured: the first real verb after a restart carried nothing). A machine-facing probe is not+    // a caller we can ask for a bug report.+    if (!verb) return;     let mode = 'on';     try { mode = (pupSettings().reportIssues === 'off') ? 'off' : 'on'; } catch (e) {}     if (mode === 'off') return;@@ -5693,7 +5699,7 @@ function sendJSON(res, obj, status = 200) {     // verb and the handler didn't already set its own _hint, attach the verb's     // canonical hint (+ related) from VERB_META. So EVERY browser_* call carries     // actionable guidance inline, matching the contract AD asks all bridges for.-    maybeAttachBugInvite(obj);+    maybeAttachBugInvite(obj, res && res._adomCommand);     if (obj && typeof obj === 'object' && !Array.isArray(obj)) {       const meta = res && res._adomCommand && VERB_META[res._adomCommand];       if (meta) {