← Commit history

v2.0.235: The overlay-badge apply loop lived in two copies and a progress-tracker edit only declared its variable in one of them, so every pup_configure toggle threw an unhandled ReferenceError; both call sites now share a single implementation that takes the progress entry as a parameter.

John Lauer ·55d978db6b ·2mo ago ·parent a880da9
4 files changed +27−26
adom-bridge-puppeteer-manifest.json+5−5
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.234",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.234/adom-bridge-puppeteer-v2.0.234.zip",-  "sha256": "bb77b1d8d43564c7f49490054cdf146faf9840e01b400ffb9ab3d667c2d7b45d",-  "size": 945203,+  "version": "2.0.235",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.235/adom-bridge-puppeteer-v2.0.235.zip",+  "sha256": "a88dc58cc91891672ee96e8715fd6f8f5a37ba57da1a3fe3c9f4e896fff0360c",+  "size": 945172,   "verbPrefixes": [     "browser_",     "desktop_recorder_",@@ -12,5 +12,5 @@   ],   "healthEndpoint": "/status",   "statusVerb": "browser_readiness",-  "released_at": "2026-08-18T12:11:33.323177Z"+  "released_at": "2026-08-18T12:18:16.740453Z" }
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.234\ No newline at end of file+2.0.235\ No newline at end of file
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.234",+  "version": "2.0.235",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+20−19
@@ -4947,6 +4947,24 @@ function scheduleIconAudit(reason, delayMs = 25000) { if (process.platform === 'win32') {   setInterval(() => { if (sessions.size) auditTaskbarIcons('steady-state').catch(() => {}); }, 4 * 60 * 1000); }+// v2.0.235: the overlayBadges apply loop existed TWICE (dashboard set-setting + pup_configure).+// A progress-tracker edit landed in both copies but its variable was declared in only one, so every+// pup_configure toggle threw "ReferenceError: _obApply is not defined" as an unhandled rejection.+// One implementation now; `track` carries the progress entry when the caller made one.+async function applyOverlayBadgeSetting(val, track) {+  try {+    for (const [sid, sess] of [...sessions]) {+      if (val === 'off') {+        try { await chrome.abCommand('desktop_taskbar', { ...(await windowTarget(sess, sid)), overlay: { badge: 'none' } }, { timeoutMs: 5000 }); } catch (e) {}+        sess._appOverlay = false; sess._lastPaintSig = null;+      } else {+        sess._appOverlay = false; sess._lastPaintSig = null; sess._overlayEnforceAt = 0;+        try { await applyAppOverlay(sess, sid); } catch (e) {}+      }+    }+  } catch (e) { console.log(`[settings] overlayBadges apply failed: ${e && e.message}`); }+  if (track && _modeApply === track) { track.steps[0].state = 'done'; track.done = true; }+} async function refreshAllJumplists() {   if (process.platform !== 'win32' || _jumplistSupported === false) return;   const off = pupSettings().jumpLists !== 'on';@@ -12489,15 +12507,7 @@ const server = http.createServer(async (req, res) => {               _obApply = { at: Date.now(), token: ++_modeApplyTok, mode: 'overlay-' + val, steps: [{ label: val === 'on' ? 'Painting overlay badges' : 'Clearing overlay badges', state: 'run' }], done: false };               _modeApply = _obApply;             }-            (async () => { try {-              for (const [sid8, s8] of [...sessions]) {-                if (val === 'off') {-                  try { await chrome.abCommand('desktop_taskbar', { ...(await windowTarget(s8, sid8)), overlay: { badge: 'none' } }, { timeoutMs: 5000 }); } catch (e) {}-                  s8._appOverlay = false; s8._lastPaintSig = null;-                } else { s8._appOverlay = false; s8._lastPaintSig = null; s8._overlayEnforceAt = 0; try { await applyAppOverlay(s8, sid8); } catch (e) {} }-              }-            } catch (e) {}-            if (_obApply && _modeApply === _obApply) { _obApply.steps[0].state = 'done'; _obApply.done = true; } })();+            applyOverlayBadgeSetting(val, _obApply).catch(() => {});           }           // v2.0.90: the pencil hit-area slider live-applies — re-inject the floaty on every open           // page (the versioned guard includes the px value, so a change tears down and rebuilds).@@ -13960,16 +13970,7 @@ const server = http.createServer(async (req, res) => {           if (ob) {             savePupSettings({ overlayBadges: ob });             console.log(`[configure] overlayBadges -> ${ob}`);-            // v2.0.197: OFF clears every painted badge from glass; ON marks bare so the enforcer repaints.-            (async () => { try {-              for (const [sid8, s8] of [...sessions]) {-                if (ob === 'off') {-                  try { await chrome.abCommand('desktop_taskbar', { ...(await windowTarget(s8, sid8)), overlay: { badge: 'none' } }, { timeoutMs: 5000 }); } catch (e) {}-                  s8._appOverlay = false; s8._lastPaintSig = null;-                } else { s8._appOverlay = false; s8._lastPaintSig = null; s8._overlayEnforceAt = 0; try { await applyAppOverlay(s8, sid8); } catch (e) {} }-              }-            } catch (e) {}-            if (_obApply && _modeApply === _obApply) { _obApply.steps[0].state = 'done'; _obApply.done = true; } })();+            applyOverlayBadgeSetting(ob, null).catch(() => {});           }           // v2.0.213 (selftest T6 caught it): pup_configure NEVER handled jumpLists — the arg was           // silently ignored (only the dashboard dialog was wired to refreshAllJumplists), so a