Pup - the AI's own browser

@@ -1925,21 +1925,31 @@ function osMinimizeToBackground(pid, cdpPort, respectUser) { // no direct API (CDP has no z-order; AD has no send-to-back verb yet — issue filed). Minimal // PS: one P/Invoke signature, no window-finding, no pid guessing, hwnd comes from AD's native // desktop_find_window. Everything else in the park is CDP/AD direct.-function osSendHwndToBottom(hwnd) {-  if (process.platform !== 'win32' || !hwnd) return false;+function osBottomUnlessForeground(hwnd) {+  if (process.platform !== 'win32' || !hwnd) return 'error';   try {     const scriptPath = path.join(require('os').tmpdir(), `_adom_zbot_${hwnd}.ps1`);     const ps = [       'Add-Type @"',       'using System; using System.Runtime.InteropServices;',-      'public class ZBot { [DllImport("user32.dll")] public static extern bool SetWindowPos(IntPtr h, IntPtr a, int x, int y, int cx, int cy, uint f); }',+      'public class ZBot {',+      '  [DllImport("user32.dll")] public static extern bool SetWindowPos(IntPtr h, IntPtr a, int x, int y, int cx, int cy, uint f);',+      '  [DllImport("user32.dll")] public static extern IntPtr GetForegroundWindow();',+      '}',       '"@',-      `[ZBot]::SetWindowPos([IntPtr]${Number(hwnd)}, [IntPtr]1, 0, 0, 0, 0, 0x13) | Out-Null`, // HWND_BOTTOM; SWP_NOSIZE|NOMOVE|NOACTIVATE+      // THE OS truth: GetForegroundWindow. (document.hasFocus() via CDP LIES for CDP-created+      // windows — it reports internal focus even when the OS never foregrounded them, which+      // false-fired 'user-foreground' on every open in the first 1.8.53 build.) With+      // --no-startup-window, OS-foreground == the user clicked; then do NOT bottom it.+      `$h = [IntPtr]${Number(hwnd)}`,+      'if ([ZBot]::GetForegroundWindow() -eq $h) { Write-Output "foreground"; exit }',+      '[ZBot]::SetWindowPos($h, [IntPtr]1, 0, 0, 0, 0, 0x13) | Out-Null', // HWND_BOTTOM; SWP_NOSIZE|NOMOVE|NOACTIVATE+      'Write-Output "bottomed"',     ].join('\r\n');     fs.writeFileSync(scriptPath, ps);-    runPsHidden(scriptPath, { timeout: 5000 });-    return true;-  } catch (e) { return false; }+    const out = runPsHidden(scriptPath, { timeout: 5000 }).trim();+    return out || 'error';+  } catch (e) { return 'error'; } }  // v1.8.53: THE park — direct APIs end to end (John: "why powershell? that's heavy. why aren't@@ -1950,7 +1960,8 @@ function osSendHwndToBottom(hwnd) { //      taskbar during the launch gap (Chrome can't self-focus anymore) → move on-screen, leave //      them on it, report 'user-foreground'. //   2. Z-bottom while still OFF-SCREEN (invisible): hwnd via AD desktop_find_window (native,-//      title-suffix match), then osSendHwndToBottom (the one residual Win32 call).+//      title-suffix match), then osBottomUnlessForeground (the one residual Win32 call,+//      which ALSO reads GetForegroundWindow — the only honest user-click signal). //   3. Re-check focus (user may have clicked mid-park) → if so, on-screen + AD bring_to_front. //   4. CDP Browser.setWindowBounds → on-screen full-size. CDP addresses the EXACT window by //      windowId, so the catch-2 failure mode (parked the wrong window) is impossible.@@ -1960,17 +1971,15 @@ async function parkSessionWindowDirect(page, sessionId) {   if (process.platform !== 'win32') return null;   let cdp = null;   try {-    const hasFocus = async () => { try { return await page.evaluate(() => document.hasFocus()); } catch (e) { return false; } };     cdp = await page.target().createCDPSession();     const { windowId } = await cdp.send('Browser.getWindowForTarget');-    let scr = { w: 1280, h: 800 };+    let scr = { w: 1600, h: 900 };     try { scr = await page.evaluate(() => ({ w: screen.availWidth, h: screen.availHeight })); } catch (e) {}-    const onScreenBounds = { left: 0, top: 0, width: scr.w, height: scr.h };-    if (await hasFocus()) {+    const onScreenBounds = { left: 0, top: 0, width: Math.round(scr.w), height: Math.round(scr.h) };+    const placeOnScreen = async () => {       await cdp.send('Browser.setWindowBounds', { windowId, bounds: { windowState: 'normal' } });       await cdp.send('Browser.setWindowBounds', { windowId, bounds: onScreenBounds });-      return 'user-foreground';-    }+    };     // hwnd via AD (native) — the title suffix "(session: <id>" is set by the welcome page.     let hwnd = null;     for (let i = 0; i < 4 && !hwnd; i++) {@@ -1981,17 +1990,17 @@ async function parkSessionWindowDirect(page, sessionId) {       } catch (e) {}       if (!hwnd) await new Promise(r2 => setTimeout(r2, 250));     }-    if (hwnd) osSendHwndToBottom(hwnd);-    if (await hasFocus()) {-      // User clicked while we were parking — give them the window, foregrounded, on-screen.-      await cdp.send('Browser.setWindowBounds', { windowId, bounds: { windowState: 'normal' } });-      await cdp.send('Browser.setWindowBounds', { windowId, bounds: onScreenBounds });+    // Z-bottom while still off-screen — UNLESS the OS says the user has it foreground+    // (GetForegroundWindow, the only honest signal; document.hasFocus() lies for CDP windows).+    const z = osBottomUnlessForeground(hwnd);+    if (z === 'foreground') {+      // User clicked during the launch gap — give them the window on-screen, foregrounded.+      await placeOnScreen();       if (hwnd) { try { await chrome.adCommand('desktop_bring_to_front', { hwnd }, { timeoutMs: 3000 }); } catch (e) {} }       return 'user-foreground';     }     // On-screen full-size WITHOUT activation — CDP move preserves z-order (we're at bottom).-    await cdp.send('Browser.setWindowBounds', { windowId, bounds: { windowState: 'normal' } });-    await cdp.send('Browser.setWindowBounds', { windowId, bounds: onScreenBounds });+    await placeOnScreen();     // Verify POSITION, not just focus.     let verified = false;     try {