← Commit history

Fix: pup_configure was ownership-gated on the active window, so changing any GLOBAL setting (threadTiles, taskbarGrouping, aumidIconStyle, etc.) while another thread's window happened to be active was refused with session_owned_by_another_thread. pup_configure sets global preferences, not a per-window action, so it is removed from the owner-gated verb list. Surfaced while enabling the new Thread Tiles mode.

John Lauer ·5465eac874 ·2mo ago ·parent 54e8c5b
4 files changed +11−7
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.152",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.152/adom-bridge-puppeteer-v2.0.152.zip",-  "sha256": "6cc7bffb24860c63a48ed860e12133960532eebe79b415678ad6f0d3ce3da0c6",-  "size": 905342,+  "version": "2.0.153",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.153/adom-bridge-puppeteer-v2.0.153.zip",+  "sha256": "c09d2ed2a95e70d0085594165027133f4484f2029c8017e7266c4d48d4c67174",+  "size": 905485,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.152+2.0.153
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.152",+  "version": "2.0.153",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+5−1
@@ -12004,8 +12004,12 @@ const server = http.createServer(async (req, res) => {         // thread, by design) — never gate it, never resolve it to the active window.         const _isUserTaskbar = USER_CALLERS.has(_callerThread);         const _isGlobalClose = command === 'pup_close' && !(args && args.sessionId);+        // v2.0.153 (found building Thread Tiles): pup_configure sets GLOBAL settings (threadTiles,+        // taskbarGrouping, aumidIconStyle, …), not a per-window action — so it must NEVER be gated on+        // the active window. It was in this list, so changing any setting while ANOTHER thread's+        // window happened to be active was refused with session_owned_by_another_thread. Removed.         const OWNER_GATED = !_isUserTaskbar && !_isGlobalClose && (MUTATING_VERBS.has(command)-          || ['pup_close_tab', 'pup_close_window', 'pup_close', 'pup_configure', 'pup_focus_window',+          || ['pup_close_tab', 'pup_close_window', 'pup_close', 'pup_focus_window',               'pup_raise_os_window', 'pup_lower_os_window', 'pup_alert_window', 'pup_wiki_set_view',               'pup_record_start', 'pup_record_stop'].includes(command));         // With sessionId OMITTED, a mutating verb used to resolve to activeSessionId (another thread's