← Commit history

v2.0.312: Birth wait uses ab's real timeoutSec param (it was returning early and the title had not propagated yet); the resolver honors its own backoff (property lookup only, no per-call miss logging).

John Lauer ·541bb32f66 ·2mo ago ·parent f79a7df
4 files changed +19−8
adom-bridge-puppeteer-manifest.json+5−5
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.311",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.311/adom-bridge-puppeteer-v2.0.311.zip",-  "sha256": "893dfa4818f80f9bc65606664bc613b7885efe917079def630d4b3f04d1d9a09",-  "size": 1436056,+  "version": "2.0.312",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.312/adom-bridge-puppeteer-v2.0.312.zip",+  "sha256": "b4877a48379dea7134221296e3ade641aee086580bec9973263d20479869a483",+  "size": 1436295,   "verbPrefixes": [     "browser_",     "desktop_recorder_",@@ -12,5 +12,5 @@   ],   "healthEndpoint": "/status",   "statusVerb": "browser_readiness",-  "released_at": "2026-08-23T15:13:06.133370Z"+  "released_at": "2026-08-23T15:16:11.493193Z" }
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.311\ No newline at end of file+2.0.312\ No newline at end of file
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.311",+  "version": "2.0.312",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+12−1
@@ -8205,6 +8205,17 @@ async function resolveSessionHwndByBounds(session, sessionId) {   // v2.0.33: the backoff suppresses the GEOMETRY hammering (its original purpose) but must NOT   // block the definitive off-screen RE-CAPTURE below — that is the fix for the stuck-bare case.   const _geomBackoff = !!(session._hwndBackoffUntil && Date.now() < session._hwndBackoffUntil);+  // v2.0.312 (John's ring showed "17 straight misses" in 5s while claiming a 5-minute backoff): the+  // backoff used to skip only the geometry leg, which is deleted, so every sweep still ran the whole+  // function and logged a miss ~4x/sec. In backoff: one in-process property lookup (microseconds),+  // then return quietly. The tag is the only signal that can change the answer anyway.+  if (_geomBackoff) {+    try {+      const _ph0 = await resolveHwndBySessionProp(sessionId);+      if (_ph0) { session._hwnd = _ph0; session._hwndFailStreak = 0; session._hwndBackoffUntil = 0; console.log(`[hwnd] "${sessionId}" resolved ${_ph0} by property tag (during backoff)`); return _ph0; }+    } catch (e) {}+    return null;+  }   let _releaseWiggle = null;   // v1.9.291: hoisted so the outer catch can always release the lock   try {     // v1.9.278: NEVER trust a cached hwnd blind - validate it still belongs to pup before reuse@@ -10675,7 +10686,7 @@ async function createPageInNewWindow(browser, profileName) {         // ONE server-side wait on the unique title now: ab blocks until a Chrome_WidgetWin_1 window         // whose title contains the token exists and hands back its hwnd. No enumeration, no deltas.         try {-          const _w = abPayload(await chrome.abCommand('desktop_wait_for_window', { titleContains: _birthTitle, classContains: 'Chrome_WidgetWin_1', includeOffscreen: true, timeoutMs: 2500 }, { timeoutMs: 4000 }));+          const _w = abPayload(await chrome.abCommand('desktop_wait_for_window', { titleContains: _birthTitle, classContains: 'Chrome_WidgetWin_1', includeOffscreen: true, timeoutSec: 3 }, { timeoutMs: 6000 }));   // ab's param is timeoutSec; it polls until the OS title carries the token           const _h = _w && _w.window && Number(_w.window.hwnd);           if (_h && !hwndOwnedByOtherSession(_h, null)) { capturedHwnd = _h; console.log(`[birth] wait_for_window matched "${_birthTitle}" -> ${_h} in ${_w.waitedMs != null ? _w.waitedMs + 'ms' : '?'}`); }           else console.log(`[birth] wait_for_window did not match "${_birthTitle}" (${JSON.stringify(_w).slice(0, 160)})`);