← Commit history

v1.9.15: retry the login-state icon re-stamp so it stops losing the race against relaunched-window title injection

John Lauer ·4faa08ad9a ·3mo ago ·parent e7f27e9
5 files changed +29−9
CHANGELOG.md+9
@@ -1,5 +1,14 @@ # Changelog — Adom Desktop Puppeteer Bridge +## 1.9.15 — 2026-07-20 — Retry the icon re-stamp (the flip silently lost a race)++1.9.14 tracked login state correctly but the taskbar icon did not visibly change. Cause: after a+view toggle the window is BRAND NEW, and AD resolves it by the "(session: <id>)" title suffix that+pup injects only once the relaunched page loads. The single immediate re-stamp fired first and AD+answered "No visible window with title containing (session: ...)" - visible in the log as a+[badge] FAILED with no matching [identity] stamped line. Now retried with backoff until the title+exists, and the failure is logged loudly instead of passing silently.+ ## 1.9.14 — 2026-07-19 — Login state on the MAIN icon; overlay stays favicons (reverted 1.9.13)  REVERTED 1.9.13's overlay-slot padlock. John was explicit: the overlay is for FAVICONS ("i LOVE
adom-bridge-puppeteer-manifest.json+5−5
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.14",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.14/adom-bridge-puppeteer-v1.9.14.zip",-  "sha256": "078a72b32d2261681c1323437900077b74c71250d76cd15d245a22d6224ab71a",-  "size": 235627,+  "version": "1.9.15",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.15/adom-bridge-puppeteer-v1.9.15.zip",+  "sha256": "d921a7198726f8f73dda16674cebf2be9ec03ad7509554c1d253d9609bbedaab",+  "size": 235958,   "verbPrefixes": [     "browser_",     "desktop_recorder_",@@ -12,5 +12,5 @@   ],   "healthEndpoint": "/status",   "statusVerb": "browser_readiness",-  "released_at": "2026-07-20T00:00:00Z"+  "released_at": "2026-07-20T00:15:00Z" }
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.14\ No newline at end of file+1.9.15\ No newline at end of file
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.14",+  "version": "1.9.15",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+13−2
@@ -1820,8 +1820,19 @@ async function setWikiAuthedState(session, sessionId, authed) {   if (session._wikiAuthed === next) return false;   session._wikiAuthed = next;   if (process.platform !== 'win32') return true;-  console.log(`[identity] "${sessionId}" wiki login state -> ${next ? 'LOGGED IN (green closed padlock)' : 'logged out (slate open padlock)'}`);-  try { await stampPupIdentity(sessionId); } catch (e) {}+  console.log(`[identity] "${sessionId}" wiki login state -> ${next ? 'LOGGED IN (solid green glyph)' : 'logged out (hollow glyph)'}`);+  // v1.9.15: RETRY the re-stamp. After a view toggle the window is BRAND NEW and AD resolves it by+  // its "(session: <id>)" title suffix, which the title injector adds only once the relaunched page+  // has loaded — so a single immediate stamp loses the race and AD answers "No visible window with+  // title containing (session: ...)". That is exactly why the icon did not flip on the first try.+  // Retry with backoff (~0.8s,1.6s,2.4s,3.2s,4s) until the title exists; the AUMID re-register runs+  // after, so Alt-Tab/flyout get the matching icon too.+  let stamped = false;+  for (let i = 0; i < 5 && !stamped; i++) {+    try { stamped = await stampPupIdentity(sessionId); } catch (e) {}+    if (!stamped) await new Promise(r => setTimeout(r, 800 * (i + 1)));+  }+  if (!stamped) console.log(`[identity] "${sessionId}" icon re-stamp FAILED after retries — window title never matched`);   try { await registerPerSessionAumid(`${PUP_APP_ID}.${sessionId}`); } catch (e) {}   return true; }