← Commit history

1.9.0: favicons win the taskbar overlay (active tab), count moves to tooltip

John Lauer ·4b7a541170 · ·parent 747f671
5 files changed +28−17
CHANGELOG.md+8
@@ -1,5 +1,13 @@ # Changelog — Adom Desktop Puppeteer Bridge +## 1.9.0 — 2026-07-19 — Favicons win the overlay (John: more useful than counts)++The taskbar overlay now shows the ACTIVE tab's site favicon for ANY tab count — you always see+what the window is showing (ti.com, mouser, …). The tab count moves to the hover tooltip+("Adom Pup — 3 tabs (icon = active tab)"). Overlay follows tab switches (updates on+browser_switch_tab). Fallback to a plain count badge only when the active page serves no favicon.+Grouped-mode dual counter unchanged.+ ## 1.8.99 — 2026-07-19 — Auth gating is Adom-wide; overlay = site favicon (1 tab) or count (2+)  - Authed treatment now gates on ANY adom.inc host (isAdomUrl), not just wiki.adom.inc — other
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.8.99",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.8.99/adom-bridge-puppeteer-v1.8.99.zip",-  "sha256": "2a95b55eed7caf2b5f79a71e02dfc62ae52e485b187dc554a7252050fe0ba85b",-  "size": 208804,+  "version": "1.9.0",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.0/adom-bridge-puppeteer-v1.9.0.zip",+  "sha256": "f9a56301e389e0591806383dba82aad73d73a1c29f2db08c2c51257513000713",+  "size": 208941,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.8.99\ No newline at end of file+1.9.0\ No newline at end of file
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.8.99",+  "version": "1.9.0",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+14−11
@@ -1780,16 +1780,14 @@ async function updateTabCountBadge(session, sessionId) {       }       return;     }-    // v1.8.99 split-mode overlay RULE (John's question — 3 vendor tabs, one slot, no room to-    // stack): ONE tab → wear THAT site's favicon (you see it's ti.com). TWO+ tabs → show the-    // COUNT (no single favicon represents a multi-site window; the hover tooltip can name them).+    // v1.9.0 split-mode overlay RULE (John: favicons > counts): the OVERLAY is the ACTIVE tab's+    // site favicon, whatever the tab count — you always see what you're looking at. The tab count+    // rides in the hover tooltip. Only if the active page has NO favicon do we fall back to a+    // plain count badge (so a many-tab faviconless window isn't a blank Adom tile).     const count = (session.tabs || []).length;-    if (count === 1) {-      const worn = await applyAppOverlay(session, sessionId); // site favicon on a dark plate-      if (!worn) { try { await chrome.adCommand('desktop_taskbar', { titleContains: `(session: ${sessionId}`, overlay: { badge: 'none' } }, { timeoutMs: 5000 }); } catch (e) {} }-      return;-    }-    session._appOverlay = false; // multi-tab → count wins the slot+    const worn = await applyAppOverlay(session, sessionId); // active tab's favicon + count in tooltip+    if (worn) return;+    session._appOverlay = false;     if (count >= 2) {       const icon = tabBadgeIcon(count);       if (!icon) return;@@ -1917,8 +1915,12 @@ const _appOverlayCache = new Map(); // sessionId -> composited b64 async function applyAppOverlay(session, sessionId) {   if (process.platform !== 'win32' || _identitySupported !== true) return false;   try {+    // v1.9.0: reflect the ACTIVE tab (John: favicons are more useful than counts — show what+    // the user is looking at). Falls back to session.page.+    const activeTab = (session.tabs || []).find(t => t.tabId === session.activeTabId) || (session.tabs || [])[0];+    const activePage = (activeTab && activeTab.page) || session.page;     let src = session._appIconB64 ? { b64: session._appIconB64, mime: session._appIconMime || 'image/png' } : null;-    if (!src) src = await fetchPageFavicon(session.page);+    if (!src) src = await fetchPageFavicon(activePage);     if (!src || !src.b64) { session._appOverlay = false; return false; }     let overlay = _appOverlayCache.get(sessionId + ':' + (src.href || 'explicit'));     if (!overlay) {@@ -1939,7 +1941,7 @@ async function applyAppOverlay(session, sessionId) {     const nm = session._appName ? `${session._appName} — ` : '';     await chrome.adCommand('desktop_taskbar', {       titleContains: `(session: ${sessionId}`,-      overlay: { icon: overlay, tooltip: `Adom Pup — ${nm}${tabs} tab${tabs === 1 ? '' : 's'}` },+      overlay: { icon: overlay, tooltip: `Adom Pup — ${nm}${tabs} tab${tabs === 1 ? '' : 's'}${tabs > 1 ? ' (icon = active tab)' : ''}` },     }, { timeoutMs: 5000 });     session._appOverlay = true;     return true;@@ -4601,6 +4603,7 @@ const server = http.createServer(async (req, res) => {           // (debounced) so the window stays clickable/badged across bridge restarts.           if (process.platform === 'win32') {             healOffscreenWindow(session, sessionId).catch(() => {});+            updateTabCountBadge(session, sessionId).catch(() => {}); // v1.9.0: overlay follows the active tab's favicon             const now = Date.now();             if (!session._badgedAt || now - session._badgedAt > 600000) {               // v1.8.58: only debounce on SUCCESS — a failed badge retries on the next call.