← Commit history

Fixes login capture missing form submits that navigate: capture now fires through a synchronous Puppeteer binding at submit time, reaching the keychain vault BEFORE the navigation wipes the page, with the sweep-harvested global kept only as the fallback for SPA logins that never navigate. Same keychain-only, never-logged storage

John Lauer ·4ae739f042 ·2mo ago ·parent 9fe2840
4 files changed +26−7
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.110",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.110/adom-bridge-puppeteer-v2.0.110.zip",-  "sha256": "e6325ee8c4b17d412ce2c61376eb450912c7b817e8d581ebd0b36c1139c8107b",-  "size": 860685,+  "version": "2.0.111",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.111/adom-bridge-puppeteer-v2.0.111.zip",+  "sha256": "81c5066524677ff550b93b32307507521d6b2efb2af74fb8ea94b344da6d6783",+  "size": 861315,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.110+2.0.111
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.110",+  "version": "2.0.111",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+20−1
@@ -348,7 +348,11 @@ const CAPTURE_LOGIN_JS = `(() => {         var cands = [].slice.call((form || document).querySelectorAll('input[type=text], input[type=tel], input:not([type])')).filter(vis);         user = cands.slice().reverse().filter(function(c){ return all.indexOf(c) < pi; })[0] || cands[0] || null;       }-      window.__pupCapturedLogin = { host: location.hostname, u: user ? user.value : '', p: pwd.value, ts: Date.now() };+      var rec = { host: location.hostname, u: user ? user.value : '', p: pwd.value, ts: Date.now() };+      // Prefer the SYNCHRONOUS binding — it reaches the bridge BEFORE the submit navigates the+      // page away (the global stash below would be wiped by that navigation, missing the capture).+      if (typeof window.__pupCredCapture === 'function') { try { window.__pupCredCapture(JSON.stringify(rec)); } catch (e) {} }+      window.__pupCapturedLogin = rec;   // fallback for SPA logins that never navigate (sweep harvests it)     } catch (e) {}   }   addEventListener('submit', function(e){ grab(e.target && e.target.tagName === 'FORM' ? e.target : null); }, true);@@ -757,6 +761,21 @@ function attachTab(session, sessionId, page, { makeActive = true, opener = 'user     try { page.evaluateOnNewDocument(tjClean).catch(() => {}); page.evaluate(tjClean).catch(() => {}); } catch (e) {}     // v2.0.110: login-capture rail — records credentials as they are submitted so the keychain     // vault grows the adom-you identity automatically (John authorized). Self-guarded, page-local.+    // A synchronous Puppeteer binding stores the cred BEFORE the submit navigates away (a+    // navigation would wipe the page global); the sweep-harvested global is the SPA fallback.+    page.exposeFunction('__pupCredCapture', (json) => {+      (async () => {+        try {+          if (pupSettings().captureLogins === 'off') return;+          const rec = JSON.parse(json || '{}');+          if (!rec.host || !rec.p) return;+          await credentialVault.setCredential({ host: rec.host, username: rec.u || '', password: rec.p });+          console.log(`[cred] captured login for ${rec.host}${rec.u ? ` (${rec.u})` : ''} on "${sessionId}" → keychain vault`);+          const sNow = sessions.get(sessionId);+          if (sNow) sNow._pendingCredHint = `pup CAPTURED this login for "${rec.host}"${rec.u ? ` (username ${rec.u})` : ''} into the OS keychain (encrypted at rest; never logged, never echoed). Next visit auto-fills in the background with no Chrome dropdown and no foregrounding; submitting stays reason-gated. This is how the shared adom-you identity grows — every login you do makes future ones automatic. Manage: pup_credentials {} to list, credential_delete {host} to remove, pup_configure {captureLogins:"off"} to stop.`;+        } catch (e) { console.log(`[cred] binding store failed: ${e.message}`); }+      })();+    }).catch(() => { /* already registered on this page (re-attach) — fine */ });     try { page.evaluateOnNewDocument(CAPTURE_LOGIN_JS).catch(() => {}); page.evaluate(CAPTURE_LOGIN_JS).catch(() => {}); } catch (e) {}   }   try { page.evaluateOnNewDocument(PUP_DEEP_HELPERS).catch(() => {}); } catch (e) {}