← Commit history

v1.9.32: do not filter window-opened events by name, a new window has none yet

John Lauer ·4910a8121e · ·parent e9420d5
5 files changed +24−10
CHANGELOG.md+10
@@ -1,5 +1,15 @@ # Changelog — Adom Desktop Puppeteer Bridge +## 1.9.32 — 2026-07-20 — Fix: the drag-out event was filtered away by its own (empty) name++1.9.31 subscribed to window-opened correctly but filtered the events by window NAME+(/Chrome|Chromium/). A window fires window-opened at CREATION, before its title exists, so the+dragged-out Chrome window arrived with an EMPTY name and the one event that mattered was discarded+(verified in the live ring: the needed event was seq 32, name ""). The filter is gone: any+window-opened triggers the follow-up, which is cheap and idempotent anyway. Also drains on+browser_list_tabs. Confirmed the underlying detection is sound: after John's drag, the dragged tab+reported window origin 335,292 while its siblings shared 0,0.+ ## 1.9.31 — 2026-07-20 — Drag a tab out and it becomes its own pup window (event-driven, no polling)  John dragged a tab out of a pup window: Chrome made a NEW OS window, which carried none of pup's
adom-bridge-puppeteer-manifest.json+5−5
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.31",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.31/adom-bridge-puppeteer-v1.9.31.zip",-  "sha256": "f2395377146273880a71a6ea9dd0cf64ce7e1e249b0d80014f753cbdfba9c852",-  "size": 284949,+  "version": "1.9.32",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.32/adom-bridge-puppeteer-v1.9.32.zip",+  "sha256": "af1606959bc4f0e3f3437049ac84f7ef74c79e264f209524cdc35b9ed49b5966",+  "size": 285115,   "verbPrefixes": [     "browser_",     "desktop_recorder_",@@ -12,5 +12,5 @@   ],   "healthEndpoint": "/status",   "statusVerb": "browser_readiness",-  "released_at": "2026-07-20T14:30:00Z"+  "released_at": "2026-07-20T15:00:00Z" }
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.31\ No newline at end of file+1.9.32\ No newline at end of file
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.31",+  "version": "1.9.32",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+7−3
@@ -2429,9 +2429,12 @@ async function drainWindowOpenedEvents() {     const data = o.data || o;     const evs = data.events || [];     if (typeof data.nextSeq === 'number') _uiWatchSeq = data.nextSeq;-    // Only Chrome-class windows matter (a pup tab drag makes one).-    const chromeWins = evs.filter(e => /Chrome|Chromium/i.test(((e.element || {}).name) || ''));-    if (!chromeWins.length) return;+    // v1.9.32: do NOT filter these events by window NAME. A window fires window-opened at CREATION,+    // before its title exists, so the dragged-out Chrome window arrived with an EMPTY name and the+    // old `/Chrome|Chromium/` filter threw away the one event that mattered (verified live: the+    // needed event was seq 32 with name ""). Any window-opened is enough of a hint; the follow-up+    // check is cheap (one getWindowForTarget per tab, multi-tab sessions only) and idempotent.+    if (!evs.length) return;     for (const [sid] of [...sessions]) { await adoptDraggedOutTabs(sid); }   } catch (e) {} }@@ -5371,6 +5374,7 @@ const server = http.createServer(async (req, res) => {           return;         }         case 'browser_list_tabs': {+          drainWindowOpenedEvents().catch(() => {}); // v1.9.32: cheap event-driven drag-out check           const sessionId = args.sessionId || activeSessionId;           if (!sessionId || !sessions.has(sessionId)) {             sendJSON(res, { success: false, error: `Session "${sessionId}" not found` });