← Commit history

Cut the Thread Tiles button-nudge hide window from 600ms to 80ms: the longer hide made a freshly opened window genuinely invisible for over half a second, which tripped the live-window safety invariant and was a visible flicker, while 80ms still forces the taskbar button rebuild.

John Lauer ·475d7fce14 ·2mo ago ·parent ff01067
4 files changed +14−9
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.174",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.174/adom-bridge-puppeteer-v2.0.174.zip",-  "sha256": "32e3fb8e345ab50729812894991b14ce934e4b6b1262d5d3b595d2c38437ec04",-  "size": 916568,+  "version": "2.0.175",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.175/adom-bridge-puppeteer-v2.0.175.zip",+  "sha256": "9879df972b7689f3bbb97ca220d154bf6d7d3a1cb8eee85cadb1ed3c34a6f84b",+  "size": 916756,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.174+2.0.175
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.174",+  "version": "2.0.175",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+8−3
@@ -4511,8 +4511,13 @@ function pruneStaleAumids() { // AUMID. Win11 (this build, measured) does NOT move a live window to a new button on an AUMID // change; hide + re-show is the only reliable trigger. SW_SHOWNOACTIVATE never steals focus, and // the same script skips the nudge when the window is FOREGROUND (blinking the user's active window-// for 600ms would be disruptive). Fire-and-forget; ~1-2s of powershell incl. Add-Type, once per-// window per thread appId.+// would be disruptive). Fire-and-forget; ~1-2s of powershell incl. Add-Type, once per window per+// thread appId.+// v2.0.175: the hide window is 80ms, NOT 600ms. Measured (churn-ralph round-3 RED + a 200ms+// visibility poll): a 600ms hide made a freshly opened window genuinely invisible for ~600ms, which+// both failed the #46 live-window invariant and was a real flicker on the user's screen. 80ms still+// makes the shell destroy + recreate the button (verified live: a restamped window's button renamed+// to the new thread), so we keep the only effect that matters and drop 87% of the blind spot. let _nudgeUntil = 0;   // v2.0.172: while set, ignore window-opened events caused by our own nudge function nudgeTaskbarButton(hwnd, sessionId) {   if (process.platform !== 'win32' || !hwnd) return;@@ -4523,7 +4528,7 @@ public static class SW {   [DllImport("user32.dll")] public static extern bool ShowWindow(IntPtr h, int cmd);   [DllImport("user32.dll")] public static extern IntPtr GetForegroundWindow(); }-'@; Add-Type -TypeDefinition $s; if([SW]::GetForegroundWindow() -eq [IntPtr]${hwnd}){ 'SKIP-FG' } else { [SW]::ShowWindow([IntPtr]${hwnd},0)|Out-Null; Start-Sleep -Milliseconds 600; [SW]::ShowWindow([IntPtr]${hwnd},4)|Out-Null; 'NUDGED' }`;+'@; Add-Type -TypeDefinition $s; if([SW]::GetForegroundWindow() -eq [IntPtr]${hwnd}){ 'SKIP-FG' } else { [SW]::ShowWindow([IntPtr]${hwnd},0)|Out-Null; Start-Sleep -Milliseconds 80; [SW]::ShowWindow([IntPtr]${hwnd},4)|Out-Null; 'NUDGED' }`;   try {     execFile('powershell', ['-NoProfile', '-Command', ps], { windowsHide: true, timeout: 20000 }, (err, stdout) => {       const r = String(stdout || '').trim();