app
Pup - the AI's own browser
Public Made by Adomby adom
pup gives your AI a real browser on your desktop that it drives completely, in the background, signed in as you: windows that never jump in front of your work, one shared profile that learns your logins, and every window labeled on the taskbar with its AI thread's name.
← Commit history
Fix the taskbar overlay favicons my own 1.9.129 broke (John: 'why is there no overlay icon in windows taskbar right now?'). Measured cause in the log: fetchPageFavicon ran fetch() INSIDE the page, which only ever worked because --disable-web-security had CORS off globally; when 1.9.129 restored the same-origin policy, any favicon whose fetch crosses origins (accounts.google.com redirects /favicon.ico to www.google.com) began CORS-failing and those windows silently lost their overlay. The fix keeps the DOM read in-page (collecting link rel=icon hrefs is CORS-free) and moves the actual fetch into the BRIDGE process, which has no same-origin policy, with redirect-follow, a 4s timeout, and inline data: icons decoded directly. Accepted tradeoff, documented in code: the bridge fetch carries no page cookies, so a favicon behind auth won't resolve (rare; the count-badge fallback covers it); localhost favicons still work because the bridge runs on the same machine as Chrome. Lesson: removing a long-standing global flag means auditing what silently depended on it — the overlay was an undeclared dependent of disabled web security.
4 files changed
+41−23
adom-bridge-puppeteer-manifest.json+4−4@@ -1,10 +1,10 @@ { "manifest_version": 1, "name": "puppeteer",- "version": "1.9.129",- "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.129/adom-bridge-puppeteer-v1.9.129.zip",- "sha256": "71b8eedcee501cb5f4215f8daf3d1c14a107c597e6f08fa5404b4c06e41b6109",- "size": 393397,+ "version": "1.9.130",+ "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.130/adom-bridge-puppeteer-v1.9.130.zip",+ "sha256": "c689d09ae3481799d49b6c27f310947495a18b655d842e49bb7211ef083c070a",+ "size": 393814, "verbPrefixes": [ "browser_", "desktop_recorder_",
src/BRIDGE_VERSION+1−1@@ -1 +1 @@-1.9.129+1.9.130
src/bridge.json+1−1@@ -2,7 +2,7 @@ "manifest_version": 1, "name": "puppeteer", "displayName": "Puppeteer (Chrome for Testing + Native)",- "version": "1.9.129",+ "version": "1.9.130", "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.", "homepage": "https://wiki.adom.inc/adom/adom-desktop", "author": "Adom Inc.",
src/server.js+35−17@@ -3076,27 +3076,45 @@ function wikiViewHint(url, view, auth) { } async function fetchPageFavicon(page) {+ // v1.9.130: collect candidate URLs in-page (a DOM read — CORS-free), but FETCH them from the+ // BRIDGE process. The old in-page fetch() only ever worked because --disable-web-security had+ // CORS off globally; when v1.9.129 restored the same-origin policy, any favicon whose fetch+ // crosses origins (accounts.google.com redirects its /favicon.ico to www.google.com) started+ // CORS-failing and those windows silently lost their overlay — John spotted the missing icon+ // within the hour. Node has no same-origin policy, so a bridge-side fetch cannot regress this.+ // (Tradeoff, accepted: the bridge fetch carries no page cookies, so a favicon behind auth won't+ // resolve — rare, and the count-badge fallback covers it. localhost favicons still work: the+ // bridge runs on the same machine as Chrome.)+ let hrefs = []; try {- return await page.evaluate(async () => {- // v1.9.43: a page can declare a PLACEHOLDER icon (example.com ships <link href="data:,">),- // which fetches "successfully" as an empty blob and killed the whole overlay. Drop obvious- // junk before trying, and always keep /favicon.ico as the last resort.+ hrefs = await page.evaluate(() => {+ // v1.9.43: a page can declare a PLACEHOLDER icon (example.com ships <link href="data:,">) —+ // drop obvious junk, always keep /favicon.ico as the last resort. const links = Array.from(document.querySelectorAll('link[rel~="icon"], link[rel="shortcut icon"], link[rel="apple-touch-icon"]'));- const hrefs = links.map(l => l.href).filter(h => h && h !== 'data:,' && !/^data:,?$/.test(h));- hrefs.push(new URL('/favicon.ico', location.origin).href);- for (const href of hrefs) {- try {- const r = await fetch(href, { cache: 'force-cache' });- if (!r.ok) continue;- const blob = await r.blob();- if (!blob.size) continue;- const b64 = await new Promise((res, rej) => { const fr = new FileReader(); fr.onload = () => res(fr.result.split(',')[1]); fr.onerror = rej; fr.readAsDataURL(blob); });- return { b64, mime: blob.type || '', href };- } catch (e) {}- }- return null;+ const out = links.map(l => l.href).filter(h => h && h !== 'data:,' && !/^data:,?$/.test(h));+ out.push(new URL('/favicon.ico', location.origin).href);+ return out; }); } catch (e) { return null; }+ for (const href of (hrefs || [])) {+ try {+ if (href.startsWith('data:')) {+ // Inline icon — decode directly, nothing to fetch.+ const m = href.match(/^data:([^;,]*)(;base64)?,(.*)$/);+ if (m && m[3]) {+ const b64 = m[2] ? m[3] : Buffer.from(decodeURIComponent(m[3])).toString('base64');+ if (b64) return { b64, mime: m[1] || 'image/png', href: 'data:inline' };+ }+ continue;+ }+ const r = await fetch(href, { redirect: 'follow', signal: AbortSignal.timeout(4000) });+ if (!r || !r.ok) continue;+ const buf = Buffer.from(await r.arrayBuffer());+ if (!buf.length) continue;+ return { b64: buf.toString('base64'), mime: r.headers.get('content-type') || '', href };+ } catch (e) {}+ }+ return null; } const _appOverlayCache = new Map(); // sessionId -> composited b64 async function applyAppOverlay(session, sessionId) {