← Commit history

Settings truth + defaults round (three John callouts in a row). (1) Example images cache-busted (no-store + ?v=PAGE_VERSION): the settings dialog was showing the OLD mockup jump-list image after the real screenshot shipped because /dashboard/example served max-age=600 on an unchanged URL - the exact favicon-cache lesson from 1.9.242, relearned on a new endpoint. (2) autoFlash (taskbar flash on agent activity) defaults ON per John, with the choice-marker system generalized: every dialog change now records _chosen[key] so no future default migration ever stomps a real user decision. (3) autoLogin displayed as an OFF toggle while the behavior was ON - legacy keys (autoLogin, reportIssues, agentActivity) had no explicit stored default and the dialog rendered unset as off, a display lie; they now get explicit 'on' defaults matching their real behavior, and autoLogin migrates a non-chosen 'off' to on per John.

John Lauer ·2de79586b7 ·2mo ago ·parent fd436fa
4 files changed +20−10
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.267",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.267/adom-bridge-puppeteer-v1.9.267.zip",-  "sha256": "c7de74562d577ec2e53d576e03598d4ce5eaaacc696b8adb72eac4a6e888a331",-  "size": 614406,+  "version": "1.9.268",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.268/adom-bridge-puppeteer-v1.9.268.zip",+  "sha256": "2f21309f5c56e3b64aef380cd7a24174adfe272571a7097814d5813c0022b55f",+  "size": 614644,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.267+1.9.268
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.267",+  "version": "1.9.268",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+14−4
@@ -2714,6 +2714,15 @@ function pupSettings() {               aumidIconStyle: 'standard' };   D.openFlash = 'on';   // v1.9.262 (John: "why did you default it to off when its defaulted to on")   if (_pupSettings.openFlash === 'off' && !_pupSettings._openFlashChosen) _pupSettings.openFlash = 'on';+  // v1.9.268 (John on autoFlash: "this should be on by default")+  D.autoFlash = 'on';+  const chosen = _pupSettings._chosen || {};+  if (_pupSettings.autoFlash === 'off' && !chosen.autoFlash) _pupSettings.autoFlash = 'on';+  // v1.9.268 (John on autoLogin: "this should be on by default" - and it always WAS behavior-default+  // on via the !== 'off' checks, but the dialog rendered the unset key as an OFF toggle: a display+  // lie). Legacy keys get explicit defaults so the dialog reflects actual behavior.+  D.autoLogin = 'on'; D.reportIssues = 'on'; D.agentActivity = 'on';+  if (_pupSettings.autoLogin === 'off' && !chosen.autoLogin) _pupSettings.autoLogin = 'on';   // v1.9.260 (John: "2s feels too fast cuz i can't read"): readable default. A stored 2000 was the   // old default, not a choice made in the dialog (it shipped hours ago) - migrate it up once.   if (D.fgCaptionMs) D.fgCaptionMs = 3500;@@ -8559,7 +8568,7 @@ function renderDlg(){   const st=(SNAP&&SNAP.bridge&&SNAP.bridge.settings)||{};   _q('#dlgBody').innerHTML=SETTINGS_DEF.map(def=>{     const _imgName=def.imgBy?def.imgBy[st[def.k]]||def.imgBy[Object.keys(def.imgBy)[0]]:def.img;-    const exImg=_imgName?'<img class="sexample" src="/dashboard/example?n='+_imgName+'" alt="example" data-fallback="hide">':'';+    const exImg=_imgName?'<img class="sexample" src="/dashboard/example?n='+_imgName+'&v='+PAGE_VERSION+'" alt="example" data-fallback="hide">':'';     if(def.slider){       const on=st[def.dep]==='on';       const v=Number(st[def.k])||3500;@@ -8602,7 +8611,7 @@ document.addEventListener('change',ev=>{   const sl=ev.target.closest('[data-sel]');   if(sl){     const def=SETTINGS_DEF.find(d=>d.k===sl.dataset.sel);-    if(def&&def.imgBy){const im=sl.closest('.sub').querySelector('.sexample');if(im)im.src='/dashboard/example?n='+def.imgBy[sl.value];}+    if(def&&def.imgBy){const im=sl.closest('.sub').querySelector('.sexample');if(im)im.src='/dashboard/example?n='+def.imgBy[sl.value]+'&v='+PAGE_VERSION;}     setSetting(sl.dataset.sel,sl.value);   } });@@ -8755,7 +8764,8 @@ const server = http.createServer(async (req, res) => {           } else if (!ALLOWED[key] || !ALLOWED[key].includes(val)) {             return done({ ok: false, error: 'unknown setting or value' });           }-          savePupSettings(key === 'openFlash' ? { [key]: val, _openFlashChosen: true } : { [key]: val });+          const _ch = { ...(pupSettings()._chosen || {}), [key]: true };+          savePupSettings(key === 'openFlash' ? { [key]: val, _openFlashChosen: true, _chosen: _ch } : { [key]: val, _chosen: _ch });           console.log(`[settings] "${key}" -> ${val} (dashboard dialog)`);           return done({ ok: true, settings: pupSettings() });         }@@ -8876,7 +8886,7 @@ const server = http.createServer(async (req, res) => {         const nm = (url.searchParams.get('n') || '').replace(/[^a-z]/g, '');         const f = path.join(__dirname, 'icons', 'settings-ex', nm + '.png');         const buf = fs.readFileSync(f);-        res.writeHead(200, { 'Content-Type': 'image/png', 'Cache-Control': 'public, max-age=600' });+        res.writeHead(200, { 'Content-Type': 'image/png', 'Cache-Control': 'no-store' });         res.end(buf); return;       } catch (e) { res.writeHead(404); res.end(); return; }     }