← Commit history

Thread Tiles: restore the favicon overlay badge on thread tile buttons; the earlier suppression was a misdiagnosis of the stale icon-handle bug fixed in 2.0.166, and the corner badge leaves the name readable.

John Lauer ·2c895f5202 ·2mo ago ·parent d476a5c
4 files changed +11−10
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.166",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.166/adom-bridge-puppeteer-v2.0.166.zip",-  "sha256": "1620cff0d81c3b487d0f85c5feec907e5ca996521777b1199c0be03b2bd96c5f",-  "size": 910387,+  "version": "2.0.167",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.167/adom-bridge-puppeteer-v2.0.167.zip",+  "sha256": "8a3f7a8139c587676a5fde82eea83b4b1d87ff073acf2fe957aacd6166ec742d",+  "size": 910448,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.166+2.0.167
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.166",+  "version": "2.0.167",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+5−4
@@ -5622,10 +5622,11 @@ async function applyAppOverlay(session, sessionId) {   // stamps NO identity and rebuilds NO jump list, but it DOES wear one composed badge per window.   if (process.platform !== 'win32' || _identitySupported !== true) return false;   if (pupSettings().overlayBadges !== 'on') return false;   // v1.9.259 user pref-  // v2.0.159 THREAD TILES: the thread NAME tile IS the identity — do NOT paint a per-window favicon-  // badge over it (it covered the name), and a grouped thread button has many windows anyway, so a-  // single favicon would be arbitrary. Suppress the overlay for windows on a thread AUMID.-  if (pupSettings().threadTiles === 'on' && (session && (session.owner || session._ownerThread))) return false;+  // v2.0.167 (John: "i don't see an overlay icon though, so that's sad"): thread tiles DO wear the+  // favicon overlay badge after all. The 2.0.159 suppression was a misdiagnosis — the "globe covering+  // the tile" was the stale category BUTTON ART (the ab icon-handle cache bug, fixed in 2.0.166), not+  // the overlay. The overlay is a small corner badge; the name stays readable. On a grouped thread+  // button Windows shows the overlay of the most recently updated window in the group — acceptable.   // v1.9.281 THE RESURRECTION GUARD (found by ralph: a reaped session's badge kept reappearing).   // applyAppOverlay is reached from several deferred setTimeout retries (favicon retry, post-nav,   // heal) that CAPTURE the session object. If the window closed in the meantime, those late calls