← Commit history

THE reason ten badge revisions never appeared: the composite was memo-cached on a key that did NOT include the bridge build. The first image built for a given (session, favicon-href) pair was cached forever, so every later run hit the cache, logged success with no errors, returned the OLD bytes, and the taskbar never changed regardless of what the compositor code did. That is precisely the symptom John reported over and over — 'the code runs, no errors, and icon 1 still shows nothing' — and it silently invalidated EVERY badge fix from 1.9.203 onward, including the Chrome-style generic globe and the generic PDF datasheet icon, which were being built correctly and then discarded in favour of a stale cached image. The cache key now includes BRIDGE_VERSION, so any new build rebuilds its badges. This also means my intermediate diagnoses (SVG cannot rasterise, the code is not running, duplicate sessions are the blocker) were wrong: the compositor was fine, the delivery was fine, the CACHE was serving history.

John Lauer ·2be3865f55 ·3mo ago ·parent 771a2bd
4 files changed +14−7
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.213",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.213/adom-bridge-puppeteer-v1.9.213.zip",-  "sha256": "484ba24b648075ce9ccb475002881a92a484c9f0c3cbabdd6cc3a00f30195336",-  "size": 440741,+  "version": "1.9.214",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.214/adom-bridge-puppeteer-v1.9.214.zip",+  "sha256": "3acdafa9f84fdfd55ed64809bf1c58604b768d0db82fc5ce08bd42c50ffde31d",+  "size": 441006,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.213+1.9.214
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.213",+  "version": "1.9.214",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+8−1
@@ -3995,7 +3995,14 @@ async function applyAppOverlay(session, sessionId) {     // off-law colour signal. The favicon keeps this slot untouched, which is the whole point of it.     const plateAuthed = false;     const plateFill = '#0b2325';-    const cacheKey = sessionId + ':' + (src.href || 'explicit') + ':' + (plateAuthed ? 'auth' : 'plain');+    // v1.9.214 — THE REASON TEN REVISIONS NEVER APPEARED. This composite is memo-cached, and the key+    // did NOT include the bridge build. So the FIRST image built for a given (session, favicon-href)+    // was cached forever: every later run hit the cache, logged success, returned the OLD bytes, and+    // the taskbar never changed no matter what the compositor code now did. That is exactly the+    // symptom John kept reporting — "the code runs, no errors, and the icon is still wrong" — and it+    // silently invalidated every badge fix from 1.9.203 onward, including the generic globe / PDF+    // icons. Keying on BRIDGE_VERSION makes any new build rebuild its badges.+    const cacheKey = BRIDGE_VERSION + ':' + sessionId + ':' + (src.href || 'explicit') + ':' + (plateAuthed ? 'auth' : 'plain');     let overlay = _appOverlayCache.get(cacheKey);     if (!overlay) {       let sharpMod = null;