← Commit history

Jump-list attachment is now gated on AUMID icons being on: in plain mode no window wears a pup identity, yet every window birth was silently registering a bare per-session AUMID registry key purely to have something to commit a jump list to, which the mode-aware selftest caught as a strip hole.

John Lauer ·2969cec135 ·2mo ago ·parent 72a2d0b
4 files changed +11−6
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.219",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.219/adom-bridge-puppeteer-v2.0.219.zip",-  "sha256": "96265fa0289d561587cab7ea3ee0a296314ac85bfa03d4d8f2af0627ccbadf7e",-  "size": 940786,+  "version": "2.0.220",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.220/adom-bridge-puppeteer-v2.0.220.zip",+  "sha256": "387667370a80416d33986ea2d4ddc3d9eceb8346b65a3ba94588efa665bded2a",+  "size": 940945,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.219+2.0.220
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.219",+  "version": "2.0.220",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+5
@@ -4873,6 +4873,11 @@ async function updateWikiJumplist(session, sessionId, opts) {   // pref now IS the user's choice and wins) and the grouped exclusion (under grouped, commit with   // last-writer-wins semantics, exactly how overlay badges already behave on a shared button).   if (pupSettings().jumpLists !== 'on') return;+  // v2.0.220 (T5's honest fail in plain mode): a jump list can only attach to a pup AUMID, and in+  // plain mode no window wears one — yet this path still registered a bare Adom.Pup.<sid> registry+  // key per window birth (the fallback id below) purely so it had something to commit to. Plain+  // means plain: no pup AUMIDs, no pup jump lists (the stock Chrome button keeps Chrome's own menu).+  if (pupSettings().aumidIcons !== 'on') return;   if (process.platform !== 'win32' || _identitySupported !== true || _jumplistSupported === false) return;   if (!session) return;   // v1.9.61: callers may pass the appId EXPLICITLY. stampPupIdentity brands the header BEFORE it