← Commit history

v2.0.359: Tell a session when the bridge restarted underneath it (issue #80): recovery and adoption now attach a targeted notice to the affected session, delivered on its own next verb, plus a broadcast for threads whose session id no longer exists. Tabs regrouped by a restart no longer look like pup closing them silently.

John Lauer ·27ba25d034 ·2mo ago ·parent 1300d41
5 files changed +53−9
adom-bridge-puppeteer-manifest.json+5−5
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.358",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.358/adom-bridge-puppeteer-v2.0.358.zip",-  "sha256": "49c098174e496d231ebb2d14985e63ffc22d145992884e6ca825ad36f589612e",-  "size": 1527745,+  "version": "2.0.359",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.359/adom-bridge-puppeteer-v2.0.359.zip",+  "sha256": "0d338c53deaee32004f10cc96b290d6ec142db67cc1259ddcad1a89cb178fd0a",+  "size": 1528884,   "verbPrefixes": [     "browser_",     "desktop_recorder_",@@ -12,5 +12,5 @@   ],   "healthEndpoint": "/status",   "statusVerb": "browser_readiness",-  "released_at": "2026-08-27T14:41:00.997587Z"+  "released_at": "2026-08-27T15:53:29.568238Z" }
package.json+1−1
@@ -1,6 +1,6 @@ {   "slug": "pup-bridge",-  "version": "2.0.358",+  "version": "2.0.359",   "type": "app",   "description": "The pup SKILL PACK \u2014 the AI skills that teach a cloud/container AI how to drive the Adom Desktop Puppeteer (pup) bridge (browser_* verbs): the everyday `pup` skill plus focused sub-skills for windows/sessions/tabs, screenshots+recording, browsers+Chrome install, and driving the Adom wiki. Installs into ~/.claude/skills + ~/.codex/skills. DOCS ONLY \u2014 this is NOT the bridge runtime. The bridge itself (the Node program that drives the browser) runs on the DESKTOP: Adom Desktop bundles it and auto-installs/updates it, and it's published separately on the Releases tab as adom-bridge-puppeteer-v<ver>.zip. The pkg version is kept in lockstep with the Release version so the page's max version row always carries BOTH a pkg tarball (skills) and a runtime zip (bridge) \u2014 a skills-only or runtime-only bump on the top row breaks constraint installs. TL;DR: pkg install = the skills for your AI; the bridge = the Release zip, which Adom Desktop manages for you.",   "keywords": [
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.358\ No newline at end of file+2.0.359\ No newline at end of file
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.358",+  "version": "2.0.359",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+45−1
@@ -654,6 +654,28 @@ const _sessionOwnerClaims = new Map();   // sessionId -> owner string // whichever one happens to call next, which is usually NOT the thread whose window was cleaned — that is // accepted by design: it may be irrelevant to that caller and it can ignore it, but it reaches the user // eventually, which beats never surfacing at all. Capped so a storm cannot bloat a response.+// v2.0.359 (issue #80). A PER-SESSION notice, because the janitor queue above is a BROADCAST and+// this case needs the opposite. When the bridge is upgraded or restarted, pup re-adopts the windows+// underneath every live session, and tabs can end up regrouped into a different session than the+// one that opened them. The thread that opened them sees tabs vanish with no close call and no+// error: it looks like pup lost their work. That is what happened to the "fort worth" thread while+// I was installing three builds in a row, and their report (#80) correctly said the fix is not to+// stop restarting but to TELL the affected session.+//+// Broadcast is wrong here: drainCleanupReports hands the message to whichever thread calls NEXT,+// which is usually not the thread that was affected. This attaches the notice to the session it+// happened to, and clears it once that session's own next verb carries it.+function noteSessionDisruption(session, msg) {+  try { if (session && msg) session._disruptionNotice = String(msg).slice(0, 300); } catch (e) {}+}+function drainSessionNotice(session) {+  try {+    if (!session || !session._disruptionNotice) return null;+    const m = session._disruptionNotice;+    session._disruptionNotice = null;+    return m;+  } catch (e) { return null; }+} const _cleanupReports = []; const CLEANUP_REPORT_MAX = 12; function recordCleanup(msg) {@@ -2491,6 +2513,10 @@ async function recoverSessions() {         // Re-writing it here is idempotent and costs one in-process SetProp, and it means a machine         // carrying untagged windows heals on its next restart rather than staying unresolvable.         tagWindowSession(Number(sf._hwnd), sessionId).catch(() => {});+        // #80: tell this session it went through a restart, and how many tabs came back, so a+        // thread that opened three and finds one knows WHY rather than concluding pup ate them.+        const _tabsBack = (session.tabs || []).length;+        noteSessionDisruption(session, `pup's bridge restarted (upgrade or respawn) and this window was recovered. ${_tabsBack} tab(s) came back. If you opened more than that, the missing ones were regrouped rather than closed: re-open them and they will stick. pup did not close anything.`);       }       // v1.9.202 (John's icon audit): a recovered window came back with NO taskbar badge. Under       // minimalTouch the overlay is applied only on OPEN and NAVIGATE, and the re-stamp sweeps that@@ -9149,6 +9175,10 @@ async function reclaimUnmanagedWindows() {             ns._hwnd = Number(_hit.hwnd);             await tagWindowSession(_hit.hwnd, newId);             console.log(`[reclaim] "${newId}": tagged OS window ${_hit.hwnd} so it stays resolvable (was untagged: adopted windows never went through birth)`);+            // #80: an adopted window is one pup found unowned. Whichever thread it USED to belong to+            // is not addressable any more, so the notice goes on the new session and the janitor+            // queue carries the broadcast, because the original owner cannot be reached by name.+            noteSessionDisruption(ns, `pup adopted this window after a restart: it was running but no session owned it. Its original AI thread, if any, has lost its handle to it and must re-open. Nothing was closed.`);           } else {             console.log(`[reclaim] "${newId}": could not find its OS window by title — it will stay untagged and unresolvable until a later resolve succeeds`);           }@@ -9185,7 +9215,12 @@ async function reclaimUnmanagedWindows() {       }     }   } catch (e) { console.log(`[reclaim] threw: ${e.message}`); }-  if (reclaimed) console.log(`[reclaim] adopted ${reclaimed} previously-unbranded window(s)`);+  if (reclaimed) {+    console.log(`[reclaim] adopted ${reclaimed} previously-unbranded window(s)`);+    // #80: the broadcast half. A thread whose session vanished cannot be told directly (its id is+    // gone), so the janitor queue is the only channel that reaches anyone at all.+    recordCleanup(`adopted ${reclaimed} window(s) that were running with no owning session, usually after a bridge upgrade. If a thread is missing tabs it opened, they were regrouped rather than closed — re-open and they will stick.`);+  }   return reclaimed; } // Drain the window-opened ring; a new window means SOME session may have lost a tab. Cheap: one@@ -12022,6 +12057,15 @@ function maybeAttachBugInvite(obj, verb) {         if (rep) obj._cleanupReport = rep;       }     } catch (e) {}+    // #80: the TARGETED notice, delivered to the session it actually happened to.+    try {+      if (!isProbe && obj._sessionNotice === undefined) {+        const _sid = obj.sessionId || obj.window || (typeof args !== 'undefined' && args && (args.sessionId || args.window));+        const _s = _sid && sessions.get(_sid);+        const _n = _s && drainSessionNotice(_s);+        if (_n) obj._sessionNotice = _n;+      }+    } catch (e) {}     const isError = obj.success === false || !!obj.errorCode || (!!obj.error && obj.error !== '');     // A FAILURE always earns the invitation, even on a probe — that is the highest-value moment.     if (isError) { obj._reportIssues = bugReportInvite(true); return; }