← Commit history

v2.0.279: Deterministic identity: tag confirmed handles via _ensureWindowTagged at every resolution chokepoint (bestSessionHwnd short-circuit + resolver cached/birth/property branches), guarded to fire once per handle. Fixes tags never being written because bestSessionHwnd short-circuited before the resolver.

John Lauer ·26f413ec72 ·2mo ago ·parent ac22509
4 files changed +26−12
adom-bridge-puppeteer-manifest.json+5−5
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.278",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.278/adom-bridge-puppeteer-v2.0.278.zip",-  "sha256": "776ed336dfcaa716d8dbaef053ac8dca645eed26e11667035a8c6830f8829092",-  "size": 967290,+  "version": "2.0.279",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.279/adom-bridge-puppeteer-v2.0.279.zip",+  "sha256": "025f4cf6d9b4ae17882cc56408a23a3c834a382e6efd956ced94a35138fcf2e4",+  "size": 967695,   "verbPrefixes": [     "browser_",     "desktop_recorder_",@@ -12,5 +12,5 @@   ],   "healthEndpoint": "/status",   "statusVerb": "browser_readiness",-  "released_at": "2026-08-22T18:46:23.915405Z"+  "released_at": "2026-08-22T18:51:58.347524Z" }
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.278\ No newline at end of file+2.0.279\ No newline at end of file
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.278",+  "version": "2.0.279",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+19−5
@@ -8071,7 +8071,7 @@ async function resolveSessionHwndByBounds(session, sessionId) {     // v1.9.278: NEVER trust a cached hwnd blind - validate it still belongs to pup before reuse     // (a dead/recycled handle now owned by Edge is exactly how the Edge overlay happened).     if (session._hwnd) {-      if (await hwndBelongsToPup(session._hwnd, session)) { session._hwndFailStreak = 0; session._hwndBackoffUntil = 0; console.log(`[hwnd] "${sessionId}" cached/persisted handle ${session._hwnd} VALIDATED (continuity)`); return Number(session._hwnd); }+      if (await hwndBelongsToPup(session._hwnd, session)) { session._hwndFailStreak = 0; session._hwndBackoffUntil = 0; _ensureWindowTagged(session, sessionId, Number(session._hwnd)); console.log(`[hwnd] "${sessionId}" cached/persisted handle ${session._hwnd} VALIDATED (continuity)`); return Number(session._hwnd); }       console.log(`[hwnd] "${sessionId}" cached hwnd ${session._hwnd} is stale/foreign — discarding and re-resolving`);       session._hwnd = null;     }@@ -8089,8 +8089,8 @@ async function resolveSessionHwndByBounds(session, sessionId) {       } else if (bh && await hwndBelongsToPup(Number(bh), session)) {         session._hwnd = Number(bh); persistSessionHwnd(sessionId, Number(bh));         // DETERMINISTIC IDENTITY: tag the window with its sessionId so it stays re-findable after-        // any future handle loss (dev-skills/pup-no-wiggle). Fire-and-forget; off the hot path.-        tagWindowSession(Number(bh), sessionId).catch(() => {});+        // any future handle loss (dev-skills/pup-no-wiggle). Guarded: tags once per handle.+        _ensureWindowTagged(session, sessionId, Number(bh));         console.log(`[hwnd] "${sessionId}" resolved OS handle ${bh} — birth-time capture (off-screen at creation)`);         return Number(bh);       }@@ -8106,6 +8106,7 @@ async function resolveSessionHwndByBounds(session, sessionId) {       if (_ph && !hwndOwnedByOtherSession(Number(_ph), sessionId) && await hwndBelongsToPup(Number(_ph), session)) {         session._hwnd = Number(_ph); persistSessionHwnd(sessionId, Number(_ph));         session._hwndFailStreak = 0; session._hwndBackoffUntil = 0;+        session._taggedHwnd = Number(_ph);   // resolved BY the tag, so it is already tagged         try { const p0b = (session.tabs || [])[0]; if (p0b && p0b.page) p0b.page.__pupHwnd = Number(_ph); } catch (e) {}         console.log(`[hwnd] "${sessionId}" resolved OS handle ${_ph} by WINDOW-PROPERTY tag (deterministic; no geometry, no wiggle)`);         return Number(_ph);@@ -8558,11 +8559,24 @@ function birthHwnd(session) {   } catch (e) {}   return null; }+// Tag a confirmed (session, hwnd) with its durable "AdomPupSid=<sid>" window property, exactly ONCE+// per handle (dev-skills/pup-no-wiggle). The guard avoids spawning a SetProp PowerShell on every+// resolve — it fires only when a handle is newly confirmed for a session, which is exactly when the+// durable tag must be (re)written so the window stays re-findable after any future handle loss.+function _ensureWindowTagged(session, sessionId, hwnd) {+  if (!session || !hwnd || !sessionId) return;+  if (Number(session._taggedHwnd) === Number(hwnd)) return;+  session._taggedHwnd = Number(hwnd);+  tagWindowSession(Number(hwnd), sessionId).then(ok => {+    if (ok) console.log(`[identity] "${sessionId}" tagged window ${hwnd} with ${PUP_WIN_PROP} (durable; survives crash/restart, re-found by property lookup)`);+    else session._taggedHwnd = null;   // let a later resolve retry the tag+  }).catch(() => { session._taggedHwnd = null; });+} async function bestSessionHwnd(session, sessionId) {   if (!session) return null;-  if (session._hwnd) return Number(session._hwnd);+  if (session._hwnd) { _ensureWindowTagged(session, sessionId, Number(session._hwnd)); return Number(session._hwnd); }   const b = birthHwnd(session);-  if (b) { session._hwnd = b; return b; }+  if (b) { session._hwnd = b; _ensureWindowTagged(session, sessionId, b); return b; }   try { const r = await resolveSessionHwndByBounds(session, sessionId); if (r) return Number(r); } catch (e) {}   return null; }