Pup - the AI's own browser

@@ -477,10 +477,30 @@ function scheduleCategoryRecheck(sessionId) {   }, 1500)); } +// Make a pup-driven tab IMMUNE to debugger pauses. A page's `debugger;` statement (or a stray+// breakpoint) only pauses when the Debugger domain is enabled — but when it IS enabled (by a stale+// CDP client, a previously-opened DevTools, whatever), a single `debugger;` FREEZES the renderer,+// and because sibling tabs share the process the freeze locks the WHOLE window. John hit exactly+// this: the "Debugger paused in another tab" banner appeared and the wiki 3D viewer stopped+// responding. pup drives via CDP for AUTOMATION, never to debug page code, so it must never honor a+// pause. We enable Debugger, tell V8 to skip ALL pauses, and resume anything already frozen — then+// keep the session attached so the skip stays in force for this tab's whole life.+async function neutralizeDebugger(page) {+  try {+    const cdp = await page.target().createCDPSession();+    await cdp.send('Debugger.enable').catch(() => {});+    await cdp.send('Debugger.setSkipAllPauses', { skip: true }).catch(() => {});+    await cdp.send('Debugger.resume').catch(() => {}); // clears a pause already freezing the window+    try { page.__pupDbgCdp = cdp; } catch (e) {} // keep a ref so the session (and the skip) survive+  } catch (e) {}+}+ function attachTab(session, sessionId, page, { makeActive = true, opener = 'user', openerTabId = null } = {}) {   const tabId = nextTabId(session);   const errors = [];   setupErrorCollection(page, errors);+  // Immunize this tab against debugger-statement / breakpoint freezes (see neutralizeDebugger).+  neutralizeDebugger(page);   // v1.9.78 — SURVIVE A RENDERER CRASH (wiki issue #16). Under many heavy-SPA tabs plus rapid   // navigate/eval/screenshot churn, one tab's renderer can crash (Chrome's per-tab 'Aw, Snap').   // puppeteer surfaces that as the page 'error' event; we mark the tab so every verb FAST-FAILS@@ -653,6 +673,8 @@ function attachTab(session, sessionId, page, { makeActive = true, opener = 'user     page.on('framenavigated', (frame) => {       try { if (frame !== page.mainFrame()) return; } catch (e) { return; }       scheduleCategoryRecheck(sessionId);+      // New URL → give favicon detection a fresh start: a page that had none may now have one.+      try { session._overlayGenericFinal = false; session._overlayGenericTries = 0; } catch (e) {}       // v1.9.324 (John: "EVERY verb OR EVENT that could change an icon MUST trigger a recalc").       // The favicon OVERLAY badge was only recomputed by explicit MUTATING_VERBS. Any navigation       // pup did not itself initiate — a JS redirect, a <meta> refresh, a form submit, an SPA route@@ -4912,10 +4934,26 @@ async function applyAppOverlay(session, sessionId) {       console.log(`[overlay] "${sessionId}" REFUSED to paint — no pup-owned hwnd confirmed (protecting non-pup taskbar buttons like Edge)`);       return false;     }+    const _tooltip = `Adom Pup — ${nm}${plateAuthed ? 'Adom wiki: SIGNED IN · ' : ''}${tabs} tab${tabs === 1 ? '' : 's'}${tabs > 1 ? ' (icon = active tab)' : ''}`;+    // DEDUP THE PAINT (John: "why are you sending overlay icons non-stop? every second? that's insane").+    // desktop_taskbar is a PowerShell round-trip on the user's desktop; re-sending an IDENTICAL overlay+    // is pure churn that spams AD's activity log and needlessly re-hits the taskbar. applyAppOverlay is+    // RE-RUN constantly and legitimately — the 4s enforcer sweep re-checks bare/generic windows, and a+    // framenavigated fires on every SPA route/redirect — but if the composed icon + tooltip + target are+    // unchanged since the last SUCCESSFUL paint, there is nothing to send. The signature includes the+    // appId so a base-tile RE-STAMP (which recreates the button and drops its overlay) still forces a+    // repaint, and the hwnd so a re-resolved handle repaints. Same rule as jump-list dedup: one commit+    // per real change, never a heartbeat.+    const _paintSig = `${session._hwnd}|${session._curAppId || ''}|${_tooltip}|${overlay}`;+    if (session._lastPaintSig === _paintSig) {+      session._appOverlay = true; // identical overlay already on the button — skip the AD round-trip+      return true;+    }     await chrome.adCommand('desktop_taskbar', {       hwnd: session._hwnd,-      overlay: { icon: overlay, tooltip: `Adom Pup — ${nm}${plateAuthed ? 'Adom wiki: SIGNED IN · ' : ''}${tabs} tab${tabs === 1 ? '' : 's'}${tabs > 1 ? ' (icon = active tab)' : ''}` },+      overlay: { icon: overlay, tooltip: _tooltip },     }, { timeoutMs: 5000 });+    session._lastPaintSig = _paintSig;     session._appOverlay = true;     // v1.9.150 (John: 'prove what overlay icon you're showing and why'): record the WHAT and WHY     // so list_windows can report it and test tables can prove it.@@ -14158,7 +14196,12 @@ server.listen(PORT, BIND_HOST, async () => {         }         if (pupSettings().overlayBadges !== 'on') continue;         const bare = !s2._appOverlay;-        const stuckGeneric = s2._appOverlay && s2._overlayIsGeneric;+        // A window whose page genuinely has NO favicon anywhere sits on the generic glyph forever, and+        // the enforcer would re-fetch + re-compose it every 10s for the life of the window (John saw the+        // churn in AD's log). Once we've re-attempted the upgrade a few times and the page STILL has no+        // favicon, accept the generic glyph as final and stop re-enforcing — until the tab NAVIGATES,+        // which clears the flag (framenavigated) so a new URL gets fresh upgrade attempts.+        const stuckGeneric = s2._appOverlay && s2._overlayIsGeneric && !s2._overlayGenericFinal;         if (!bare && !stuckGeneric) continue;         const last = s2._overlayEnforceAt || 0;         // v1.9.329: a bare window is now a VISIBLE hole (the notch), so recover it fast — 4s, not 20s.@@ -14172,7 +14215,11 @@ server.listen(PORT, BIND_HOST, async () => {         const wasGeneric = stuckGeneric;         applyAppOverlay(s2, sid2).then(okp => {           if (!okp) return;-          if (wasGeneric && !s2._overlayIsGeneric) console.log(`[overlay] "${sid2}" UPGRADED generic → real favicon (enforcer re-fetched it)`);+          if (wasGeneric && !s2._overlayIsGeneric) { s2._overlayGenericTries = 0; console.log(`[overlay] "${sid2}" UPGRADED generic → real favicon (enforcer re-fetched it)`); }+          else if (wasGeneric && s2._overlayIsGeneric) {+            s2._overlayGenericTries = (s2._overlayGenericTries || 0) + 1;+            if (s2._overlayGenericTries >= 3) { s2._overlayGenericFinal = true; console.log(`[overlay] "${sid2}" still has no favicon after 3 upgrade attempts — accepting generic glyph as final; will retry on next navigation`); }+          }           else if (bare) console.log(`[overlay] "${sid2}" ENFORCED (was bare) — every pup window must wear its overlay`);         }).catch(() => {});       }