Pup - the AI's own browser

@@ -853,6 +853,19 @@ async function decryptBrowserCreds(argsObj) {   }   return last; }+// ANY pending dialog, anywhere (v2.0.353). John, watching it happen: "it stops my other pup windows+// from even foregrounding so i get stuck on all pup windows cuz of one lame javascript alert dialog+// box." He is right, and it changes the shape of this: pup's windows share ONE Chrome for the+// adom-you profile, so a modal does not block its own window, it blocks the BROWSER. The window+// holding the dialog is therefore usually NOT the window whose verb just failed, and scanning only+// the caller's session finds nothing while every window is stuck.+function findAnyPendingDialog() {+  for (const [sid, session] of sessions) {+    const d = findPendingDialog(session);+    if (d) return { ...d, sessionId: sid };+  }+  return null;+} // The one pending native dialog on a session, if any. A modal blocks the WHOLE window, so it does // not matter which tab owns it: the first one found is the one the caller is stuck behind. function findPendingDialog(session) {@@ -18767,7 +18780,11 @@ const server = http.createServer(async (req, res) => {           let session, resolvedId;           try { ({ session, resolvedId } = await recoverOrRelaunchSession(args)); }           catch (e) { sendSessionResolveError(res, e); return; }-          const pending = findPendingDialog(session);+          // Fall back to whatever window actually holds it: a modal blocks the whole browser, so the+          // caller commonly targets the window they were driving rather than the one that raised it.+          let pending = findPendingDialog(session);+          let holder = resolvedId;+          if (!pending) { const any = findAnyPendingDialog(); if (any) { pending = any; holder = any.sessionId; } }           if (!pending) {             sendJSON(res, {               status: 'ok', handled: false, dialog: null,@@ -18785,7 +18802,8 @@ const server = http.createServer(async (req, res) => {             });             return;           }-          const tab = session.tabs.find(t => t && t.pendingDialog);+          const holdSession = sessions.get(holder) || session;+          const tab = holdSession.tabs.find(t => t && t.pendingDialog);           try {             if (action === 'accept') await pending.dialog.accept(args && args.promptText !== undefined ? String(args.promptText) : undefined);             else await pending.dialog.dismiss();@@ -18796,9 +18814,9 @@ const server = http.createServer(async (req, res) => {           }           if (tab) tab.pendingDialog = null;           sendJSON(res, {-            status: 'ok', handled: true, action,+            status: 'ok', handled: true, action, window: holder,             dialog: { type: pending.type, message: pending.message },-            _hint: `Answered "${action}". The window is unblocked; the verb that timed out can be retried now.`,+            _hint: `Answered "${action}" on window "${holder}". EVERY pup window is unblocked now, not just that one, and the verb that timed out can be retried.`,           });           return;         }@@ -19455,19 +19473,22 @@ const server = http.createServer(async (req, res) => {     // touches a page with a modal up returns some flavour of "timed out", and three different     // timeout messages taught the AI nothing about the real cause. If a dialog is pending on this     // session, the timeout is EXPLAINED rather than reported bare.+    // v2.0.353: scan EVERY session, not args.sessionId. The first cut looked the dialog up on+    // `args.sessionId`, which is the LEGACY id: pup's documented addressing is zero-id ({} resolves+    // to your thread's window) or {window:"..."}, so args.sessionId is normally undefined and this+    // whole branch never ran. The feature worked only for the one calling convention almost nobody+    // uses, which is why it looked shipped and behaved exactly as if it had never been written.     try {-      const _a2 = (typeof args !== 'undefined' && args) || {};-      const _s2 = _a2.sessionId && sessions.get(_a2.sessionId);-      const _d = _s2 && findPendingDialog(_s2);+      const _d = findAnyPendingDialog();       if (_d && /timed out|timeout|detached|Target closed|Session closed/i.test(e.message || '')) {         sendJSON(res, {           status: 'error',-          error: `a ${_d.type} dialog is open and BLOCKING this window: ${JSON.stringify(_d.message)}`,+          error: `a ${_d.type} dialog in window "${_d.sessionId}" is BLOCKING EVERY pup window: ${JSON.stringify(_d.message)}`,           errorCode: 'dialog_open',-          dialog: { type: _d.type, message: _d.message, defaultValue: _d.defaultValue, tabId: _d.tabId },-          _hint: _d.type === 'beforeunload'-            ? `The page is asking to confirm leaving with UNSAVED CHANGES. pup will not answer this for you, because "Cancel" silently discards the user's work and "Reload" silently loses it. Decide, then call pup_dialog {"action":"accept"} to go ahead with the reload/navigation, or {"action":"dismiss"} to stay on the page. If the work matters, read it out with pup_eval FIRST.`-            : `Answer it with pup_dialog {"action":"accept"} or {"action":"dismiss"}${_d.type === 'prompt' ? ', optionally with {"promptText":"..."} for a prompt' : ''}. Nothing else on this window will respond until you do.`,+          dialog: { type: _d.type, message: _d.message, defaultValue: _d.defaultValue, tabId: _d.tabId, window: _d.sessionId },+          _hint: `EVERY pup window is stuck until this is answered, including windows that have nothing to do with it, because pup's windows share one browser and a modal blocks the browser. The dialog is in window "${_d.sessionId}".` + (_d.type === 'beforeunload'+            ? ` It is asking to confirm leaving a page with UNSAVED CHANGES. pup will not answer it for you: "Cancel" keeps the page and blocks your navigation, "Reload" throws the changes away. Decide, then call pup_dialog {"window":"${_d.sessionId}","action":"accept"} to proceed, or "dismiss" to stay. If the unsaved work might matter, read it out with pup_eval FIRST.`+            : ` Answer it with pup_dialog {"window":"${_d.sessionId}","action":"accept"} or "dismiss"${_d.type === 'prompt' ? ', optionally with promptText' : ''}.`),         }, 200);         return;       }