← Commit history

No more generic-globe flash: applyAppOverlay caches the last REAL favicon per session (keyed by URL) and reuses it instead of downgrading to the generic globe when a same-page repaint can't re-fetch the favicon (the post-re-stamp case). Gated on unchanged URL so a real navigation to a truly faviconless page still falls through to the generic glyph. Runtime-only, no icon-gen bump / no re-stamp.

John Lauer ·1a0575cc46 ·3mo ago ·parent fb372cb
4 files changed +21−7
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.338",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.338/adom-bridge-puppeteer-v1.9.338.zip",-  "sha256": "11b129c33181c99337a340ae564e32dc16160592b342e22ac71a7b61e383e49c",-  "size": 629828,+  "version": "1.9.339",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.339/adom-bridge-puppeteer-v1.9.339.zip",+  "sha256": "65c2b17840b9b6ce1d7e678ab0cc9dac33f2db8e861435d37850d2b5c867b560",+  "size": 630239,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.338+1.9.339
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.338",+  "version": "1.9.339",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+15−1
@@ -4592,7 +4592,7 @@ async function applyAppOverlay(session, sessionId) {     if (!src) {       // v1.9.238: rich, dark-taskbar-aware resolution + full state capture.       const rich = await resolveFaviconRich(activePage).catch(() => null);-      if (rich && rich.b64) { src = { b64: rich.b64, mime: rich.mime, href: rich.href }; session._overlayFav = rich; }+      if (rich && rich.b64) { src = { b64: rich.b64, mime: rich.mime, href: rich.href }; session._overlayFav = rich; try { session._lastRealSrc = { b64: rich.b64, mime: rich.mime, href: rich.href, forUrl: (activePage && activePage.url()) || null }; } catch (e) {} }     }     if (!src || !src.b64) {       // v1.9.43: RETRY once shortly after. The old code gave up silently on the first miss, so a@@ -4625,6 +4625,20 @@ async function applyAppOverlay(session, sessionId) {           }         }       } catch (e) {}+      // #globe-flash (John: "skip the generic-globe intermediate after a re-stamp"): NEVER downgrade a+      // window's REAL favicon to the generic globe. If we couldn't re-resolve it THIS cycle but the page+      // is the SAME one we last painted a real favicon for (the classic case: an icon-gen re-stamp+      // recreated the button and repainted before the favicon was re-fetchable), reuse that last real+      // favicon instead of flashing the globe. Gated on the URL being unchanged, so a genuine navigation+      // to a truly faviconless page still correctly falls through to the generic glyph below.+      if ((!src || !src.b64) && session._lastRealSrc && session._lastRealSrc.b64) {+        let _curUrl = ''; try { _curUrl = (activePage && activePage.url()) || ''; } catch (e) {}+        if (_curUrl && session._lastRealSrc.forUrl === _curUrl) {+          src = { b64: session._lastRealSrc.b64, mime: session._lastRealSrc.mime, href: session._lastRealSrc.href };+          session._overlayFav = { kind: 'page-favicon', format: 'png', mode: 'default', transparent: null, via: 'reused last real favicon (re-fetch missed this cycle — no downgrade to generic)', href: src.href };+          console.log(`[overlay] "${sessionId}" reused last real favicon (${src.href}) instead of the generic globe — same page, favicon just not re-fetchable this cycle`);+        }+      }       if (!src || !src.b64) {         // Generic glyph: a teal-on-dark globe, same silhouette Chrome falls back to.         // v1.9.206: the glyph must be BRIGHT and BOLD. My first version used a #123033 plate with