← Commit history

Turns OFF Chromes native Save password bubble (John: the save dialog is still showing, just always automatically handle this). pup now owns credential capture end to end: the login-capture rail (hardened in 2.0.121 to grab on password blur/change so it beats cross-origin SSO redirects like Gusto) records into the OS keychain vault, and autofill sets values directly over CDP with no dropdown and no foreground. Chromes bubble was redundant since pup grew its own vault and was the exact dialog the user did not want. Applies on the next window launch since the pref is read at Chrome startup

John Lauer ·18ffd2a210 ·2mo ago ·parent 2d3cae8
4 files changed +16−10
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "2.0.121",-  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.121/adom-bridge-puppeteer-v2.0.121.zip",-  "sha256": "5d536b8ced13fb6982f96d09d67a7c3422111321cd33c316eea728ba9fd4d098",-  "size": 864756,+  "version": "2.0.122",+  "url": "https://wiki.adom.inc/download/adom/pup-bridge/2.0.122/adom-bridge-puppeteer-v2.0.122.zip",+  "sha256": "341f6a1085eb423effb451638c23f411be290de068ff1b79e3f5f0899ac8da08",+  "size": 864984,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-2.0.121+2.0.122
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "2.0.121",+  "version": "2.0.122",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. pup_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. pup_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, pup_alert_window posts a native toast whose click focuses the window, pup_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-bridge",   "author": "Adom Inc.",
src/server.js+10−4
@@ -2587,10 +2587,16 @@ function prepareCleanProfile(userDataDir) {     try { prefs.browser = prefs.browser || {}; prefs.browser.promotional_tabs_enabled = false; } catch (e) {}     prefs.profile.exit_type = 'Normal';     prefs.profile.exited_cleanly = true;-    // v1.9.129: the durable profile exists to ACCUMULATE logins — make sure Chrome's own-    // password manager is on so the "Save password?" bubble can do its job.-    prefs.credentials_enable_service = true;-    prefs.profile.password_manager_enabled = true;+    // v2.0.122 (John: "the save dialog is still showing... i'd like you to just always+    // automatically handle this"). Chrome's native "Save password?" bubble is OFF now — pup owns+    // credential capture (the login-capture rail, hardened in 2.0.121 to grab on password+    // blur/change so it beats cross-origin SSO redirects) and fills from its own keychain vault+    // over CDP (no dropdown, no foreground). Chrome's bubble was redundant and the exact dialog+    // John did not want. (Was on since v1.9.129, before pup had its own vault.) Autofill via+    // fillLoginForm is unaffected — it sets values directly, independent of Chrome's manager.+    prefs.credentials_enable_service = false;+    prefs.profile.password_manager_enabled = false;+    prefs.profile.password_manager_leak_detection = false;     prefs.session = prefs.session || {};     prefs.session.restore_on_startup = 5; // 5 = new tab page; 1 = restore last     prefs.session.startup_urls = [];