← Commit history

Concurrent opens on one profile no longer kill each other (found by John's 3-phase test: 10 PARALLEL opens on the shared profile — 9 of 10 died 'Navigating frame was detached'; every earlier stress pass had opened sequentially, hiding it, and ten threads opening default windows simultaneously is exactly what a fleet of AI threads does). The launch itself was already deduped (_launchInFlight); the kill happened AFTER: each open runs closeRestoredLeftoverTabs, which closes any page it doesn't recognize — including the SIBLING open's just-created page mid-navigation. Every pup-created page is now marked _pupCreated at all three creation sites (new-window path, tab fallback, plain newPage) and the cleanup skips marked pages, so it can only ever close genuine session-restore leftovers, which is its actual job.

John Lauer ·18f1cc7bb8 ·3mo ago ·parent d57529f
4 files changed +14−7
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.9.141",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.141/adom-bridge-puppeteer-v1.9.141.zip",-  "sha256": "0a3392fafdeb7525b878c14ea203576d2e704e9e1eceed29f3626db80104e791",-  "size": 396222,+  "version": "1.9.142",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.9.142/adom-bridge-puppeteer-v1.9.142.zip",+  "sha256": "115745bb250644dc94d253126320107009813f38b8a439f0f373e05ae70e4112",+  "size": 396434,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.9.141+1.9.142
src/bridge.json+1−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.9.141",+  "version": "1.9.142",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job. macOS (v1.9.74+): full parity with mac-native mechanics \u2014 background-by-default is the app-level hide (windows stay drivable/screenshottable while hidden), raise/lower map to unhide+activate/hide, browser_alert_window posts a native toast whose click focuses the window, browser_use {browser:'chrome',install:true} installs Chrome from the official dmg, and taskbar identity/badging remains Windows-only.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",
src/server.js+8−1
@@ -1705,6 +1705,11 @@ async function closeRestoredLeftoverTabs(browser, keepPage) {     const pages = await browser.pages();     for (const p of pages) {       if (p === keepPage) continue;+      // v1.9.142 (John's 3-phase test found it): NEVER close a page pup itself created. Two+      // concurrent opens on the same profile each ran this cleanup and shot the SIBLING's+      // just-created page mid-goto ('Navigating frame was detached') — 9 of 10 parallel opens+      // died. Restored leftovers are pages pup did NOT create; the marker is the difference.+      if (p._pupCreated) continue;       // Skip blank/about:blank (Chrome's default first tab) — handled separately       let url = '';       try { url = p.url() || ''; } catch {}@@ -5347,10 +5352,12 @@ async function launchSession(sessionId, url, { freshProfile = false, profile, st     console.log(`Reusing existing blank tab (${page.url()}) for session "${sessionId}"`);   } else if (profileAlreadyInUse) {     page = await createPageInNewWindow(browser);+    if (page) page._pupCreated = true;   // v1.9.142: never a 'restored leftover' — see closeRestoredLeftoverTabs     if (page) console.log(`Session "${sessionId}" opened in its OWN window on shared profile "${profileName}"`);-    else { console.log(`[window] newWindow target failed for "${sessionId}" -- falling back to a tab`); page = await browser.newPage(); }+    else { console.log(`[window] newWindow target failed for "${sessionId}" -- falling back to a tab`); page = await browser.newPage(); page._pupCreated = true; }   } else {     page = await browser.newPage();+    page._pupCreated = true;   // v1.9.142   }    // Always open the welcome page first — it shows session identity (sessionId,