← Commit history

v1.8.5: SDK-audit fixes — truthful ready-based status chip (was false-yellow on Edge-only boxes) + re-declared prewarm.assets per SDK checklist

John Lauer ·1678b9f58f ·4mo ago ·parent 01266bd
5 files changed +20−12
adom-bridge-puppeteer-manifest.json+4−4
@@ -1,10 +1,10 @@ {   "manifest_version": 1,   "name": "puppeteer",-  "version": "1.8.4",-  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.8.4/adom-bridge-puppeteer-v1.8.4.zip",-  "sha256": "cb2811474262877d135a32c7f24c7f1712ac65add682458db023a1ecfc862ecd",-  "size": 131364,+  "version": "1.8.5",+  "url": "https://wiki.adom.inc/download/adom/adom-desktop-puppeteer-bridge/1.8.5/adom-bridge-puppeteer-v1.8.5.zip",+  "sha256": "43b820aea2a6a1e9e9ae3747b6995288fcd076928387ae3f892c24605bf977e5",+  "size": 131527,   "verbPrefixes": [     "browser_",     "desktop_recorder_",
package.json+1−1
@@ -1,6 +1,6 @@ {   "slug": "adom-desktop-puppeteer-bridge",-  "version": "1.8.5",+  "version": "1.8.6",   "type": "app",   "description": "CONTAINER-SIDE install \u2014 the pup skill pack in the wiki skillpack layout: the everyday `pup` user skill PLUS two bundled developer sub-skills (pup-bridge-dev, pup-bridge-publish; user-invocable:false, DEVELOPER-only descriptions so they never trigger for everyday users), all dropped into ~/.claude/skills/ AND ~/.codex/skills/ by an explicit install.sh list. It does NOT contain the bridge runtime: the bridge (Node + browser driving) lives on the DESKTOP \u2014 bundled inside Adom Desktop and published on the Releases tab as adom-bridge-puppeteer-v<ver>.zip, which Adom Desktop streams into its bridges-cache. TL;DR: pkg install = the skill pack; the bridge = the Release zip + bundled in Adom Desktop.",   "keywords": [
src/BRIDGE_VERSION+1−1
@@ -1 +1 @@-1.8.4+1.8.5
src/bridge.json+6−1
@@ -2,7 +2,7 @@   "manifest_version": 1,   "name": "puppeteer",   "displayName": "Puppeteer (Chrome for Testing + Native)",-  "version": "1.8.4",+  "version": "1.8.5",   "description": "Drives a browser ALREADY on the machine \u2014 installed Chrome, else Microsoft Edge (every Windows PC ships with Edge) \u2014 launched with a FRESH isolated profile, so the common case has NO ~150 MB Chrome-for-Testing download and it never touches the user's real tabs/logins. Binds its local server to LOOPBACK (127.0.0.1) only, so no Windows Firewall 'allow Node through the firewall' prompt ever pops. Chrome for Testing is fetched only as a LAST RESORT if the machine has no Chromium browser at all. SPAWN-VERIFIED fallback: pup tries each detected browser (Chrome \u2192 Edge \u2192 CfT) and actually launches it, falling through to the next if one won't start (and handling browsers like Edge that relaunch onto another PID), so a corrupt/partial install never hard-fails an open. The browser that launches is cached as the default (persisted across restarts) so it isn't re-probed each time. On spawn the bridge SELF-WARMS: detects browsers + disk, and only if the box has no Chrome/Edge and no cached CfT does it background-fetch CfT so the first open is instant. browser_use pins a specific browser (chrome | edge | cft | auto); {browser:'chrome',install:true} downloads & installs REAL Google Chrome (user-scoped, no admin) on an Edge-only box. browser_readiness (READ-ONLY) reports which browser will be used + the full candidate list + the default + free disk. Every failure returns a specific errorCode + _hint (chrome_install_no_disk, chrome_download_network, chrome_install_permission, chrome_stable_not_detected, \u2026). Launches with FULL browser permissions by default for full debug (strictPermissions:true opts out). Headful automation: open/close windows+tabs, navigate, screenshot, eval JS, record. pup is a GENERIC, non-profile browser only \u2014 every session is a fresh isolated Chrome/Edge process, never the user's real signed-in browser; profile defaults to sessionId. To drive the user's REAL Chrome/Edge (their profile, cookies, SSO), use the Adom browser EXTENSION's nbrowser_* verbs \u2014 a separate bridge, not pup's job.",   "homepage": "https://wiki.adom.inc/adom/adom-desktop",   "author": "Adom Inc.",@@ -84,5 +84,10 @@       "supported": false,       "reason": "Linux port pending \u2014 same killImageName + Chrome resolution issues as macOS."     }+  },+  "prewarm": {+    "assets": [+      "chrome-for-testing"+    ]   } }\ No newline at end of file
src/server.js+8−5
@@ -4094,12 +4094,15 @@ const server = http.createServer(async (req, res) => {       } else if (rd.installing) {         led = 'yellow'; summary = `Installing Chrome ${rd.installProgressPct}%`;         tooltip = `Puppeteer bridge v${BRIDGE_VERSION}\nDownloading Chrome for Testing (${rd.installProgressPct}%) — pup not ready yet.\nPoll browser_readiness until ready.`;-      } else if (!rd.chromeForTestingInstalled) {-        led = 'yellow'; summary = 'Chrome not installed';-        tooltip = `Puppeteer bridge v${BRIDGE_VERSION}\nChrome for Testing not installed yet — pup will fetch it on first use (or call browser_prewarm).`;+      } else if (!rd.ready) {+        // No drivable browser AT ALL (no Chrome, no Edge, no cached CfT) — the rare case.+        led = 'yellow'; summary = 'No browser yet';+        tooltip = `Puppeteer bridge v${BRIDGE_VERSION}\nNo Chrome/Edge detected and Chrome for Testing not cached — pup will fetch CfT on first use (or call browser_prewarm). Installing Chrome or Edge is instant, no download.`;       } else {-        led = 'green'; summary = `${sessions.size} window${sessions.size === 1 ? '' : 's'}`;-        tooltip = `Puppeteer bridge v${BRIDGE_VERSION} — ready\nChrome for Testing ${rd.chromeBuildId || 'installed'} · ${sessions.size} session(s)`;+        // READY: a drivable browser exists (installed Chrome/Edge, or cached CfT).+        // Installed-browser-first model — CfT being absent is NOT a warning state.+        led = 'green'; summary = `${sessions.size} window${sessions.size === 1 ? '' : 's'} · ${rd.browserKind}`;+        tooltip = `Puppeteer bridge v${BRIDGE_VERSION} — ready\nDrives ${rd.browserKind} (${rd.browserSource}) · ${sessions.size} session(s)${rd.chromeForTestingInstalled ? `\nCfT ${rd.chromeBuildId || ''} cached as fallback` : ''}`;       }       sendJSON(res, {         ok: true,