Pup - the AI's own browser

@@ -277,18 +277,16 @@ async function applyCredentialsToPage(page, url) { // submitted, usernameValue } and NEVER returns the password. async function fillLoginForm(page, { username, password, submit = false } = {}) {   if (!password) return { ok: false, reason: 'no_password_supplied' };-  const result = await page.evaluate((USERNAME, PASSWORD, SUBMIT) => {+  // Step 1: locate the fields IN-PAGE and TAG them so the Node side can drive them with real+  // keystrokes. (v2.0.123) a password field is not always type=password — Gusto and many+  // SSO/Keycloak themes use type=text + autocomplete="current-password" and mask it themselves.+  const located = await page.evaluate(() => {     const isVisible = (el) => !!el && !el.disabled && el.offsetParent !== null && el.getClientRects().length > 0;-    // v2.0.123: a password field is not always type=password. Modern/custom login UIs (Gusto,-    // many SSO/Keycloak themes) use type=text with autocomplete="current-password" (or name-    // "password") and mask it themselves. Match those too, or pup fills nothing on such forms.     const isPwd = (el) => el && el.tagName === 'INPUT' && (el.type === 'password'       || el.autocomplete === 'current-password' || el.autocomplete === 'new-password'       || /(^|[^a-z])password([^a-z]|$)/i.test(el.name || '') || /(^|[^a-z])password([^a-z]|$)/i.test(el.id || ''));     const pwd = [...document.querySelectorAll('input')].filter(isVisible).find(isPwd);     if (!pwd) return { ok: false, reason: 'no_password_field' };-    // Username: prefer autocomplete=username, then email, else the last visible text-ish input-    // BEFORE the password in DOM order — but NEVER the password field itself (it may be type=text).     const allInputs = [...document.querySelectorAll('input')];     const pi = allInputs.indexOf(pwd);     let user = [...document.querySelectorAll('input[autocomplete="username"], input[type="email"]')].find((e) => isVisible(e) && !isPwd(e));@@ -296,26 +294,48 @@ async function fillLoginForm(page, { username, password, submit = false } = {})       const cands = [...document.querySelectorAll('input[type="text"], input[type="tel"], input:not([type])')].filter((e) => isVisible(e) && !isPwd(e));       user = [...cands].reverse().find((c) => allInputs.indexOf(c) < pi) || cands[0] || null;     }-    const setVal = (el, val) => {-      const proto = el instanceof HTMLTextAreaElement ? HTMLTextAreaElement.prototype : HTMLInputElement.prototype;-      const setter = Object.getOwnPropertyDescriptor(proto, 'value').set;-      try { el.focus(); } catch (e) {}-      setter.call(el, val);-      el.dispatchEvent(new Event('input', { bubbles: true }));-      el.dispatchEvent(new Event('change', { bubbles: true }));-    };-    if (user && USERNAME) setVal(user, USERNAME);-    setVal(pwd, PASSWORD);-    let submitted = false;-    if (SUBMIT) {-      const form = pwd.form;-      const btn = form && [...form.querySelectorAll('button[type="submit"], input[type="submit"], button')].find(isVisible);-      if (btn) { btn.click(); submitted = true; }-      else if (form) { (form.requestSubmit ? form.requestSubmit() : form.submit()); submitted = true; }-    }-    return { ok: true, filledUsername: !!(user && USERNAME), filledPassword: true, submitted, usernameValue: user ? user.value : null };-  }, username || '', password, !!submit);-  return result;+    pwd.setAttribute('data-pup-pf', '1');+    if (user) user.setAttribute('data-pup-uf', '1');+    return { ok: true, hasUser: !!user };+  });+  if (!located.ok) return located;++  // Step 2: type with REAL keystrokes (page.keyboard), not a .value-set. v2.0.124 — React-+  // controlled masked inputs (Gusto's #password is one) IGNORE a programmatic .value: it shows in+  // the DOM but submits empty because the framework's own state never updated. Only genuine key+  // events register. Clear-then-type, verify the value actually landed, retry once if it didn't.+  const typeReal = async (sel, text) => {+    try {+      await page.focus(sel);+      await page.keyboard.down('Control'); await page.keyboard.press('KeyA'); await page.keyboard.up('Control');+      await page.keyboard.press('Backspace');+      await page.type(sel, text, { delay: 12 });+      return true;+    } catch (e) { return false; }+  };+  const valLen = async (sel) => { try { return await page.$eval(sel, (el) => (el.value || '').length); } catch (e) { return 0; } };++  let filledUsername = false;+  if (located.hasUser && username) filledUsername = await typeReal('[data-pup-uf]', username);++  await typeReal('[data-pup-pf]', password);+  if ((await valLen('[data-pup-pf]')) === 0) await typeReal('[data-pup-pf]', password); // one retry — first type can lose to a React re-render+  const filledPassword = (await valLen('[data-pup-pf]')) > 0;++  // Step 3: submit (find the button via the tagged field), clean the tags, click.+  const submitted = await page.evaluate((SUBMIT) => {+    const isVisible = (el) => !!el && !el.disabled && el.offsetParent !== null && el.getClientRects().length > 0;+    const pwd = document.querySelector('[data-pup-pf]');+    const form = pwd && pwd.form;+    const btn = SUBMIT ? ((form ? [...form.querySelectorAll('button[type="submit"], input[type="submit"], button')] : [...document.querySelectorAll('button, input[type="submit"]')]).find(isVisible)) : null;+    document.querySelectorAll('[data-pup-pf],[data-pup-uf]').forEach((e) => { e.removeAttribute('data-pup-pf'); e.removeAttribute('data-pup-uf'); });+    if (!SUBMIT) return false;+    if (btn) { btn.click(); return true; }+    if (form) { (form.requestSubmit ? form.requestSubmit() : form.submit()); return true; }+    return false;+  }, !!submit);++  return { ok: true, filledUsername, filledPassword, submitted }; }  // Pull a stored cred for the page's URL and fill its login form in the